From patchwork Mon Mar 11 18:08:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 13589180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD8D4C54E58 for ; Mon, 11 Mar 2024 18:10:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjk5n-0005Dv-DP; Mon, 11 Mar 2024 14:09:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjk51-0004tX-0i for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:08:59 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjk4z-0004R4-BX for qemu-devel@nongnu.org; Mon, 11 Mar 2024 14:08:54 -0400 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5dbcfa0eb5dso4183721a12.3 for ; Mon, 11 Mar 2024 11:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1710180531; x=1710785331; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ixFEPVp8c6KmG9HvM9JwOcRXeyd4JQRHbHvx2xyG7g=; b=l0znQXubUXM7coF9e9OyewAUHP8vkOOZWbBpsU3wN1k8mVp6ZA1mJoNMmvQV0IkRgZ zM+qkR7LRJYWN25mbcQsH5F5oxMXshVq4Or5mpSJ0IzgGuJmc4vmN+/kiJDEiNIgIoXI Wi2W9v5p31mW3MXZ1Js9vH25yHIc4ZdygOdhyXcm29Rc+jhk+jKiCVIBK9nPEfzGNuHV eU3uIlJL4KQHyQ/G548qAMaM1gaZGZJV19rutAFGFnJwcCd1PClWDrh1lO2/7IGCU8TM nN6OIcq9Nc6Xv8KUeMXV3THZh0T1zv5mBgtYc1Apwqu1ka+zslFMIZoV4LzJ3tEbqprB x8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710180531; x=1710785331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ixFEPVp8c6KmG9HvM9JwOcRXeyd4JQRHbHvx2xyG7g=; b=DYYqq88gzUge0h7AmF2Sxw+koQ/ps1pf2W/MsfBWmMbijQLOAqoU+BQ7LoR4dnhStd HZUHhKWtflXckeYvGg1/4WXsTebu2lJ7LYOPlnF7QM94zNlWXkn9QPEf/t0VESLxqHDB qBJg3yrojYOf7oyjrIX8P0GUBRK68NNJ6AlRT2LC3Wbk9C+kJU7Np3zv44ZY8Nr28fzB Fb3eARqFVtWNrkhY4GjcdNaUq/PbetJCKlsRHyQsnony2ZKqcHNMOYpDZk+Cd53Qpj5y sbZMXl2n6HGO/+V4kD06q65BZQwYvUbuOhGDwUXNoBAsR/Z58n/fx8ODecHc6+mOGUKw yN3w== X-Gm-Message-State: AOJu0Yy2pHrW16WSxbDo7hakXyl4tryyGRnviRbzN2r2/IV2ooYMW1z/ UBBy+2Z0DY8Q409SSBE2JOiAFJ3pNAwc2jQBhB0n9O2qzXR84tjKREnbnMe+CmiIF+mZN9dpDUw + X-Google-Smtp-Source: AGHT+IFUbjsm5EeaD5U1j1b4wMNGMGmHDHBMO6A1MCEo9lAus9f7+mgEZmMoQMsvTNxKpchGuhS7DA== X-Received: by 2002:a17:90a:ff0f:b0:29b:aa36:e845 with SMTP id ce15-20020a17090aff0f00b0029baa36e845mr1223293pjb.43.1710180531385; Mon, 11 Mar 2024 11:08:51 -0700 (PDT) Received: from grind.dc1.ventanamicro.com ([177.94.15.159]) by smtp.gmail.com with ESMTPSA id hk13-20020a17090b224d00b0029c2794d3f7sm525810pjb.7.2024.03.11.11.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 11:08:50 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, philmd@linaro.org, richard.henderson@linaro.org, Daniel Henrique Barboza Subject: [PATCH v12 7/7] target/riscv/vector_helper.c: optimize loops in ldst helpers Date: Mon, 11 Mar 2024 15:08:21 -0300 Message-ID: <20240311180821.250469-8-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240311180821.250469-1-dbarboza@ventanamicro.com> References: <20240311180821.250469-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=dbarboza@ventanamicro.com; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Change the for loops in ldst helpers to do a single increment in the counter, and assign it env->vstart, to avoid re-reading from vstart every time. Suggested-by: Richard Henderson Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson --- target/riscv/vector_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index b4360dbd52..712a2ee4dd 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -209,7 +209,7 @@ vext_ldst_stride(void *vd, void *v0, target_ulong base, VSTART_CHECK_EARLY_EXIT(env); - for (i = env->vstart; i < env->vl; i++, env->vstart++) { + for (i = env->vstart; i < env->vl; env->vstart = ++i) { k = 0; while (k < nf) { if (!vm && !vext_elem_mask(v0, i)) { @@ -277,7 +277,7 @@ vext_ldst_us(void *vd, target_ulong base, CPURISCVState *env, uint32_t desc, VSTART_CHECK_EARLY_EXIT(env); /* load bytes from guest memory */ - for (i = env->vstart; i < evl; i++, env->vstart++) { + for (i = env->vstart; i < evl; env->vstart = ++i) { k = 0; while (k < nf) { target_ulong addr = base + ((i * nf + k) << log2_esz); @@ -393,7 +393,7 @@ vext_ldst_index(void *vd, void *v0, target_ulong base, VSTART_CHECK_EARLY_EXIT(env); /* load bytes from guest memory */ - for (i = env->vstart; i < env->vl; i++, env->vstart++) { + for (i = env->vstart; i < env->vl; env->vstart = ++i) { k = 0; while (k < nf) { if (!vm && !vext_elem_mask(v0, i)) {