diff mbox series

[2/4] linux-user: Fix shmat() strace

Message ID 20240325153313.526888-3-iii@linux.ibm.com (mailing list archive)
State New, archived
Headers show
Series linux-user: Fix shmat(NULL) for h != g | expand

Commit Message

Ilya Leoshkevich March 25, 2024, 3:07 p.m. UTC
The indices of arguments passed to print_shmat() are all off-by-1,
because arg1 is the ipc() command. Fix them.

New output for linux-shmat-maps test:

    3501769 shmat(4784214,0x0000000000800000,SHM_RND) = 0

Fixes: 9f7c97324c27 ("linux-user: Add strace for shmat")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
 linux-user/strace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Henderson March 25, 2024, 6:32 p.m. UTC | #1
On 3/25/24 05:07, Ilya Leoshkevich wrote:
> The indices of arguments passed to print_shmat() are all off-by-1,
> because arg1 is the ipc() command. Fix them.
> 
> New output for linux-shmat-maps test:
> 
>      3501769 shmat(4784214,0x0000000000800000,SHM_RND) = 0
> 
> Fixes: 9f7c97324c27 ("linux-user: Add strace for shmat")
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
>   linux-user/strace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Oops,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 9be71af4016..3b4ccd9fa04 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -703,7 +703,7 @@  print_ipc(CPUArchState *cpu_env, const struct syscallname *name,
         break;
     case IPCOP_shmat:
         print_shmat(cpu_env, &(const struct syscallname){ .name = "shmat" },
-                    arg1, arg4, arg2, 0, 0, 0);
+                    arg2, arg5, arg3, 0, 0, 0);
         break;
     default:
         qemu_log(("%s("