| Message ID | 20240407132125.159528-2-het.gala@nutanix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix: qtest/migration: Improve multifd_tcp_channels_none test | expand |
Hey, Het, On Sun, Apr 07, 2024 at 01:21:24PM +0000, Het Gala wrote: > Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs) I think I get your intention to provide two fixup patches on top of migration-next, which indeed would be preferred so that I can squash them into the patches before the pull. However please next time use "git commit --fixup" so that a better subject will be generated, and that'll make my life (and Fabiano's I suppose in the future) easier because git rebase understand those subjects. Then you don't need Fixes with an empty commit ID. They'll start with "fixup: XXX" pointing to a commit with subject rather than commit IDs. Thanks, > Signed-off-by: Het Gala <het.gala@nutanix.com> > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index d03a655f83..584d7c496f 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1724,7 +1724,7 @@ static void test_precopy_common(MigrateCommon *args) > } > > if (args->result == MIG_TEST_QMP_ERROR) { > - migrate_qmp_fail(from, args->connect_uri, args->connect_uri, "{}"); > + migrate_qmp_fail(from, args->connect_uri, args->connect_channels, "{}"); > goto finish; > }
On 08/04/24 9:05 pm, Peter Xu wrote: > !-------------------------------------------------------------------| > CAUTION: External Email > > |-------------------------------------------------------------------! > > Hey, Het, > > On Sun, Apr 07, 2024 at 01:21:24PM +0000, Het Gala wrote: >> Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs) > I think I get your intention to provide two fixup patches on top of > migration-next, which indeed would be preferred so that I can squash them > into the patches before the pull. > > However please next time use "git commit --fixup" so that a better subject > will be generated, and that'll make my life (and Fabiano's I suppose in the > future) easier because git rebase understand those subjects. Then you > don't need Fixes with an empty commit ID. They'll start with "fixup: XXX" > pointing to a commit with subject rather than commit IDs. I apologize for any inconvenience caused by not using "git commit --fixup" in my previous submission. Let me resend the patchset with correct message convention. Will take care of this in future patches too, thanks for bringing it to my notice. Regards, Het Gala
Het, It's all fine, no worries! This is good enough. Let's finish the discussion in the next patch before a repost. Thanks, On Mon, Apr 8, 2024, 2:35 p.m. Het Gala <het.gala@nutanix.com> wrote: > > On 08/04/24 9:05 pm, Peter Xu wrote: > > !-------------------------------------------------------------------| > CAUTION: External Email > > |-------------------------------------------------------------------! > > Hey, Het, > > On Sun, Apr 07, 2024 at 01:21:24PM +0000, Het Gala wrote: > > Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs) > > > I think I get your intention to provide two fixup patches on top of > migration-next, which indeed would be preferred so that I can squash them > into the patches before the pull. > > However please next time use "git commit --fixup" so that a better subject > will be generated, and that'll make my life (and Fabiano's I suppose in the > future) easier because git rebase understand those subjects. Then you > don't need Fixes with an empty commit ID. They'll start with "fixup: XXX" > pointing to a commit with subject rather than commit IDs. > > I apologize for any inconvenience caused by not using "git commit --fixup" > in my previous submission. Let me resend the patchset with correct message > convention. Will take care of this in future patches too, thanks for > bringing it to my notice. Regards, Het Gala >
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index d03a655f83..584d7c496f 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1724,7 +1724,7 @@ static void test_precopy_common(MigrateCommon *args) } if (args->result == MIG_TEST_QMP_ERROR) { - migrate_qmp_fail(from, args->connect_uri, args->connect_uri, "{}"); + migrate_qmp_fail(from, args->connect_uri, args->connect_channels, "{}"); goto finish; }
Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs) Signed-off-by: Het Gala <het.gala@nutanix.com> --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)