| Message ID | 20240411104340.6617-9-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | misc: Replace sprintf() by snprintf() due to macOS deprecation | expand |
On Thu, 11 Apr 2024 at 11:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, > resulting in painful developper experience. Use snprintf() instead. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/arm/cpu64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c > index 985b1efe16..f0f4fe6714 100644 > --- a/target/arm/cpu64.c > +++ b/target/arm/cpu64.c > @@ -433,7 +433,7 @@ void aarch64_add_sve_properties(Object *obj) > > for (vq = 1; vq <= ARM_MAX_VQ; ++vq) { > char name[8]; > - sprintf(name, "sve%d", vq * 128); > + snprintf(name, sizeof(name), "sve%d", vq * 128); > object_property_add(obj, name, "bool", cpu_arm_get_vq, > cpu_arm_set_vq, NULL, &cpu->sve_vq); > } > @@ -458,7 +458,7 @@ void aarch64_add_sme_properties(Object *obj) > > for (vq = 1; vq <= ARM_MAX_VQ; vq <<= 1) { > char name[8]; > - sprintf(name, "sme%d", vq * 128); > + snprintf(name, sizeof(name), "sme%d", vq * 128); > object_property_add(obj, name, "bool", cpu_arm_get_vq, > cpu_arm_set_vq, NULL, &cpu->sme_vq); > } Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 4/11/24 03:43, Philippe Mathieu-Daudé wrote: > sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, > resulting in painful developper experience. Use snprintf() instead. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > target/arm/cpu64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 985b1efe16..f0f4fe6714 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -433,7 +433,7 @@ void aarch64_add_sve_properties(Object *obj) for (vq = 1; vq <= ARM_MAX_VQ; ++vq) { char name[8]; - sprintf(name, "sve%d", vq * 128); + snprintf(name, sizeof(name), "sve%d", vq * 128); object_property_add(obj, name, "bool", cpu_arm_get_vq, cpu_arm_set_vq, NULL, &cpu->sve_vq); } @@ -458,7 +458,7 @@ void aarch64_add_sme_properties(Object *obj) for (vq = 1; vq <= ARM_MAX_VQ; vq <<= 1) { char name[8]; - sprintf(name, "sme%d", vq * 128); + snprintf(name, sizeof(name), "sme%d", vq * 128); object_property_add(obj, name, "bool", cpu_arm_get_vq, cpu_arm_set_vq, NULL, &cpu->sme_vq); }
sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1, resulting in painful developper experience. Use snprintf() instead. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/arm/cpu64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)