diff mbox series

[PULL,02/46] Kconfig: kvm: allow building without any board

Message ID	20240506075125.8238-3-pbonzini@redhat.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, Fabiano Rosas <farosas@suse.de> Subject: [PULL 02/46] Kconfig: kvm: allow building without any board Date: Mon, 6 May 2024 09:50:41 +0200 Message-ID: <20240506075125.8238-3-pbonzini@redhat.com> In-Reply-To: <20240506075125.8238-1-pbonzini@redhat.com> References: <20240506075125.8238-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.431, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	[PULL,01/46] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK \| expand [PULL,01/46] target/i386: Give IRQs a chance when resetting HF_INHIBIT_IRQ_MASK [PULL,02/46] Kconfig: kvm: allow building without any board [PULL,03/46] tests/qtest: skip m48t59-test if the machine is absent [PULL,04/46] gitlab-ci: adjust msys2-64bit to be able to run qtest [PULL,05/46] kvm: ppc: disable sPAPR code if CONFIG_PSERIES is disabled [PULL,06/46] configs: list "implied" device groups in the default configs [PULL,07/46] alpha: switch boards to "default y" [PULL,08/46] arm: switch boards to "default y" [PULL,09/46] avr: switch boards to "default y" [PULL,10/46] cris: switch boards to "default y" [PULL,11/46] hppa: switch boards to "default y" [PULL,12/46] i386: switch boards to "default y" [PULL,13/46] loongarch: switch boards to "default y" [PULL,14/46] m68k: switch boards to "default y" [PULL,15/46] microblaze: switch boards to "default y" [PULL,16/46] meson: make target endianneess available to Kconfig [PULL,17/46] mips: switch boards to "default y" [PULL,18/46] openrisc: switch boards to "default y" [PULL,19/46] ppc: switch boards to "default y" [PULL,20/46] riscv: switch boards to "default y" [PULL,21/46] rx: switch boards to "default y" [PULL,22/46] s390x: switch boards to "default y" [PULL,23/46] sh4: switch boards to "default y" [PULL,24/46] sparc: switch boards to "default y" [PULL,25/46] tricore: switch boards to "default y" [PULL,26/46] xtensa: switch boards to "default y" [PULL,27/46] docs: document new convention for Kconfig board symbols [PULL,28/46] target/i386: Introduce SapphireRapids-v3 to add missing features [PULL,29/46] bitmap: Use g_try_new0/g_new0/g_renew [PULL,30/46] build: do not build virtio-vga-gl if virgl/opengl not available [PULL,31/46] fw_cfg: remove useless declarations from typedefs.h [PULL,32/46] qdev-core: remove DeviceListener from typedefs.h [PULL,33/46] numa: remove types from typedefs.h [PULL,34/46] net: remove AnnounceTimer from typedefs.h [PULL,35/46] qemu-option: remove QemuOpt from typedefs.h [PULL,36/46] intc: remove PICCommonState from typedefs.h [PULL,37/46] lockable: remove QemuLockable from typedefs.h [PULL,38/46] migration: remove PostcopyDiscardState from typedefs.h [PULL,39/46] monitor: remove MonitorDef from typedefs.h [PULL,40/46] qapi/machine: remove types from typedefs.h [PULL,41/46] display: remove GraphicHwOps from typedefs.h [PULL,42/46] tcg: remove CPU* types from typedefs.h [PULL,43/46] pci: remove some types from typedefs.h [PULL,44/46] kvm: move target-dependent interrupt routing out of kvm-all.c [PULL,45/46] migration: do not include coroutine_int.h [PULL,46/46] qga/commands-posix: fix typo in qmp_guest_set_user_password

Commit Message

Paolo Bonzini May 6, 2024, 7:50 a.m. UTC

KVM code might have to call functions on the PCIDevice that is
passed to kvm_arch_fixup_msi_route().  This fails in the case
where --without-default-devices is used and no board is
configured.  While this is not really a useful configuration,
and therefore setting up stubs for CONFIG_PCI is overkill,
failing the build is impolite.  Just include the PCI
subsystem if kvm_arch_fixup_msi_route() requires it, as
is the case for ARM and x86.

Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/arm/Kconfig  | 2 ++
 target/i386/Kconfig | 2 ++
 2 files changed, 4 insertions(+)

diff mbox series

Patch

diff --git a/target/arm/Kconfig b/target/arm/Kconfig
index bf57d739cd1..5847c5a74a7 100644
--- a/target/arm/Kconfig
+++ b/target/arm/Kconfig
@@ -9,3 +9,5 @@  config ARM
 config AARCH64
     bool
     select ARM
+    # kvm_arch_fixup_msi_route() needs to access PCIDevice
+    select PCI if KVM
diff --git a/target/i386/Kconfig b/target/i386/Kconfig
index ce6968906ee..46898946394 100644
--- a/target/i386/Kconfig
+++ b/target/i386/Kconfig
@@ -1,5 +1,7 @@ 
 config I386
     bool
+    # kvm_arch_fixup_msi_route() needs to access PCIDevice
+    select PCI if KVM
 
 config X86_64
     bool