From patchwork Wed May 15 07:14:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13664778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58352C25B75 for ; Wed, 15 May 2024 07:18:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s78qa-0004bi-MD; Wed, 15 May 2024 03:14:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78qI-0004XM-Ml for qemu-devel@nongnu.org; Wed, 15 May 2024 03:14:26 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78qF-0000oJ-Aw for qemu-devel@nongnu.org; Wed, 15 May 2024 03:14:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1715757263; x=1747293263; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9U8NReqWpaS6WMzQ4uEVQ6iKKTM2a3k2YHd6FNepzus=; b=m83wxokB+oYxatC3Pe8+yY0n1ir7T9vCvodtvzHtnkZVn6shQScp3PZd X/Zcm+itJcV0WD9BETMxfo9EVWAODoFxDTZfkINyoVuAE6YeWiNk+VikG jdAy0ETSt1o//NVNnjf47t1tQlBTULD0kn6abzdd76/d2rkvArbWLa1PI E0J+JR7GmqHr2pdj7cTLPEBMfrCJLRJBjhu/5y4sUi+GhzR0tMCQwYXOP ZzhLu8J6xSogOetSTkPHM42fSTGuA3Rfvqo9meD18/YD3lqGUFOKVUYDb LU77mjFX64x0KpF2OtZUEYmBl3gdQX+zR+nA8+7vAg4aGonv4bVviu+yL A==; X-IronPort-AV: E=Sophos;i="6.08,161,1712613600"; d="scan'208";a="12581794" X-MGA-submission: MDGlluJ/98O0j2vwu7fZS51/kx2v2UWTZy1PMgqciebDbvZqgkPzhN9FW9p34KXR3Ia4rsN+OxbS7CjOGDVc7apfUuxwuCwGqZPMXymuPYL+aH7QDCExxHTLAbcbKAR/VbfhN1eXaJGoSyPAcUDCjOirgOOp+3jckof747d/hNIfmg== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 09:14:16 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AO7CCowNHKvwUWWjoURfp7UlWcTwwNl6J91kB2ojt25gsl85A9bv8DGf/tYBp7dVTPacNC0i25HpbYo5QhyVcVJM07+Aye8mPC5F4Zxx8PbjnKXLd4dbpnnE5OVOYp4pe9oICrAOaiRfrR4rCI3ZksL7OxmjSvGPuyILv77JI65E/uAtBrwkM3WEc4Mie0uMKrQIhAYBpeCzTfcvs63ssrS1YU9TQ9sElNceeoaFdmq+NfDGS97AvfSARLWK8jPGsH5zeCZORI9f+3PDfHP0+HqrhZuj/8MCQdrasMBgZ3aXn2tGdOEjy+97NkSj/MNR6ZDm1b1BmZkfUd4+O8Kxig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9U8NReqWpaS6WMzQ4uEVQ6iKKTM2a3k2YHd6FNepzus=; b=cJt1cygquSvtnVI3uSSroWA4kZL1OyGfTmZeezQJwmxweTkSIpW0hzq9vbs6WZ3f2AFvpTkovzusim4y1dpglncBhIWj4pEJo+L/8IMk70A2GyUGEEgHZy1tzgvcexeyx9hpSLwFwIs9Pe2domA/FPnOA9q1hapRCrLdOCVtAKRa94qxxgYvvMwGUKkeiYHLYD2CmfFbDWUf+Rv/vXb/EsXY4Dtd8RdQjyvTkon1YzDtw8yImxvJuFfyjzFZ138WGGjG8Y3m6fbGWzkJmw+NStkKEnKUdViYREhcQhEo1GW9kxrHofV0ZIJ6k3JW9edM+UYeXSkgWid46pHCFaoSIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS5PR07MB9896.eurprd07.prod.outlook.com (2603:10a6:20b:676::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Wed, 15 May 2024 07:14:14 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%5]) with mapi id 15.20.7544.056; Wed, 15 May 2024 07:14:14 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v2 03/25] intel_iommu: check if the input address is canonical Thread-Topic: [PATCH ats_vtd v2 03/25] intel_iommu: check if the input address is canonical Thread-Index: AQHappd+KiUrruFNmUS5CpwZ2UWvFQ== Date: Wed, 15 May 2024 07:14:14 +0000 Message-ID: <20240515071057.33990-4-clement.mathieu--drif@eviden.com> References: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS5PR07MB9896:EE_ x-ms-office365-filtering-correlation-id: 9bc55aa1-ccb1-472d-1d6d-08dc74aea0a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?6ChVutLHD9o1+su2tOpUJ+bGL/jwVyY?= =?utf-8?q?uNQw7EnpAomo/AbkTootCjylB+zd9R06sLvuqH0cCbfY0r6GC1iImmqNv3CXZlq2Y?= =?utf-8?q?fxnhKc6DSWySHYZbJLkUa6XIHVxFXvI5CGh3ELNy64Jdvl82nAK+KHUUyxGHvVLXl?= =?utf-8?q?WhD/qMdazwaXZbqn9bShzW47loDCStbpVDfkFLoSn7yjaqukoaI2x3Q7lHORRxMRg?= =?utf-8?q?jTGt2FghdtxQFC45GfIG0g0CtitzhKwZoQvZbiKFCLTocHSOU/yKXT1WIC9KAeR9f?= =?utf-8?q?4/rZSpt0NS83qrhW+l4I2tguwicjLrJZzVlXHJSN+wm4OnN2VpwijzBr1Bmq5uhFh?= =?utf-8?q?YT2XmLO+il1LlF3exQVAwhTAk/phGBgAlL1zSTRHHu9h0s0HXUwh1cbYJzom4iUB5?= =?utf-8?q?pfL9WXabZKnH27am73STxNhsfr9pnZHuJ4Uy8qvBtGfgeG0Cd+k6iqBdpQdhK6zA9?= =?utf-8?q?yfj4PmD9jA0ht2l7DKYoo4tpWwBU6yP8up6nYGikTj44H6cohxnG+lkuCF9WLs36k?= =?utf-8?q?U7T0WDm3FsMBTug9Gkia7508c+HgundqtB/X3NDVuEeU1Jf+AxxrTyZnWA44IIMsz?= =?utf-8?q?q1S8GxzoZuXLDJvWEPZJDxMryvO7B18dJwd4DKm03LrbYHKDzOsSSbrjHS9oqWo5e?= =?utf-8?q?5wB7iFaOPRcEkdGHp6/cHvST1Uxc4e9coCwrjCAdy1+ABOlLr3qgXdX9FmrKrYPC9?= =?utf-8?q?w1vkLxx4l6N6Xj84QUkmaCTufpUYzbqIqpzCNWAvqP8s5XYsqP/+hvnLeircrDVu+?= =?utf-8?q?ydkPIN4i2qE0yAYgAq+15BGBGeQL9bWB6+q+PxqCWBiqYrqNxqxoS0iXssKUMUASf?= =?utf-8?q?GRtwdOf2lwP0KK2Qc+ZG2v2QxUHSTpfZr5CH7KMgiDq0Ud6zxnklGEpfRc9R4Z9Ko?= =?utf-8?q?A+3giTzslHZ9ZLLk43ZestuItAl1e6ScFeIg7H/NeuwXgBqkuU/zhGv+Msdfg5FBN?= =?utf-8?q?JeUIeh5uRbiTQadspv9RaX0KnLQi5EzcfCm1NYeFS4zD6dOl9gCV6mkQQjr/taCi1?= =?utf-8?q?BBh5TSoUvxwyQRMCHZtLzzRqqH8JfhPiAk6Qmb3POjXvhbjTnx0nrkV5c+ayVC4VX?= =?utf-8?q?Jc31xQzL2H4mDkRal3zdz2EHD8WZwcqrarZxqJiF6kn9GCyGHL2GeFeJeRPt05kDx?= =?utf-8?q?8qW6XDal+YJ0VqjQgyEhmvwwOhDagY2raNcjJASyh86dQTgUc5WierkFfBMDsjnGd?= =?utf-8?q?K3WuL6mL1TFRMfexj3Ik+PRRCnzDpzLe11knS6lk/1FixUL99g9Y3a7BQySsWuscm?= =?utf-8?q?suOF9k8g8noq5m6XGtHPGX3C5GrG83EY2BQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?Q1lhj8lROVvn/YKgT4kGJbW+d9eM?= =?utf-8?q?HtBjPwyiuuiLvB1pwAU5voXQ048wvFIpy9eVc3I8uvOgO5SBX8e6jh3QvGQbsjzkX?= =?utf-8?q?DnTMN2ngDmvwsAm8Mszzcc/h0RerqQ8w4PrD3CLRdnx/K683FwjrEZiKGCkDzLryX?= =?utf-8?q?mbLkMwpAkZhs36+d2OPvovxhbuoXfSMyDRvoOLV5mfVmE8otbLBrp+1cHCKp8C5B4?= =?utf-8?q?fdo5zVQ1juVaAa/ujPPyEKYsdYaSbOZmFtWCppR1bgn0tWqE/K6eEe9OmG4yB0rl8?= =?utf-8?q?CopKerCtNyUM5wESUTasdFzby3Whu7YbDjQ93kKzhgGtgeNWrKCmSyDlfFmHiN/tv?= =?utf-8?q?X4Gs1Ab0dGPbdFI8EkAcmcPesw/aiQfzGz7Gbywf4bQrzSe2wsJVKPGp6sBtxMODm?= =?utf-8?q?C7I7G12dvE5JZ+3HRX5C71Hs4BjI6SgJjaxv5athi6Ag0bRDsIpcVEHLwxbeOaGTu?= =?utf-8?q?SusMPVHTLpqo3g/efIbTWeyEmgIhkWfn1lC4G4X+o3zQuPJKOZC/Wpy0k8aIWWf/7?= =?utf-8?q?SnZS73cuxXNj+/Ynvb9IjwFOIOADhlwk+CUNmaP6VfgkTm4Mhf7TLvw7ifjXN98LH?= =?utf-8?q?UMGWXglN4lijqpz0Vbsdti4j/j9fqLlRI12i3CS6legtL410mFb2xjVliaMr8god9?= =?utf-8?q?/0zUx+XO7TJHo0rSLNFhtAfi21aVNwC9ip3ApvlCvzaqleffYQQSY8gsVbhcRNDe5?= =?utf-8?q?/CEv3fGjH2+tqoHeRnfv3q/AGILjtMUEgivKgmzAtFM+M5574Qn+waP2k/mJ3+GRx?= =?utf-8?q?eGG2eiTYTmrMTqONrAscoyyv41Z5zBdIdmfMSb31JIPa6GlFc3zogjFEB/wLdnMsI?= =?utf-8?q?tacPal/VNuZ0jjuLNDyy3npMfgUzYx0Z+KXcm0Trpdpcwzxo4GLjZYCljFzHeCzSE?= =?utf-8?q?QNtb8sZE7wCSoh+trife68JjPoAwGTYD02do2DxororeD80Yr5yg0opqHH3MU0gFZ?= =?utf-8?q?8R/N6z3m0qpafBTb/1dDWfoYataRsEPfyPf0MsrUgE6+8EsUDQuP0adbwhRVGxuix?= =?utf-8?q?EI4uD8l/kX6ZehTK15qkeybPpXQOsTDWne1opCYsg9e3TZWYUKUyWXN2s5nGKwQ6S?= =?utf-8?q?+8FcHo16WufWNuVwDz878EkzlQL+zlcZEDCe/gIWJwVF24augkyzqxQ8e6vESpy+A?= =?utf-8?q?fEcNtwhxZhwlAx/WeAtsV9AtuDMn2E5fWtIgSOLiL9rJGjPZr11RMwGZKDmOKsbpF?= =?utf-8?q?gQAbFazQCxK4LgIperl83uxdbQogf53thHpbTJeuKadkRFvuklwg8Fwir64Kxe6RO?= =?utf-8?q?R9QE5ZA0CizrYgc4tKTp8h9S3UcsHNS/G5PIrebMwC0i2boklfQoeeNiZXBwcnOPq?= =?utf-8?q?URnG610H3vV7xvYOWOBoRdwqrnklQK8S3tkjTqQSlW0Oag6Lpyymgyr1XNF/CBo3N?= =?utf-8?q?3nWqBsIRg9yA0bRIi7HV/Bo5wH0SDzGjCTjEcI+obqVhmo3BvbxPk5s+2112ri5DO?= =?utf-8?q?9aIh9ML7VJW3feCQye/MsW51w6uqjE7mwt4yw4RoyfBAFCyPeKZW1cdTjGRtFJAZ2?= =?utf-8?q?9UdlWamB+7H/tZdsRvRvJUl21m/gEEtdfBSOzsR1QmOSeHiL/LXdd1o=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc55aa1-ccb1-472d-1d6d-08dc74aea0a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:14:14.7333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aByEgcxOj8EIYo0JplJZLILyRvsmqYaB5H3cWMbdcmSWdYfUGpO90ez79FbnMcFUuwEYaX+DjdJbeWbD95HdnEUHFZ169SBg1wwxDaL73k3WCGBxsG6uzv7pNw0V/RVr X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR07MB9896 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org First stage translation must fail if the address to translate is not canonical. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 21 +++++++++++++++++++++ hw/i386/intel_iommu_internal.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 80cdf37870..0ecf00f37a 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1912,6 +1912,7 @@ static const bool vtd_qualified_faults[] = { [VTD_FR_PASID_ENTRY_P] = true, [VTD_FR_PASID_TABLE_ENTRY_INV] = true, [VTD_FR_SM_INTERRUPT_ADDR] = true, + [VTD_FR_FS_NON_CANONICAL] = true, [VTD_FR_MAX] = false, }; @@ -2023,6 +2024,20 @@ static inline uint64_t vtd_get_flpte_addr(uint64_t flpte, uint8_t aw) return flpte & VTD_FL_PT_BASE_ADDR_MASK(aw); } +/* Return true if IOVA is canonical, otherwise false. */ +static bool vtd_iova_fl_check_canonical(IntelIOMMUState *s, uint64_t iova, + VTDContextEntry *ce, uint32_t pasid) +{ + uint64_t iova_limit = vtd_iova_limit(s, ce, s->aw_bits, pasid); + uint64_t upper_bits_mask = ~(iova_limit - 1); + uint64_t upper_bits = iova & upper_bits_mask; + bool msb = ((iova & (iova_limit >> 1)) != 0); + return !( + (!msb && (upper_bits != 0)) || + (msb && (upper_bits != upper_bits_mask)) + ); +} + /* * Given the @iova, get relevant @flptep. @flpte_level will be the last level * of the translation, can be used for deciding the size of large page. @@ -2038,6 +2053,12 @@ static int vtd_iova_to_flpte(IntelIOMMUState *s, VTDContextEntry *ce, uint32_t offset; uint64_t flpte; + if (!vtd_iova_fl_check_canonical(s, iova, ce, pasid)) { + error_report_once("%s: detected non canonical IOVA (iova=0x%" PRIx64 "," + "pasid=0x%" PRIx32 ")", __func__, iova, pasid); + return -VTD_FR_FS_NON_CANONICAL; + } + while (true) { offset = vtd_iova_fl_level_offset(iova, level); flpte = vtd_get_flpte(addr, offset); diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index 901691afb9..e9448291a4 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -324,6 +324,8 @@ typedef enum VTDFaultReason { VTD_FR_PASID_ENTRY_P = 0x59, /* The Present(P) field of pasidt-entry is 0 */ VTD_FR_PASID_TABLE_ENTRY_INV = 0x5b, /*Invalid PASID table entry */ + VTD_FR_FS_NON_CANONICAL = 0x80, /* SNG.1 : Address for FS not canonical.*/ + /* Output address in the interrupt address range for scalable mode */ VTD_FR_SM_INTERRUPT_ADDR = 0x87, VTD_FR_MAX, /* Guard */