| Message ID | 20240523145522.313012-13-sgarzare@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD) | expand |
On 23.05.24 16:55, Stefano Garzarella wrote: > `memory-backend-memfd` is available only on Linux while the new > `memory-backend-shm` can be used on any POSIX-compliant operating > system. Let's use it so we can run the test in multiple environments. > > Acked-by: Thomas Huth <thuth@redhat.com> > Acked-by: Stefan Hajnoczi <stefanha@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > tests/qtest/vhost-user-blk-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c > index 117b9acd10..e945f6abf2 100644 > --- a/tests/qtest/vhost-user-blk-test.c > +++ b/tests/qtest/vhost-user-blk-test.c > @@ -906,7 +906,7 @@ static void start_vhost_user_blk(GString *cmd_line, int vus_instances, > vhost_user_blk_bin); > > g_string_append_printf(cmd_line, > - " -object memory-backend-memfd,id=mem,size=256M,share=on " > + " -object memory-backend-shm,id=mem,size=256M,share=on " Can we simplifya nd drop the share=on? Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, May 23, 2024 at 05:06:00PM GMT, David Hildenbrand wrote: >On 23.05.24 16:55, Stefano Garzarella wrote: >>`memory-backend-memfd` is available only on Linux while the new >>`memory-backend-shm` can be used on any POSIX-compliant operating >>system. Let's use it so we can run the test in multiple environments. >> >>Acked-by: Thomas Huth <thuth@redhat.com> >>Acked-by: Stefan Hajnoczi <stefanha@redhat.com> >>Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> >>Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org> >>Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> >>--- >> tests/qtest/vhost-user-blk-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c >>index 117b9acd10..e945f6abf2 100644 >>--- a/tests/qtest/vhost-user-blk-test.c >>+++ b/tests/qtest/vhost-user-blk-test.c >>@@ -906,7 +906,7 @@ static void start_vhost_user_blk(GString *cmd_line, int vus_instances, >> vhost_user_blk_bin); >> g_string_append_printf(cmd_line, >>- " -object memory-backend-memfd,id=mem,size=256M,share=on " >>+ " -object memory-backend-shm,id=mem,size=256M,share=on " > >Can we simplifya nd drop the share=on? Good catch! I'll do in the next version! > >Reviewed-by: David Hildenbrand <david@redhat.com> Thanks for the reviews, Stefano
diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk-test.c index 117b9acd10..e945f6abf2 100644 --- a/tests/qtest/vhost-user-blk-test.c +++ b/tests/qtest/vhost-user-blk-test.c @@ -906,7 +906,7 @@ static void start_vhost_user_blk(GString *cmd_line, int vus_instances, vhost_user_blk_bin); g_string_append_printf(cmd_line, - " -object memory-backend-memfd,id=mem,size=256M,share=on " + " -object memory-backend-shm,id=mem,size=256M,share=on " " -M memory-backend=mem -m 256M "); for (i = 0; i < vus_instances; i++) {