| Message ID | 20240528102339.106257-1-vilhelmgyda@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64 | expand |
On 5/28/24 12:23, Will Gyda wrote: > Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. > Solution: microvm is now not build if only Xen is available. This does not fix the issue that microvm does not start with a Xen accelerator. I think it would be better to try and make it work instead. Paolo > Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> > > --- > configs/devices/i386-softmmu/default.mak | 2 +- > hw/i386/Kconfig | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak > index 598c6646df..6a73aee7dd 100644 > --- a/configs/devices/i386-softmmu/default.mak > +++ b/configs/devices/i386-softmmu/default.mak > @@ -29,4 +29,4 @@ > CONFIG_ISAPC=y > CONFIG_I440FX=y > CONFIG_Q35=y > -CONFIG_MICROVM=y > +#CONFIG_MICROVM=n > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index a6ee052f9a..f8ec8ebd7a 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -108,6 +108,8 @@ config Q35 > > config MICROVM > bool > + default y > + depends on KVM || WHPX || NVMM || HVF > select SERIAL_ISA # for serial_hds_isa_init() > select ISA_BUS > select APIC
@philmd commented on gitlab: Discussed with @epilys on IRC, only Xen machines (xenpv/xenfv) configure Xen so can run under it. But if we want to make it work under Xen. Any ideas how to move in that direction? On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini <pbonzini@redhat.com> wrote: > > On 5/28/24 12:23, Will Gyda wrote: > > Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. > > Solution: microvm is now not build if only Xen is available. > > This does not fix the issue that microvm does not start with a Xen > accelerator. I think it would be better to try and make it work instead. > > Paolo > > > Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> > > > > --- > > configs/devices/i386-softmmu/default.mak | 2 +- > > hw/i386/Kconfig | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak > > index 598c6646df..6a73aee7dd 100644 > > --- a/configs/devices/i386-softmmu/default.mak > > +++ b/configs/devices/i386-softmmu/default.mak > > @@ -29,4 +29,4 @@ > > CONFIG_ISAPC=y > > CONFIG_I440FX=y > > CONFIG_Q35=y > > -CONFIG_MICROVM=y > > +#CONFIG_MICROVM=n > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > > index a6ee052f9a..f8ec8ebd7a 100644 > > --- a/hw/i386/Kconfig > > +++ b/hw/i386/Kconfig > > @@ -108,6 +108,8 @@ config Q35 > > > > config MICROVM > > bool > > + default y > > + depends on KVM || WHPX || NVMM || HVF > > select SERIAL_ISA # for serial_hds_isa_init() > > select ISA_BUS > > select APIC >
On Wed, 29 May 2024 at 11:25, Vilhelm Gyda <vilhelmgyda@gmail.com> wrote: > > @philmd commented on gitlab: Discussed with @epilys on IRC, only Xen > machines (xenpv/xenfv) configure Xen so can run under it. > > But if we want to make it work under Xen. Any ideas how to move in > that direction? We'd have to specify what "works under Xen" means; xen as a type 1 hypervisor? I am trying to think if it makes sense, Xen machines in qemu already provide PV devices analogously to what microvm promises to support. What would be the use case for a "hypervisor agnostic" microvm machine? > > On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini <pbonzini@redhat.com> wrote: > > > > On 5/28/24 12:23, Will Gyda wrote: > > > Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. > > > Solution: microvm is now not build if only Xen is available. > > > > This does not fix the issue that microvm does not start with a Xen > > accelerator. I think it would be better to try and make it work instead. > > > > Paolo > > > > > Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> > > > > > > --- > > > configs/devices/i386-softmmu/default.mak | 2 +- > > > hw/i386/Kconfig | 2 ++ > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak > > > index 598c6646df..6a73aee7dd 100644 > > > --- a/configs/devices/i386-softmmu/default.mak > > > +++ b/configs/devices/i386-softmmu/default.mak > > > @@ -29,4 +29,4 @@ > > > CONFIG_ISAPC=y > > > CONFIG_I440FX=y > > > CONFIG_Q35=y > > > -CONFIG_MICROVM=y > > > +#CONFIG_MICROVM=n > > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > > > index a6ee052f9a..f8ec8ebd7a 100644 > > > --- a/hw/i386/Kconfig > > > +++ b/hw/i386/Kconfig > > > @@ -108,6 +108,8 @@ config Q35 > > > > > > config MICROVM > > > bool > > > + default y > > > + depends on KVM || WHPX || NVMM || HVF > > > select SERIAL_ISA # for serial_hds_isa_init() > > > select ISA_BUS > > > select APIC > > >
On Tue, 28 May 2024 13:23, Will Gyda <vilhelmgyda@gmail.com> wrote: >Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. >Solution: microvm is now not build if only Xen is available. > >Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> > I suggest rewording the commit title to something like "i386: remove microvm from default build" And adding a commit message that explains that the microvm does not work on Xen, hence if only Xen is available it should not be built. Also, you can add a Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294 line before your Signed-off-by. See https://www.qemu.org/docs/master/devel/submitting-a-patch.html But, seeing the issue itself, it's about the microvm being stuck under Xen. So the commit that resolves this would either make it non-stuck or make it impossible to start the vm to begin with. >--- > configs/devices/i386-softmmu/default.mak | 2 +- > hw/i386/Kconfig | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak >index 598c6646df..6a73aee7dd 100644 >--- a/configs/devices/i386-softmmu/default.mak >+++ b/configs/devices/i386-softmmu/default.mak >@@ -29,4 +29,4 @@ > CONFIG_ISAPC=y > CONFIG_I440FX=y > CONFIG_Q35=y >-CONFIG_MICROVM=y >+#CONFIG_MICROVM=n Better remove this altogether since it's not a default anymore. >diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig >index a6ee052f9a..f8ec8ebd7a 100644 >--- a/hw/i386/Kconfig >+++ b/hw/i386/Kconfig >@@ -108,6 +108,8 @@ config Q35 > > config MICROVM > bool >+ default y >+ depends on KVM || WHPX || NVMM || HVF What about TCG? Will it be available if we only build with tcg? > select SERIAL_ISA # for serial_hds_isa_init() > select ISA_BUS > select APIC >-- >2.25.1 > >
On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis <manos.pitsidianakis@linaro.org> wrote: > What about TCG? Will it be available if we only build with tcg? I will try doing this, and report back, and will make the suggested changes, and re-submit. On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis <manos.pitsidianakis@linaro.org> wrote: > > On Tue, 28 May 2024 13:23, Will Gyda <vilhelmgyda@gmail.com> wrote: > >Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. > >Solution: microvm is now not build if only Xen is available. > > > >Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> > > > > > I suggest rewording the commit title to something like > > "i386: remove microvm from default build" > > And adding a commit message that explains that the microvm does not work > on Xen, hence if only Xen is available it should not be built. > > Also, you can add a > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294 > > line before your Signed-off-by. See > https://www.qemu.org/docs/master/devel/submitting-a-patch.html > > But, seeing the issue itself, it's about the microvm being stuck under > Xen. So the commit that resolves this would either make it non-stuck or > make it impossible to start the vm to begin with. > > > >--- > > configs/devices/i386-softmmu/default.mak | 2 +- > > hw/i386/Kconfig | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > >diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak > >index 598c6646df..6a73aee7dd 100644 > >--- a/configs/devices/i386-softmmu/default.mak > >+++ b/configs/devices/i386-softmmu/default.mak > >@@ -29,4 +29,4 @@ > > CONFIG_ISAPC=y > > CONFIG_I440FX=y > > CONFIG_Q35=y > >-CONFIG_MICROVM=y > >+#CONFIG_MICROVM=n > > Better remove this altogether since it's not a default anymore. > > >diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > >index a6ee052f9a..f8ec8ebd7a 100644 > >--- a/hw/i386/Kconfig > >+++ b/hw/i386/Kconfig > >@@ -108,6 +108,8 @@ config Q35 > > > > config MICROVM > > bool > >+ default y > >+ depends on KVM || WHPX || NVMM || HVF > > What about TCG? Will it be available if we only build with tcg? > > > select SERIAL_ISA # for serial_hds_isa_init() > > select ISA_BUS > > select APIC > >-- > >2.25.1 > > > >
diff --git a/configs/devices/i386-softmmu/default.mak b/configs/devices/i386-softmmu/default.mak index 598c6646df..6a73aee7dd 100644 --- a/configs/devices/i386-softmmu/default.mak +++ b/configs/devices/i386-softmmu/default.mak @@ -29,4 +29,4 @@ CONFIG_ISAPC=y CONFIG_I440FX=y CONFIG_Q35=y -CONFIG_MICROVM=y +#CONFIG_MICROVM=n diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index a6ee052f9a..f8ec8ebd7a 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -108,6 +108,8 @@ config Q35 config MICROVM bool + default y + depends on KVM || WHPX || NVMM || HVF select SERIAL_ISA # for serial_hds_isa_init() select ISA_BUS select APIC
Issue #2294: Machine microvm doesn't run under Xen accel for qemu-system-x86_64. Solution: microvm is now not build if only Xen is available. Signed-off-by: Will Gyda <vilhelmgyda@gmail.com> --- configs/devices/i386-softmmu/default.mak | 2 +- hw/i386/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)