| Message ID | 20240530111029.1726329-1-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] vnc: increase max display size | expand |
On Thu, May 30, 2024 at 01:10:29PM +0200, Gerd Hoffmann wrote: > It's 2024. 4k display resolutions are a thing these days. > Raise width and height limits of the qemu vnc server. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1596 > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > ui/vnc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On Thu, 30 May 2024 at 12:11, Gerd Hoffmann <kraxel@redhat.com> wrote: > > It's 2024. 4k display resolutions are a thing these days. > Raise width and height limits of the qemu vnc server. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1596 > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > ui/vnc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ui/vnc.h b/ui/vnc.h > index 4521dc88f792..e5fa2efa3e5d 100644 > --- a/ui/vnc.h > +++ b/ui/vnc.h > @@ -81,8 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, > > /* VNC_MAX_WIDTH must be a multiple of VNC_DIRTY_PIXELS_PER_BIT. */ > > -#define VNC_MAX_WIDTH ROUND_UP(2560, VNC_DIRTY_PIXELS_PER_BIT) > -#define VNC_MAX_HEIGHT 2048 > +#define VNC_MAX_WIDTH ROUND_UP(5120, VNC_DIRTY_PIXELS_PER_BIT) > +#define VNC_MAX_HEIGHT 2160 > > /* VNC_DIRTY_BITS is the number of bits in the dirty bitmap. */ > #define VNC_DIRTY_BITS (VNC_MAX_WIDTH / VNC_DIRTY_PIXELS_PER_BIT) Hi -- somebody on IRC pointed out that this simple patch had been code-reviewed by Daniel but never made it into git. Marc-André: you're listed maintainer for ui/ -- do you have a pullreq planned? Alternatively we could take it via qemu-trivial since it's a pretty tiny patch (cc'd). thanks -- PMM
On Thu, Jul 18, 2024 at 04:58:10PM +0100, Peter Maydell wrote: > On Thu, 30 May 2024 at 12:11, Gerd Hoffmann <kraxel@redhat.com> wrote: > > > > It's 2024. 4k display resolutions are a thing these days. > > Raise width and height limits of the qemu vnc server. > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1596 > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > --- > > ui/vnc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/ui/vnc.h b/ui/vnc.h > > index 4521dc88f792..e5fa2efa3e5d 100644 > > --- a/ui/vnc.h > > +++ b/ui/vnc.h > > @@ -81,8 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, > > > > /* VNC_MAX_WIDTH must be a multiple of VNC_DIRTY_PIXELS_PER_BIT. */ > > > > -#define VNC_MAX_WIDTH ROUND_UP(2560, VNC_DIRTY_PIXELS_PER_BIT) > > -#define VNC_MAX_HEIGHT 2048 > > +#define VNC_MAX_WIDTH ROUND_UP(5120, VNC_DIRTY_PIXELS_PER_BIT) > > +#define VNC_MAX_HEIGHT 2160 > > > > /* VNC_DIRTY_BITS is the number of bits in the dirty bitmap. */ > > #define VNC_DIRTY_BITS (VNC_MAX_WIDTH / VNC_DIRTY_PIXELS_PER_BIT) > > Hi -- somebody on IRC pointed out that this simple patch > had been code-reviewed by Daniel but never made it into git. > Marc-André: you're listed maintainer for ui/ -- do you have > a pullreq planned? > > Alternatively we could take it via qemu-trivial since it's > a pretty tiny patch (cc'd). I'm working on a misc pull request, so I'll just include this patch With regards, Daniel
diff --git a/ui/vnc.h b/ui/vnc.h index 4521dc88f792..e5fa2efa3e5d 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@ -81,8 +81,8 @@ typedef void VncSendHextileTile(VncState *vs, /* VNC_MAX_WIDTH must be a multiple of VNC_DIRTY_PIXELS_PER_BIT. */ -#define VNC_MAX_WIDTH ROUND_UP(2560, VNC_DIRTY_PIXELS_PER_BIT) -#define VNC_MAX_HEIGHT 2048 +#define VNC_MAX_WIDTH ROUND_UP(5120, VNC_DIRTY_PIXELS_PER_BIT) +#define VNC_MAX_HEIGHT 2160 /* VNC_DIRTY_BITS is the number of bits in the dirty bitmap. */ #define VNC_DIRTY_BITS (VNC_MAX_WIDTH / VNC_DIRTY_PIXELS_PER_BIT)
It's 2024. 4k display resolutions are a thing these days. Raise width and height limits of the qemu vnc server. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1596 Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- ui/vnc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)