diff mbox series

[v6,3/3] target/riscv: Apply modularized matching conditions for icount trigger

Message ID 20240627023407.2156838-4-alvinga@andestech.com (mailing list archive)
State New
Headers show
Series RISC-V: Modularize common match conditions for trigger | expand

Commit Message

shiju.jose--- via June 27, 2024, 2:34 a.m. UTC 
From: Alvin Chang via <qemu-devel@nongnu.org>

We have implemented trigger_common_match(), which checks if the enabled
privilege levels of the trigger match CPU's current privilege level. We
can invoke trigger_common_match() to check the privilege levels of the
type 3 triggers.

Signed-off-by: Alvin Chang <alvinga@andestech.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
---
 target/riscv/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/target/riscv/debug.c b/target/riscv/debug.c
index c290d600..0b5099ff 100644
--- a/target/riscv/debug.c
+++ b/target/riscv/debug.c
@@ -624,7 +624,7 @@  void helper_itrigger_match(CPURISCVState *env)
         if (get_trigger_type(env, i) != TRIGGER_TYPE_INST_CNT) {
             continue;
         }
-        if (check_itrigger_priv(env, i)) {
+        if (!trigger_common_match(env, TRIGGER_TYPE_INST_CNT, i)) {
             continue;
         }
         count = itrigger_get_count(env, i);