| Message ID | 20240702055221.1337035-2-clement.mathieu--drif@eviden.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ATS support for VT-d | expand |
On 2024/7/2 13:52, CLEMENT MATHIEU--DRIF wrote: > From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com> > > The constant must be unsigned, otherwise the two's complement > overrides the other fields when a PASID is present does it need a fix tag since it overrides the other fields? Reviewed-by: Yi Liu <yi.l.liu@intel.com> > Signed-off-by: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com> > --- > hw/i386/intel_iommu_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h > index e8396575eb..b19f14ef63 100644 > --- a/hw/i386/intel_iommu_internal.h > +++ b/hw/i386/intel_iommu_internal.h > @@ -272,7 +272,7 @@ > /* For the low 64-bit of 128-bit */ > #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) > #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) > -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) > +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) > #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) > > /* DMA Remapping Fault Conditions */
On 02/07/2024 15:01, Yi Liu wrote: > Caution: External email. Do not open attachments or click links, > unless this email comes from a known sender and you know the content > is safe. > > > On 2024/7/2 13:52, CLEMENT MATHIEU--DRIF wrote: >> From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com> >> >> The constant must be unsigned, otherwise the two's complement >> overrides the other fields when a PASID is present > > does it need a fix tag since it overrides the other fields? yes, will add the tag > > Reviewed-by: Yi Liu <yi.l.liu@intel.com> > >> Signed-off-by: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com> >> --- >> hw/i386/intel_iommu_internal.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/i386/intel_iommu_internal.h >> b/hw/i386/intel_iommu_internal.h >> index e8396575eb..b19f14ef63 100644 >> --- a/hw/i386/intel_iommu_internal.h >> +++ b/hw/i386/intel_iommu_internal.h >> @@ -272,7 +272,7 @@ >> /* For the low 64-bit of 128-bit */ >> #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) >> #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) >> -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) >> +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) >> #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) >> >> /* DMA Remapping Fault Conditions */ > > -- > Regards, > Yi Liu
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index e8396575eb..b19f14ef63 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -272,7 +272,7 @@ /* For the low 64-bit of 128-bit */ #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) /* DMA Remapping Fault Conditions */