From patchwork Tue Jul 2 05:52:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13718984 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79506C3065C for ; Tue, 2 Jul 2024 05:54:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOWRV-0007u9-Oo; Tue, 02 Jul 2024 01:52:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOWRU-0007tr-Ml for qemu-devel@nongnu.org; Tue, 02 Jul 2024 01:52:40 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOWRS-0006Tu-Jo for qemu-devel@nongnu.org; Tue, 02 Jul 2024 01:52:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1719899559; x=1751435559; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wllwYGVimOAK1sNkbxPQGXJMOd3677JZSN8l+Hwiayc=; b=GbPeYpZEy9aH+fPO+kvZMvWfrKRDvjQ9rRN+QXNUqmJp/RySmS/tHsWK nMaJU4qtXM6yuzHTpQeqmvkw/E/9j5zS8VUJ3fZJzuqCDRfOrL1liOH3R +SJurssY1J1TdJTG29AqbHavBSbFgDqNyMIancwQxMDiSc8TbHaCv1WjN 5MdeK/2x0w862jC1BcBKpnCyZlEWIB36UIB/wR8aqr26YcgSmQK6VCFM+ TCGA1RXtuebgwNYdPWxteUENsC+J7dBwWJ4H7OZ6SD1fjuyjk7yJqljTR ZT+5ZxXM4I7oqNL0IFkQcHSTcWKWdctS1DhDLu4mIwr/tLPd1iEjZPhqv g==; X-IronPort-AV: E=Sophos;i="6.09,178,1716242400"; d="scan'208";a="15721575" X-MGA-submission: MDGH6fPb9mMKieNzRlN5vVTjME4UMR1ZovjHMdqc7t0wafBIxqzXVR1IdxYdraHDQnpllBvzzGNSPD8ahExOnBgiZdbC9x4fnA73p86DgcIyi6F81auoap/bloYpR6IJvkCkfDkycfiTQBwiacG29BJ5nns/MRlw80n0+Y5BMxeODg== Received: from mail-am6eur05lp2110.outbound.protection.outlook.com (HELO EUR05-AM6-obe.outbound.protection.outlook.com) ([104.47.18.110]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 07:52:33 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U5SuRbyDbqmow8rEzMus8qujezFL+qFJRSdOlPfTvmWJkdfK1RtxtzNw2VE0B7qeq8U/7LperbpKVG2b0umBeKVVbG0MIF9BTcaAZhdyowTdtqP/VXatNJmede3tYO7lH32dN+w617oYF/F9Aocf3wcFAYSLzvNNAVfYSGaB3isLai7FIjC3vTVBJgaPSh2ScZlNiurtQQdmv14wZC6kBORohJcROdHB8/U0p1KZlXS3+BPLv7olU5DmsiRD8Z3k65lix3GMRqfmUz2HY3oMp30uNkFyriXHrVbGEVSuYevOByQbi3UwkT9oXNsUPOgxm8VMJP/DIOInNxUAWNqE/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wllwYGVimOAK1sNkbxPQGXJMOd3677JZSN8l+Hwiayc=; b=ShvA1NzpSAzU90D5GyU800Fajk4/rfUe6d9EpTswqLfrmDyEloiwgUUsdSQCcbzioGH52Lptqed2ZE32HzLcTfBhUWSdgdmfbLyxI1Z6x7Sw2IgHdanT3nHton93RJFczCR9B/prOh4iwGXxdYE/+Vd+Ic9f5WCS8qnu9jLGmndZLO6AJR1GxcOnyavZywrJQC3/pAJNO+ijjngopq5iV/TCEWMeB5JOKyV6pmM5QJa97YTP9Q00eTohGXFgcRjIKAvE0zsyFV+5aFEtCd0Xm05A2Sn3Ro3vf3VNB1McNra17tC/cw5T7HKHc7Z7h2pB2dMlMKvKURBj7d9/vQ+DUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wllwYGVimOAK1sNkbxPQGXJMOd3677JZSN8l+Hwiayc=; b=L4VF0TDFip2xnX9M7X7kH8s8uplYNALEiEz6lWYGyBhAs0ptCEJkYmTaRYef0HT3x7BvuwQoY1w7TrGPwwpEUsG/vCIeipVZsQQsJOjrH6P0nEwMu7KtRD0CnLJ1KNwCgC9oFr9J5XlqIcyoeufh8f/A1huVUSoTBE3x55xOeSiC3uG2u4yRmpeHaZuF6URwu3PNDfifTYfAS1b+lqokR+9eGBEJgnGithQmQnyd9wINURlSFruPEJUU97gisqupGXwlmECzqHHyoc0X9onVSwM59FFWrS/jh2m5+yBfd+i3+TbpJgpTtvhgxb5ngOuG9zL6dAKXoU2QbZFW/ON3Uw== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS8PR07MB7080.eurprd07.prod.outlook.com (2603:10a6:20b:239::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.21; Tue, 2 Jul 2024 05:52:31 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7741.017; Tue, 2 Jul 2024 05:52:31 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro. Thread-Topic: [PATCH ats_vtd v5 01/22] intel_iommu: fix FRCD construction macro. Thread-Index: AQHazEQHGsQhBlP7LEGqilns4McPCA== Date: Tue, 2 Jul 2024 05:52:31 +0000 Message-ID: <20240702055221.1337035-2-clement.mathieu--drif@eviden.com> References: <20240702055221.1337035-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240702055221.1337035-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS8PR07MB7080:EE_ x-ms-office365-filtering-correlation-id: 7579553c-357f-405d-dcfd-08dc9a5b29de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?oo2oDTueoDejLKzUTzcpPx+jTb5MY0M?= =?utf-8?q?pXUkxI8CbiAj+63K/C3JK2gBoRGTyqPCnAXqmrcKEyiAry45bXKj0jgTGDkwmcGUM?= =?utf-8?q?2IUTUGrQl5LpNvLtEmR6STQLS693oW0h99PPUA+qb0GY7hUccPb6Ksz+YQtN61SKH?= =?utf-8?q?9mHgl47c28k4OFk21lKpizrbTOH3Q9vny+ZyW4sBWw+0YhNOC5SmB5OQFh6n+ouNf?= =?utf-8?q?InzENRSOkNcMPuVHEblKUy1kFgqozgCvPfurN2ZAINrKHIdTshQ5TDqSPw2r9BEeF?= =?utf-8?q?Sdpe1B30F4XNOKM0d6hftXKeIM7CvbQHlsvk5gelWOTYsjjYsm1xvRAZWAWlsRbYF?= =?utf-8?q?vlZX4u3DSWEAWid5XjNznUhdpa+80igL8T2PcEQoacD620nXy1++lx3ICXN/A2/Go?= =?utf-8?q?YjNrZQ/wx/MZPSGko1ub+wuhDIwYvZngObyTcoo2H3Q4Wf+4W1rF2ShspF7r8uNFh?= =?utf-8?q?2z+9C3RO0ig926+s+Sxfb4d0bFbzVms92RHyWcrgUTa2Cavrk0SN52fIMN6KhkOHY?= =?utf-8?q?YhCxthf+nnqWkvnNdeciIYLYY7Oo+vFCfianb67/WYwv4dbQv+Hb5S2PssjSBlPzV?= =?utf-8?q?KrwNkITBjLntnqJQoL2lXaFMs4uiEYV2aM/Xp5rYWbwCZnf+MWZ2vjKMJmHBsulPK?= =?utf-8?q?I4t/kEvitfZld925bVpGO/rDECHC+iM34fVswE4JLeOGO6GWIMmanuuYlcD35nB9+?= =?utf-8?q?HXpb7zJsj+fR8yiEOO2jrU19tCrDWSVYjsLhDsMDKac/CV7aGP2edCANClan2uFkF?= =?utf-8?q?v+U5vggx5r60pfoVGLvP+blmXSURAi3lm9yA3EdMzIBEnqko5YoCkFrVGTrRTngyn?= =?utf-8?q?cw9NhkInZTCjbHlx3rB6L/7/829LMrG3fyuWcCf/ziAzfGCvWj5DEvAe/AmwXbaDz?= =?utf-8?q?PvNF6q8/UMUaRawRMtu0PdtXfpG0wQGu//Mzu3l5bZiPhtRObUpazOBw2dUK+VbKF?= =?utf-8?q?5Yc1Hqt655bJAS2AWkhdB/Af+xFhRrjQqvXa0bbzjFRm5BymkZ/GW3mz8DotgUKWW?= =?utf-8?q?ovd0BZT+qPhl+uUVht9/sbim1Ucl6yGqHhOv4hcta0H/UZXbhMdqQCFan3wM23peH?= =?utf-8?q?LHydDn1eZP0ZmwVKrjPzt96d3AGpUlHmMIuql8ZQzPRZT0R6Kf+9MQoV/vYf906f6?= =?utf-8?q?c5WVREfGWe5Z4COaKzFJOP4KSNg1+/yeJMNMEFtYaZi6bvoR4cgLDex2d/RPsXRMB?= =?utf-8?q?aO/PtO23tJQPD8rz3qYXAZ5JtjDbgdDT5ov3BUUpo/elmnUNn6yCKFhhYd/xtFVCn?= =?utf-8?q?OPVIbwzC6leaQI55HieY0aIgpTKJtZkvVeVDaRP/LI4Xj95keGZKwYiqo7RXStTDB?= =?utf-8?q?NnLQGw/74SpDI3yplxazPylMXea8w2lThQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?vy6lMgAmA92b1AVdZw4m4Zig+Qzl?= =?utf-8?q?hbqpZadIeePkcaGc+ENhQcX6ti21P0CKC7rJfoazdeG0ApKdl+hxjNX5p1G3ecy8Q?= =?utf-8?q?kplq5to4YMi0V/251rIW5c6Zd7OB2XdEH+vVLaufAoENysqOuIL8HFM2d0eI0Fgep?= =?utf-8?q?+uK+hBeKShLeIIgZbdV7sFYaStEuTXwmJtKI4dhgSHR/XGcBHP/uUJYN/JQp7hSEu?= =?utf-8?q?YcMqZ3YBwdNG0KTfxXg8r2c1625qJ41G0Wz26H2bEgSzrlnFNDLr2AByAhu9tK0vU?= =?utf-8?q?27cpm6I4tYjw7gzKHirpCc7B+lsPncYg7TftcVgbpU+HoNjGPTJxv6Yhnt2bk+im0?= =?utf-8?q?1T6geMFexyfj796hSExJ6icuKtMxvmOyQo55jijUyTjeMrH5g3mA31hC6nTfhFvCy?= =?utf-8?q?fhfD5qgqZ97gl2uNuf2MZff0m+mYsBN6/IfbV4fjOXONg/624SoX97fqmKmbvGPE0?= =?utf-8?q?vRMKFvStZlx3w+sEOH5MtVDuSIuHfEZnK8myyQaMcCG6XgjfcazJS+oHHSrtCbI00?= =?utf-8?q?zpbZvWuesZnCQQqn6E2QJViwq6Lc0oVacD11fHWCAfw3ukmcPgweR0BcbmUfQui3N?= =?utf-8?q?U1kqR3NIiu9BTP4ItHGESfN0SFCcqEqdTrCKdr6W3Tqddj87V7fq8RUv3iHWfD3kB?= =?utf-8?q?lulJGYs2XRwlpNvCyf3/oYfkckXM/tYoicrzanwekXhFREe41gbCDs5QHdC9kXeew?= =?utf-8?q?eNcsdkLpd67DN6Ucp5Nn6VUh2EWjcmH1+KV0gV4CJYnsdDfJ5Dwy9JOwqR0wSEI5k?= =?utf-8?q?3gYIKk9AKUUcD+PckewJA8neuzXZg7tvFFivNw5FvdjYCEhXjwLnMbw0kn17rfNpE?= =?utf-8?q?SyPY32cLpJh9sEMCl3qwuwqSVReomSHRbc2J9S2w1wAyJ72+BoT7XDrqE/oU6Z8gy?= =?utf-8?q?zC6nlJcLeFxMpg1yVHe5A+m8qPLPUDTBuaBEXKY/GJwSBWREEbQWaVR/DNRnScIee?= =?utf-8?q?rbHZDzQqjFR4EAOW/tIauRyjggpwAxVn81Yd5Zb+xvHs7uK8zraVEicQJ89u0kIBH?= =?utf-8?q?jryt0//06jObfzMAuxC/3c0MPvO4d2jCNW/YfRbFGcJgisyOBVcI8fPxdNjaeoJor?= =?utf-8?q?99IV2FW4sHu40Aqx8PkMQW4pVqBAAeAXrY0TMzGTiO8d3j+scUOTr1tCkL8gWj2o8?= =?utf-8?q?GMWQiSbOX7oesE7qZgmoLYnRiT2F/XJosY7ppyjb6lX1BlCuXtxs/LUa5GIjFihsw?= =?utf-8?q?oiA/zC6wF8vQfrm7W97999JvuJWhk8h6g8bFB9xElbM6rpxm+oeHhKIu351OEkCFC?= =?utf-8?q?eF4LtQXhjiAG8H+GateN2pnvy8dufQuqymrBVcF6SWK/0X3z1n3NWenZzv6oycNhj?= =?utf-8?q?x5E/dYiyYyDR7gOesvFbQGx4yIZtRaPPX3ptGdIDHHLaKR2vhYe5sK4WBGSFYtcTm?= =?utf-8?q?zqZ7ygosPyaXu8xudfNjRO4cGFityJqrRaFc7eL7ZF8G2TmA5nQ3FvSyZAQCywF/F?= =?utf-8?q?f3LKkDr2gMFh3RIsvF6OeUT74e8IHQ2H/dO4uUbFib4q9gqp9rQ6zpSNHxTHGLEwd?= =?utf-8?q?ooFQk7PhYwtc6iwQ6TuP/pkgWqzJXO5k7KGBAG/oXMsjoaEYevoyfKw=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7579553c-357f-405d-dcfd-08dc9a5b29de X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2024 05:52:31.4848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MNl8AnIAx7Gj/UX5yrdQ9Jl+wcPIfDBpwftBlHzVOY7F/K8Bs1Gd22uNTBVXxI9gonpw5AzCJIJaaFP7rkkY16AdtuGMGErkMgZBBY60CiOnYUEga7cGcPjpLefoo289 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7080 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Clément Mathieu--Drif The constant must be unsigned, otherwise the two's complement overrides the other fields when a PASID is present Signed-off-by: Clément Mathieu--Drif Reviewed-by: Yi Liu --- hw/i386/intel_iommu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index e8396575eb..b19f14ef63 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -272,7 +272,7 @@ /* For the low 64-bit of 128-bit */ #define VTD_FRCD_FI(val) ((val) & ~0xfffULL) #define VTD_FRCD_PV(val) (((val) & 0xffffULL) << 40) -#define VTD_FRCD_PP(val) (((val) & 0x1) << 31) +#define VTD_FRCD_PP(val) (((val) & 0x1ULL) << 31) #define VTD_FRCD_IR_IDX(val) (((val) & 0xffffULL) << 48) /* DMA Remapping Fault Conditions */