From patchwork Tue Jul 2 05:52:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13718979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9F94C3DA41 for ; Tue, 2 Jul 2024 05:53:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOWRl-00083T-Mf; Tue, 02 Jul 2024 01:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOWRg-00082J-VU for qemu-devel@nongnu.org; Tue, 02 Jul 2024 01:52:53 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOWRf-0006b9-1k for qemu-devel@nongnu.org; Tue, 02 Jul 2024 01:52:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1719899571; x=1751435571; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Muq8pnfZbNY4iEecuK0xCGQ8mJotLYw5kLEyQZ2VRlA=; b=G9RQi1gnyGYNmD8mV8zhUWreTcKGOTUvY38EC4iMmroPfwjx6v/WeB6P j8BLNifpQOvYV4/X2G0tDktoljNTAsoqC2g250WEq4a5MpWlkPkOIF5ja iXcW91HUNigdVqevUrCoJKbG74p3wy41WoO+/1biAjMj5d4JJhvVR0eGu zYUehKjaf4i8WQCK1lz/FtVmZqUYxJIYaTnGZ3G3LcO+XweJj0hHoaQrm /Wm7hfUnicCN/AGxbRBGnd7amyONRVOAOOXeqlCo7pw++pEMyhe1YWBw+ 5e41e04YcFZymTSbyXWfepgBXwv46cj6a9aTmFjETmduhkOmoPljBM4iP g==; X-IronPort-AV: E=Sophos;i="6.09,178,1716242400"; d="scan'208";a="15721604" X-MGA-submission: MDE8uOvL7HiLQCJeWpq41Y52wCRztqtV3QZrEjlrVHxhJFBRtbVcQA21HjRAql0nU9eo2GCJklIJhktVESdqKr5fPTgUdxAouURGTJg+xJq1CRY8Jt6ZrmT6A2cwm2rGq8CAuGT+OWsBuwTBKVGdmGiJvVIE3ZR+j2fwpS7F5w8Ctg== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 07:52:48 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LErkWcOe78z5n1pxJf0m8oVfCiXGDqOeQtut4ntByWVtx9yDaT206KS5Hh1RiIERpC/jBbVHiOm+PB5gDxhblNVekan4mNwu2LEprhIRxQcoFJv2AEczk9VOjsZ0LWyiqf9fTwtIlwLbrRNYgwl1Efwnu3++9+uCYu6nnvZkGsPeVBa+Pby/nsARnwNgY0W7Tp/NktOHwmJ/clc2ThTgWPsIanAA6GwPO/OKYpCYC9JUBCQ1dPlSfDsXKBBTNuiZ+HG06V/7dsiNnEO+e4rFhLvsdgKLvyXhzw90UPa1uOfx5ULwmDiBdqZxCkeMfAdoWuP1LdV0CG/3/5jTeP7AAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Muq8pnfZbNY4iEecuK0xCGQ8mJotLYw5kLEyQZ2VRlA=; b=bORTjWXuOybvyyp2MsUE5MDjobCtfOx6g1Gkn1CS157SHqi7pxRcos5m0+/MB57jRiZCEqD+QkFc21JF/91MIHlb+7VElT84k2hi0XVO2IUpv6EISpU8gCqMnnDYOL49ENzisYfRT9t7dAmo9baAklWHhrFA8PXj1ahBcLj7RJATQQRH9pVYn48VJZDxHZTBFjF6fVpsTJWeRz/MfZGLxexpR1+iWFrNtF9f1/gEIozg5JX4+se33D6dPN5zzp+JJbJSXgzGsPKDJiauT/73D9AI0eRehZn6dpRugMJMw2mRHVD6YeErIlIFUcLkFktyR5y5BnEwNgVXOlAZ8GtMfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Muq8pnfZbNY4iEecuK0xCGQ8mJotLYw5kLEyQZ2VRlA=; b=fNCqRCqmHI9zXgmJeEPZ7+3djtCgbcU571L5/6c1yJt26E4x6z86daTAiS7cUn95kFh9dFu6iE+jocc23o2v+x0CRzF/8C+ze8GWdceeXW1Dyosz6cA0DWyuWhZwer0uf6wCQz/RKS2ibf03N1GutLMNbq6Y/DFWHN1WYwFgu4FSClrkXGZE1YXHsz62oz61PupQqsLhcyjDm5qMDqRUGXjTG8pDQMwaQs9hXa6oJ6vNPhE9We+5U0mnB/ECgBX0AkkOTXVA56d4hwvm7/QQefZwk6cthikJehCyVFtoxV2ryFHBDwrqOnol+KoVfgVB56lIwampmOSQex23FnKNpg== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AM7PR07MB6215.eurprd07.prod.outlook.com (2603:10a6:20b:13d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.21; Tue, 2 Jul 2024 05:52:46 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%4]) with mapi id 15.20.7741.017; Tue, 2 Jul 2024 05:52:46 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v5 21/22] intel_iommu: set the address mask even when a translation fails Thread-Topic: [PATCH ats_vtd v5 21/22] intel_iommu: set the address mask even when a translation fails Thread-Index: AQHazEQQOKgkVaNcZUe4tah2aD0JqQ== Date: Tue, 2 Jul 2024 05:52:46 +0000 Message-ID: <20240702055221.1337035-22-clement.mathieu--drif@eviden.com> References: <20240702055221.1337035-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240702055221.1337035-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AM7PR07MB6215:EE_ x-ms-office365-filtering-correlation-id: 7496a2c4-4d47-443d-8be3-08dc9a5b328a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?fQOta6uTkuMmpvwEvla9m/BzTGtDeP9?= =?utf-8?q?cQgfCel3e1L6pQj6wgBBBFqt2yQRPaLzh/49BctlGAa8wsRq8rs0GtoMLK0Tw2g6s?= =?utf-8?q?D+NbuHzQjxwkRiUMMWr0DiLu4E8jV14RDr0vh7eg91D8NWuMxvLD1uR5mpW2lwX6H?= =?utf-8?q?HRYNLuWEpLQFn4Iz3BVSC6+DHPQoQV6nyP1JObui8iJVllBR/BUJDv+jd5JKQ0iKR?= =?utf-8?q?pwYViGLKcsS79VtV33srKyfueUYir3EGxeoKAfmdO86MTV5JhVPE+No62exMmPgsT?= =?utf-8?q?8VNb50y/9eH0jYViPm2AmkRTZMNbl/1pwmerRhjKu4ZtRNXteS2twLDRIK2ahKHtw?= =?utf-8?q?JSWebjsZ3G7H0/ojfDNjokqI6bgGrqBFc1S9EM7Bz6nKzKGRUCPUQ7o6R7vVs3ZIq?= =?utf-8?q?I6L0QGS9aTPzSZ6pDr7Jz+w2HUGFjgBh3/KK5ApvjzxyaZR1rfTJ5Au67KIY8yRSn?= =?utf-8?q?nv/+FoRl4BUx+vagBAWUVdStGu6v44IA2wvLc2UN9esv6dwsFJs72ICZ2Sa6jqu0Z?= =?utf-8?q?xRAcAULvZgFJlTGdQ9uJ0NsxyJ/WcWy+WhF8FZATiKJ1lH/OtXS/UebwjixubOEXe?= =?utf-8?q?yxlezwJwNJusAwml1kUfy2tj0Et9tz0q6rkTFMyXiQjXWOpYjdvMZQnGRoNONYhU+?= =?utf-8?q?LaOL5Ki/w6AC6cNQdwKZU4ky0ArlL3hiwvhDn4kivjRXE8uklADVKZgU5YmeltVjL?= =?utf-8?q?/kk8H+oZOjlZL5YyIhMXkswiWv9e4uHkGDsVbaTJWmFK4RJhlx7TSOwpLI+0RM2Qq?= =?utf-8?q?r3+WQ0XLATU2hs52DETfN5mVdGY68772bnK6PR+SDhMBd0LcWeczy+k39dQr1JbJc?= =?utf-8?q?o7PWOeNl0+grJCWxSCm5r43zOAvdc5Jq6qzYMGtuWS6cnnPVpohahohnPrvT+dX9N?= =?utf-8?q?l266e3UBwZ0p58GL+DdRpJoZpj3UPqgCCgip3F62lVNof88KDqV1K3TfEeNzSy3E3?= =?utf-8?q?giat5YfAAn2D7aq05HdC1HfQ1ElM2Sx7UpHZ0XED90pa9oAP2M8mW8OwJHZIQYXd9?= =?utf-8?q?q2MSsiOVcjyw6YDvwEYqpJ99rRpcCZ+F9uc8wmeqlIwiBUpOfEuR6Yht7IULhF6Sl?= =?utf-8?q?Hypm56Iw1ifgXFwyDbzX4kBVyVdQdpBvDgY3UciwQsSocOY9eFElmOcPQ12I7eOG6?= =?utf-8?q?gcNW0oUgjxK1r79obt8x4InmiFaTlUBeqOvxUjyD1Tkm/UWvgh7W/+s9gWls+vYOf?= =?utf-8?q?ZzC2pJg78dSQPLeMmPzlGNi6FSXJclJHicvYHhmTZyeNlF/q70mVjMUy8nKMQU1Fr?= =?utf-8?q?p6VFc8kyt2EtVfgLTnitPx8RTjac5IgfuAzNxkkrv9SHRJApDgpA/IucO7u9QxpT+?= =?utf-8?q?aQkbYsisPuz9zkIe7/HIAR88ZXD9kJWh9g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?qEcn+1GAT1CRn3ZSUDTyfvsNdB75?= =?utf-8?q?coS19T2nTMOAj9fb+nRN6B65UFlqLgr0gDL21O1yadDE5NdiX3wfCUl5E7yBEPGNl?= =?utf-8?q?4k7xknLnFlAZF1B1N0A5Mjz+L9YdN2dai30+RhMzkL3GODuYPOL59VgCosZEuIFD6?= =?utf-8?q?ffXt22BPOtpSugYWM4PJmNYrDATSfwHp4uUNX53IxdsJQEtQA0ttmjJFFrw1uJZLF?= =?utf-8?q?t15JYdUWmAe8w26zjDOBhKzKBqKHLXuyGi01379cqQ7nQWgMWfIakg01eUH9d9An1?= =?utf-8?q?aGluncpKHDrpoqDQwiJApp0bimFNZz+xeEMcV89NWAG9pPj4VGbzivNScUVKgs/C7?= =?utf-8?q?7WWDobAjRF0sWYyHagJzp8H1mnjaGy8+laJ5thPW+4ApSCDdfAQq+YtjVOsdHztYA?= =?utf-8?q?lYhTi19cK/vaiEVM3bs344kgv5loz8qM2FL27I66YSA0bz6NSeADVCLfKJag+48iN?= =?utf-8?q?AdMW1ipbird+VCC6iLp8tqw0NLQL2bst5pwoHx22KZi+LaNSx93Y4LByFZhHrhSww?= =?utf-8?q?5h6w6444jr7nsMLrGUc3zlaEXOBIvZL6JIJoNmFa1sZnbuqjEjE/sP2IADnUko9Xi?= =?utf-8?q?dVInh4xtz8KsCupKeeBqW66FvtORiMjxSIJ+IX/mSicq+AeuQW5nH/5Tgp4sPLUf6?= =?utf-8?q?JJafBV76diPS9Vpz4+3VRYsSQqXcSFhSn4AMBWkVpYrfNrUF7ICLN1HIrzpP7VqZ4?= =?utf-8?q?7lkOPXrCk9jt/R7bXcm3kMCUiLu/ihm5woArIkdUgfT8Uq7OLaBg4AkfKdTK8OLP5?= =?utf-8?q?onmnsIdinqHBqM7kCHPbfWFq1Ru/Vpm79eoAscH1JKwkUDud1dx0SkIL1aPT8uhbo?= =?utf-8?q?TWomjp73SJbCWIxO7+Bo3HU1dseIO3YTZrX0O4fmb5MbOjW+2nUV7wD4tcPngCuMC?= =?utf-8?q?0wURWk/MXzjF1CNzDZAL12ICv9NmF5BYAj2hroXhhIQFVtP6racVT+G+NTLcN/ckV?= =?utf-8?q?MsdDySrlnel/rnVKyHFZ5sGXTcHWLpV2pRK3ECc567dajtWUAl8hFRbMKX0122xNo?= =?utf-8?q?MNj52aW2aKZeq0HIloPEXCDeTI+GEzffxaiiBwuLwkdqiYuuOwyPSzZVyOCjyEbN5?= =?utf-8?q?TkT9sdcnekYyDKGR/XWy/rPJMsXFZmhkQG23uNVkvfnWt5rtCDWOMubQyePWP8uI1?= =?utf-8?q?J0SF8ou/iftNTTuzMkcMWl2LZaoNlbn54E8EH0llAc1GQ5i8ZhQKWc85tpiuQCb8e?= =?utf-8?q?/tb7r4cNogOSswfoI7R79GE2uGNqqZl74j7l3dXD+qaR59DtiQ98kUT+xzVTf/ne8?= =?utf-8?q?ZbA6bXcV90Uiu1CNqHCZnWPfYfiAgd5u+pVZ7TczpCPSt19/dHzkDuFteReZfqWdz?= =?utf-8?q?IiMVeRWgZSZBHxJzOf/BAdPyxpL+p/jA++NK1Mg8b1NF6ib1gjYUAyt6JNAvw2kyr?= =?utf-8?q?jvxXEoD4ev0V120IKsIVSfs5uY83kKOJF1wghfO5foIq7wO26Ac0IddzrOoXw/06p?= =?utf-8?q?MRdv0oCLZjOYwRYFTfmAI7bOe/Tp7tDIAkMjxpsx3YCf6XF7+tQcb0X49NhSL9hoU?= =?utf-8?q?O/e7OhDE/2E20lI/EhqXrrAmEqs5ve2jVFE8y8b172k1NYAlNLscOTg=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7496a2c4-4d47-443d-8be3-08dc9a5b328a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2024 05:52:46.0308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eV2lYw/OiW+JutQ2/aTZEIfD/Q5PRVckHSYOugq8hRx+Vz/U5KkQCTPI1UQ4NN/6H4vZur5ePQhordCEU+t4eTlPRBBjDQ/G95y08XCu14eZ87pZ9qj+Orf7bVRb/gDH X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6215 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Clément Mathieu--Drif Implements the behavior defined in section 10.2.3.5 of PCIe spec rev 5. This is needed by devices that support ATS. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index f77972130f..9a1bce9ae2 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2192,7 +2192,8 @@ static bool vtd_do_iommu_translate(VTDAddressSpace *vtd_as, PCIBus *bus, uint8_t bus_num = pci_bus_num(bus); VTDContextCacheEntry *cc_entry; uint64_t pte, page_mask; - uint32_t level, pasid = vtd_as->pasid; + uint32_t level = UINT32_MAX; + uint32_t pasid = vtd_as->pasid; uint16_t source_id = PCI_BUILD_BDF(bus_num, devfn); int ret_fr; bool is_fpd_set = false; @@ -2338,7 +2339,12 @@ error: vtd_iommu_unlock(s); entry->iova = 0; entry->translated_addr = 0; - entry->addr_mask = 0; + /* + * Set the mask for ATS (the range must be present even when the + * translation fails : PCIe rev 5 10.2.3.5) + */ + entry->addr_mask = (level != UINT32_MAX) ? + (~vtd_pt_level_page_mask(level)) : (~VTD_PAGE_MASK_4K); entry->perm = IOMMU_NONE; entry->pasid = PCI_NO_PASID; return false;