| Message ID | 20240715055820.319035-2-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/arm: Fixes for SME FMOPA (#2373) | expand |
On 15/7/24 07:58, Richard Henderson wrote: > From: Daniyal Khan <danikhan632@gmail.com> > > We made a copy above because the fp exception flags > are not propagated back to the FPST register, but > then failed to use the copy. > > Cc: qemu-stable@nongnu.org > Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)") > Signed-off-by: Daniyal Khan <danikhan632@gmail.com> > [rth: Split from a larger patch] > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/tcg/sme_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes: > From: Daniyal Khan <danikhan632@gmail.com> > > We made a copy above because the fp exception flags > are not propagated back to the FPST register, but > then failed to use the copy. > > Cc: qemu-stable@nongnu.org > Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)") > Signed-off-by: Daniyal Khan <danikhan632@gmail.com> > [rth: Split from a larger patch] > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index e2e0575039..5a6dd76489 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn, if (pb & 1) { uint32_t *a = vza_row + H1_4(col); uint32_t *m = vzm + H1_4(col); - *a = float32_muladd(n, *m, *a, 0, vst); + *a = float32_muladd(n, *m, *a, 0, &fpst); } col += 4; pb >>= 4;