| Message ID | 20240718123609.3063055-1-armbru@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qapi-block-core: Clean up blockdev-snapshot-internal-sync doc | expand |
Am 18.07.2024 um 14:36 hat Markus Armbruster geschrieben: > BlockdevSnapshotInternal is the arguments type of command > blockdev-snapshot-internal-sync. Its doc comment contains this note: > > # .. note:: In a transaction, if @name is empty or any snapshot matching > # @name exists, the operation will fail. Only some image formats > # support it; for example, qcow2, and rbd. > > "In a transaction" is misleading, and "if @name is empty or any > snapshot matching @name exists, the operation will fail" is redundant > with the command's Errors documentation. Drop. > > The remainder is fine. Move it to the command's doc comment, where it > is more prominently visible, with a slight rephrasing for clarity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/qapi/block-core.json b/qapi/block-core.json index f400b334c8..994e384a71 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -6046,10 +6046,6 @@ # # @name: the name of the internal snapshot to be created # -# .. note:: In a transaction, if @name is empty or any snapshot matching -# @name exists, the operation will fail. Only some image formats -# support it; for example, qcow2, and rbd. -# # Since: 1.7 ## { 'struct': 'BlockdevSnapshotInternal', @@ -6070,6 +6066,9 @@ # - If the format of the image used does not support it, # GenericError # +# .. note:: Only some image formats such as qcow2 and rbd support +# internal snapshots. +# # Since: 1.7 # # .. qmp-example::
BlockdevSnapshotInternal is the arguments type of command blockdev-snapshot-internal-sync. Its doc comment contains this note: # .. note:: In a transaction, if @name is empty or any snapshot matching # @name exists, the operation will fail. Only some image formats # support it; for example, qcow2, and rbd. "In a transaction" is misleading, and "if @name is empty or any snapshot matching @name exists, the operation will fail" is redundant with the command's Errors documentation. Drop. The remainder is fine. Move it to the command's doc comment, where it is more prominently visible, with a slight rephrasing for clarity. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qapi/block-core.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)