[PULL,2/4] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic

Commit Message

Peter Maydell Aug. 1, 2024, 2:23 p.m. UTC

From: Salil Mehta <[e-mail]>

Loop should exit prematurely on successfully finding out the parked vCPU (struct
KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
parked vCPUs.

Fixes: Coverity CID 1558552
Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
Reported-by: Peter Maydell <[e-mail]>
Signed-off-by: Salil Mehta <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
Reviewed-by: Gavin Shan <[e-mail]>
Reviewed-by: Zhao Liu <[e-mail]>
Reviewed-by: Igor Mammedov <[e-mail]>
Message-id: [e-mail]
Suggested-by: Peter Maydell <[e-mail]>
Message-ID: <[e-mail]>
Signed-off-by: Salil Mehta <[e-mail]>
Signed-off-by: Peter Maydell <[e-mail]>
---
 accel/kvm/kvm-all.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index e1d13863063..75d11a07b2b 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -362,6 +362,7 @@  int kvm_unpark_vcpu(KVMState *s, unsigned long vcpu_id)
             QLIST_REMOVE(cpu, node);
             kvm_fd = cpu->kvm_fd;
             g_free(cpu);
+            break;
         }
     }