diff mbox series

[1/1] target/i386: Fix arguments for vmsr_read_thread_stat()

Message ID 20240807124320.1741124-2-aharivel@redhat.com (mailing list archive)
State New, archived
Headers show
Series Fix energy calcultation in RAPL MSR | expand

Commit Message

Anthony Harivel Aug. 7, 2024, 12:43 p.m. UTC
Snapshot of the stat utime and stime for each thread, taken before and
after the pause, must be stored in separate locations

Signed-off-by: Anthony Harivel <aharivel@redhat.com>
---
 target/i386/kvm/kvm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Zhao Liu Aug. 9, 2024, 10:10 a.m. UTC | #1
On Wed, Aug 07, 2024 at 02:43:20PM +0200, Anthony Harivel wrote:
> Date: Wed,  7 Aug 2024 14:43:20 +0200
> From: Anthony Harivel <aharivel@redhat.com>
> Subject: [PATCH 1/1] target/i386: Fix arguments for vmsr_read_thread_stat()
> 
> Snapshot of the stat utime and stime for each thread, taken before and
> after the pause, must be stored in separate locations
> 
> Signed-off-by: Anthony Harivel <aharivel@redhat.com>
> ---
>  target/i386/kvm/kvm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
diff mbox series

Patch

diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 31f149c9902c..2fa88ef1e373 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -2712,8 +2712,8 @@  static void *kvm_msr_energy_thread(void *data)
             thd_stat[i].thread_id = thread_ids[i];
             vmsr_read_thread_stat(vmsr->pid,
                                   thd_stat[i].thread_id,
-                                  thd_stat[i].utime,
-                                  thd_stat[i].stime,
+                                  &thd_stat[i].utime[0],
+                                  &thd_stat[i].stime[0],
                                   &thd_stat[i].cpu_id);
             thd_stat[i].pkg_id =
                 vmsr_get_physical_package_id(thd_stat[i].cpu_id);
@@ -2777,8 +2777,8 @@  static void *kvm_msr_energy_thread(void *data)
         for (int i = 0; i < num_threads; i++) {
             vmsr_read_thread_stat(vmsr->pid,
                                   thd_stat[i].thread_id,
-                                  thd_stat[i].utime,
-                                  thd_stat[i].stime,
+                                  &thd_stat[i].utime[1],
+                                  &thd_stat[i].stime[1],
                                   &thd_stat[i].cpu_id);
 
             if (vmsr->pid < 0) {