From patchwork Wed Aug 28 04:11:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manos Pitsidianakis X-Patchwork-Id: 13780492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D1D2C5474A for ; Wed, 28 Aug 2024 04:14:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sjA2h-0005Qk-7I; Wed, 28 Aug 2024 00:12:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sjA2g-0005Px-Da for qemu-devel@nongnu.org; Wed, 28 Aug 2024 00:12:22 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sjA2d-0000ld-Rv for qemu-devel@nongnu.org; Wed, 28 Aug 2024 00:12:22 -0400 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5c210e23651so679586a12.3 for ; Tue, 27 Aug 2024 21:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724818338; x=1725423138; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=21QEmzDujIgpkUBwy6KBNuVdg09H8SzoucFGAIhOGAk=; b=ZIKQYxmHgMUabne88e4vlGnl9W5mghbK3usGhLHyBO+sQzGgraWN6FOH2zd366pC6B u9qMgAELqKYtT1tlW1EOIZqgvE9kiw6dVbglyRgTBWt1vVIPa373Jod4nG6Xen61p6fN IDRV+dFcrBJNwPFtyohNht5rLbLGtUSNnOcxuxb0R9ysT272mKX+CieszGBqvV4JFZaX 5AyKQckcqEdfiI+4aHpKY2VjVJyAeOXq5Pit/H4GnbLG2suokfdPjR1Sw8clE3iqc9rO tDG0p9dI7vOWSekqqoGhsK8AZNeFZej48JevWxLHJ3/c4Q4zuFkxGZaIZUMhTPxNvUZ9 VNrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724818338; x=1725423138; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21QEmzDujIgpkUBwy6KBNuVdg09H8SzoucFGAIhOGAk=; b=NnZmMx4dSSidiU8GArUSbH5tQEUQ1ZrHB6xFH88OlvDsMwzcMT3vuo2zqa2Ioe7MpR e6FfB0m5jKY69BPty4cI3qOdK4uJBZ06FnP1hy5xDBRBgQvmpgLErJG383jcwLhTUsFC 84txqhLSIZ8/jvx0ezJzdjDR3ptTQXOKLUfKgaGjS3IaOeQoXjD9iryGKRCeSEkPHJLX 5s5HIT9oSSM1Cmr9pXsEiMaUeQO7vHAVbC62vibetwpyp8+xtVzf2VttFttSTV2AjMdV gNsRHgNqo0sqVDwxReaeigeidm7d+3tq+EbM2llzx5J9JRsROTO80ra0rbaPeFaFZko+ lPLQ== X-Gm-Message-State: AOJu0YwskzSyXM1aAcvg86neFPcKlSYR3N0W/eYZfV+dKBWgcZv3M9Bm 99Rx/NnQPFt25mJT6qXnmBge6LU6s4INggAuejccmKD5ojyVn+cwWmIrDxr9Q+0= X-Google-Smtp-Source: AGHT+IH9KE1oN1ihGD9nOTi3dVn+vAk+brW/aIeBd1kD8yPAYNLaAzQNNPObQ2CPic2OSUiet0PiZw== X-Received: by 2002:a05:6402:2546:b0:5be:eb19:ee56 with SMTP id 4fb4d7f45d1cf-5c214c597c2mr471528a12.24.1724818337807; Tue, 27 Aug 2024 21:12:17 -0700 (PDT) Received: from [127.0.1.1] (adsl-98.109.242.227.tellas.gr. [109.242.227.98]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0bb1c29b9sm1712814a12.18.2024.08.27.21.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 21:12:17 -0700 (PDT) From: Manos Pitsidianakis Date: Wed, 28 Aug 2024 07:11:44 +0300 Subject: [PATCH RESEND v9 3/9] configure, meson: detect Rust toolchain MIME-Version: 1.0 Message-Id: <20240828-rust-pl011-v9-3-35579191f17c@linaro.org> References: <20240828-rust-pl011-v9-0-35579191f17c@linaro.org> In-Reply-To: <20240828-rust-pl011-v9-0-35579191f17c@linaro.org> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Richard Henderson , Gustavo Romero , =?utf-8?q?Alex_Benn=C3=A9e?= , Peter Maydell , Junjie Mao , Zhao Liu , Manos Pitsidianakis X-Mailer: b4 0.15-dev-c2c95 X-Developer-Signature: v=1; a=openpgp-sha256; l=6904; i=manos.pitsidianakis@linaro.org; h=from:subject:message-id; bh=qISo7oo0rfeUGD0BnZly+vsOKnxOKDn62ksH0VVpgRc=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0VCYlFLUy9aQU5Bd0FLQVhjcHgzQi9mZ 25RQWNzbVlnQm16cU9MUy9ObUxaYjViQm9UaUhHY0hxNVFTU0xUCnhNNndHQ0ttL25oSnJvd0g5 WWlKQWpNRUFBRUtBQjBXSVFUTVhCdE9SS0JXODRkd0hSQjNLY2R3ZjM0SjBBVUMKWnM2aml3QUt DUkIzS2Nkd2YzNEowTnp3RC85Z0RFYjN5SVdKNmtaZFRMK3ZNMFJaUWJ1OHNyOWU0cXZnMzFoVA orSHZ5YTMzSXViajNiU3NrRGhjb0FNS2M1dGhDR21vWE1PVEtQWWg3b2U2cXBtMHRrWUV5aWtrZ k1LNGY5R0c1CnlmRnNYM2ZGbjFub1V1WnM0aVVYM3dGalpJckNzcEtWMlJIYU5sZnduUUZKUTJ1 aHU1UVFBRFVkKys4Nkt6bnIKYXYvYVRTNVVVY2Y4T0pKVENaSE0venNQbE8xSFliVjVMS1Ivblh 0U2pxUlFIK3EyVFV6N2UrMGhvd1ArLzFrawpGcnMwcDczVzhjcllCMXNXSmxaSGUvc29BWE5rUE xDTHNuRmhIa1JnNFl0OTYvcjk5WDNuNDZ3U25kSmhROFVjCmliN2l3TlBoK1N4aXRkb3Rod012Z TZpLy9pUC8ydFMrUDdNYy94UkRZRHBEWDYrZlVlZkVqamg3MHpWUENBS0YKUWZtdUxLaS80MTFm dE1FR1ZTY1U0NnBwZGVoYUk4OTFXaTBMcUc0RHREU3BtR2lBRWtKOFZFZ09KaHoyT1pGSQp1WG5 MaXptb2Fjc1hOVGhMTTZWME5qTEpxMDlPeWJDNlJ1SzA4TnRjU0VXVEdqYTA4WVRaaTdPZkNLRE J4QmFpCjhsYVR5bkVPNEU5SXlmQW95V045QXhnNlZwdXVaaWVHajhzcVVyZzVQd2c4K1RNUTNLN UphWDIya0JEVGlXaFoKb2dZN1hVMjNLanZuNWdMcjV1UisyWHpudFhEY2lTelNPRDFaNXRlUVdO aW9lTDNIMHBReVJSYzVGM0RqVUhxYwpwaDJsdDhiYnE0ampwa3FYeVR5dktudlBWVmZ1N1hTWjF MaUtPYkhVaUVJcUFyYnpqWktWekhJbmptYlhXTUQzCng4N0k1UT09Cj16ano2Ci0tLS0tRU5EIF BHUCBNRVNTQUdFLS0tLS0K X-Developer-Key: i=manos.pitsidianakis@linaro.org; a=openpgp; fpr=7C721DF9DB3CC7182311C0BF68BC211D47B421E1 Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Paolo Bonzini Include the correct path and arguments to rustc in the native and cross files (native compilation is needed for procedural macros). Signed-off-by: Paolo Bonzini --- configure | 50 ++++++++++++++++++++++++++++++++++++++++++++++++-- meson.build | 8 +++----- 2 files changed, 51 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 019fcbd0ef7b07e7b0280b358099cae72c73aa98..9ef6005c557fc627c7c6c732b4c92ed1b934f474 100755 --- a/configure +++ b/configure @@ -207,6 +207,8 @@ for opt do ;; --objcc=*) objcc="$optarg" ;; + --rustc=*) RUSTC="$optarg" + ;; --cpu=*) cpu="$optarg" ;; --extra-cflags=*) @@ -252,6 +254,9 @@ python= download="enabled" skip_meson=no use_containers="yes" +# do not enable by default because cross compilation requires --rust-target-triple +rust="disabled" +rust_target_triple="" gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb") gdb_arches="" @@ -317,6 +322,8 @@ windmc="${WINDMC-${cross_prefix}windmc}" pkg_config="${PKG_CONFIG-${cross_prefix}pkg-config}" sdl2_config="${SDL2_CONFIG-${cross_prefix}sdl2-config}" +rustc="${RUSTC-rustc}" + check_define() { cat > $TMPC < "${TMPDIR1}/${TMPB}.out"; then + rust_host_triple=$(sed -n 's/^host: //p' "${TMPDIR1}/${TMPB}.out") +else + if test "$rust" = enabled; then + error_exit "could not execute rustc binary \"$rustc\"" + fi + rust=disabled +fi +if test "$rust" != disabled && test -z "$rust_target_triple"; then + rust_target_triple=$rust_host_triple +fi + +########################################## # functions to probe cross compilers container="no" @@ -1604,6 +1636,9 @@ if test "$container" != no; then echo "RUNC=$runc" >> $config_host_mak fi echo "SUBDIRS=$subdirs" >> $config_host_mak +if test "$rust" != disabled; then + echo "RUST_TARGET_TRIPLE=$rust_target_triple" >> $config_host_mak +fi echo "PYTHON=$python" >> $config_host_mak echo "MKVENV_ENSUREGROUP=$mkvenv ensuregroup $mkvenv_online_flag" >> $config_host_mak echo "GENISOIMAGE=$genisoimage" >> $config_host_mak @@ -1735,6 +1770,13 @@ if test "$skip_meson" = no; then echo "c = [$(meson_quote $cc $CPU_CFLAGS)]" >> $cross test -n "$cxx" && echo "cpp = [$(meson_quote $cxx $CPU_CFLAGS)]" >> $cross test -n "$objcc" && echo "objc = [$(meson_quote $objcc $CPU_CFLAGS)]" >> $cross + if test "$rust" != disabled; then + if test "$rust_host_triple" != "$rust_target_triple"; then + echo "rust = [$(meson_quote $rustc --target "$rust_target_triple")]" >> $cross + else + echo "rust = [$(meson_quote $rustc)]" >> $cross + fi + fi echo "ar = [$(meson_quote $ar)]" >> $cross echo "dlltool = [$(meson_quote $dlltool)]" >> $cross echo "nm = [$(meson_quote $nm)]" >> $cross @@ -1770,6 +1812,9 @@ if test "$skip_meson" = no; then echo "# Automatically generated by configure - do not modify" > $native echo "[binaries]" >> $native echo "c = [$(meson_quote $host_cc)]" >> $native + if test "$rust" != disabled; then + echo "rust = [$(meson_quote $rustc)]" >> $cross + fi mv $native config-meson.native meson_option_add --native-file meson_option_add config-meson.native @@ -1788,6 +1833,7 @@ if test "$skip_meson" = no; then test "$pie" = no && meson_option_add -Db_pie=false # QEMU options + test "$rust" != "auto" && meson_option_add "-Drust=$rust" test "$cfi" != false && meson_option_add "-Dcfi=$cfi" "-Db_lto=$cfi" test "$docs" != auto && meson_option_add "-Ddocs=$docs" test -n "${LIB_FUZZING_ENGINE+xxx}" && meson_option_add "-Dfuzzing_engine=$LIB_FUZZING_ENGINE" diff --git a/meson.build b/meson.build index 67eb4eda649d5f0566de2b75466b5a9d9ca87ab4..065739ccb7300f4f0d487602485802f9f68fb095 100644 --- a/meson.build +++ b/meson.build @@ -70,9 +70,6 @@ if host_os == 'darwin' and \ all_languages += ['objc'] objc = meson.get_compiler('objc') endif -if get_option('rust').enabled() and meson.version().version_compare('<1.0.0') - error('Rust support requires Meson version >=1.0.0') -endif have_rust = false if not get_option('rust').disabled() and add_languages('rust', required: get_option('rust'), native: false) rustc = meson.get_compiler('rust') @@ -4307,8 +4304,9 @@ else endif summary_info += {'Rust support': have_rust} if have_rust - summary_info += {'rustc version': rustc.version()} - summary_info += {'rustc': ' '.join(rustc.cmd_array())} + summary_info += {'rustc version': rustc.version()} + summary_info += {'rustc': ' '.join(rustc.cmd_array())} + summary_info += {'Rust target': config_host['RUST_TARGET_TRIPLE']} endif option_cflags = (get_option('debug') ? ['-g'] : []) if get_option('optimization') != 'plain'