| Message ID | 20240910221606.1817478-14-pierrick.bouvier@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Use g_assert_not_reached instead of (g_)assert(0, false) | expand |
On 9/10/24 15:15, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > tests/unit/test-xs-node.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c > index ac94e7ed6c2..2f447a73fb8 100644 > --- a/tests/unit/test-xs-node.c > +++ b/tests/unit/test-xs-node.c > @@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque) > printf("Comparison failure in TX %u after serdes:\n", tx_id); > dump_ref("Original", t1->root, 0); > dump_ref("Deserialised", t2->root, 0); > - g_assert(0); > + g_assert_not_reached(); > } > g_assert(t1->nr_nodes == t2->nr_nodes); > } > @@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s) > printf("Comparison failure in main tree after serdes:\n"); > dump_ref("Original", s->root, 0); > dump_ref("Deserialised", s2->root, 0); > - g_assert(0); > + g_assert_not_reached(); > } > > nr_transactions1 = g_hash_table_size(s->transactions); Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/tests/unit/test-xs-node.c b/tests/unit/test-xs-node.c index ac94e7ed6c2..2f447a73fb8 100644 --- a/tests/unit/test-xs-node.c +++ b/tests/unit/test-xs-node.c @@ -212,7 +212,7 @@ static void compare_tx(gpointer key, gpointer val, gpointer opaque) printf("Comparison failure in TX %u after serdes:\n", tx_id); dump_ref("Original", t1->root, 0); dump_ref("Deserialised", t2->root, 0); - g_assert(0); + g_assert_not_reached(); } g_assert(t1->nr_nodes == t2->nr_nodes); } @@ -257,7 +257,7 @@ static void check_serdes(XenstoreImplState *s) printf("Comparison failure in main tree after serdes:\n"); dump_ref("Original", s->root, 0); dump_ref("Deserialised", s2->root, 0); - g_assert(0); + g_assert_not_reached(); } nr_transactions1 = g_hash_table_size(s->transactions);
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)