From patchwork Tue Sep 24 13:02:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 13810933 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14D55CF9C6F for ; Tue, 24 Sep 2024 13:04:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st5DM-00025A-MQ; Tue, 24 Sep 2024 09:04:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st5D7-0001lR-7k for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:04:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st5D5-0008Vw-Lr for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:04:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727183046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JGOe2Dnp1wJG1ukQSWN3HzZdCz5Em4HGNnPdjOs5MqI=; b=SK5B83VdyOhxGMsI0viJWaXqV5IZcCS3Wm8JLr3CCzekSXyweW0LK/ryWcxkBT7I+S5dB2 9PcYQGMd8OJU9kbbDEG4v5jW5/pbOzkwQGp595Au7IVyg0wcALJx8pDZ92kfPHcpcXDIFY RviKkM0fLegbLBg5beGC5kOPMKKdc0M= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-Q6vxtyK9O7G3a6RQbWFTIw-1; Tue, 24 Sep 2024 09:02:58 -0400 X-MC-Unique: Q6vxtyK9O7G3a6RQbWFTIw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 89AB718E6D55; Tue, 24 Sep 2024 13:02:55 +0000 (UTC) Received: from localhost (unknown [10.39.208.3]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 58D6B1956094; Tue, 24 Sep 2024 13:02:50 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Vladimir Sementsov-Ogievskiy , Hanna Reitz , Greg Kurz , Paolo Bonzini , Klaus Jensen , Stefano Garzarella , Alexandre Iooss , Eric Blake , John Snow , Pierrick Bouvier , =?utf-8?q?Alex_Benn=C3=A9e?= , Fam Zheng , "Michael S. Tsirkin" , Keith Busch , Hyman Huang , Laurent Vivier , Fabiano Rosas , Christian Schoenebeck , Stefan Hajnoczi , Mahmoud Mandour , Jesper Devantier , Peter Xu , Gerd Hoffmann , Bin Meng , Song Gao , =?utf-8?q?Da?= =?utf-8?q?niel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Eugeni?= =?utf-8?q?o_P=C3=A9rez?= , Yuval Shaia , Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, Bin Meng , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Subject: [PATCH v2 04/22] nbd: fix -Werror=maybe-uninitialized false-positive Date: Tue, 24 Sep 2024 17:02:03 +0400 Message-ID: <20240924130222.748369-5-marcandre.lureau@redhat.com> In-Reply-To: <20240924130222.748369-1-marcandre.lureau@redhat.com> References: <20240924130222.748369-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.09, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Marc-André Lureau ../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized [-Werror=maybe-uninitialized] Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- nbd/client-connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/client-connection.c b/nbd/client-connection.c index f9da67c87e..b11e266807 100644 --- a/nbd/client-connection.c +++ b/nbd/client-connection.c @@ -410,7 +410,7 @@ nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info, */ void nbd_co_establish_connection_cancel(NBDClientConnection *conn) { - Coroutine *wait_co; + Coroutine *wait_co = NULL; WITH_QEMU_LOCK_GUARD(&conn->mutex) { wait_co = g_steal_pointer(&conn->wait_co);