| Message ID | 20241005205748.29203-5-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Consolidate lan9118 phy implementations | expand |
On Sat, 5 Oct 2024 at 21:58, Bernhard Beschow <shentey@gmail.com> wrote: > > The real device advertises this mode and the device model already advertises > 100 mbps half duplex and 10 mbps full+half duplex. So advertise this mode to > make the model more realistic. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > hw/net/lan9118_phy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/lan9118_phy.c b/hw/net/lan9118_phy.c > index 1c2f30c81a..4815a4da35 100644 > --- a/hw/net/lan9118_phy.c > +++ b/hw/net/lan9118_phy.c > @@ -145,8 +145,8 @@ void lan9118_phy_write(Lan9118PhyState *s, int reg, uint32_t val) > break; > case MII_ANAR: > s->advertise = (val & (MII_ANAR_RFAULT | MII_ANAR_PAUSE_ASYM | > - MII_ANAR_PAUSE | MII_ANAR_10FD | MII_ANAR_10 | > - MII_ANAR_SELECT)) > + MII_ANAR_PAUSE | MII_ANAR_TXFD | MII_ANAR_10FD | > + MII_ANAR_10 | MII_ANAR_SELECT)) > | MII_ANAR_TX; > break; Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/hw/net/lan9118_phy.c b/hw/net/lan9118_phy.c index 1c2f30c81a..4815a4da35 100644 --- a/hw/net/lan9118_phy.c +++ b/hw/net/lan9118_phy.c @@ -145,8 +145,8 @@ void lan9118_phy_write(Lan9118PhyState *s, int reg, uint32_t val) break; case MII_ANAR: s->advertise = (val & (MII_ANAR_RFAULT | MII_ANAR_PAUSE_ASYM | - MII_ANAR_PAUSE | MII_ANAR_10FD | MII_ANAR_10 | - MII_ANAR_SELECT)) + MII_ANAR_PAUSE | MII_ANAR_TXFD | MII_ANAR_10FD | + MII_ANAR_10 | MII_ANAR_SELECT)) | MII_ANAR_TX; break; case 30: /* Interrupt mask */
The real device advertises this mode and the device model already advertises 100 mbps half duplex and 10 mbps full+half duplex. So advertise this mode to make the model more realistic. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- hw/net/lan9118_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)