[PULL,1/8] chardev/char: fix qemu_chr_is_busy() check

Commit Message

Marc-André Lureau Oct. 15, 2024, 8:51 a.m. UTC

From: Roman Penyaev <[e-mail]>

`mux_cnt` struct member never goes negative or decrements,
so mux chardev can be !busy only when there are no
frontends attached. This patch fixes the always-true
check.

Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend")
Signed-off-by: Roman Penyaev <[e-mail]>
Cc: "Marc-André Lureau" <[e-mail]>
Cc: [e-mail]
Reviewed-by: Marc-André Lureau <[e-mail]>
Message-ID: <[e-mail]>
---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/chardev/char.c b/chardev/char.c
index c0cc52824b..f54dc3a862 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -333,7 +333,7 @@  static bool qemu_chr_is_busy(Chardev *s)
 {
     if (CHARDEV_IS_MUX(s)) {
         MuxChardev *d = MUX_CHARDEV(s);
-        return d->mux_cnt >= 0;
+        return d->mux_cnt > 0;
     } else {
         return s->be != NULL;
     }