| Message ID | 20241016212407.139390-2-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Consolidate lan9118 phy implementations | expand |
On Wed, 16 Oct 2024 at 22:24, Bernhard Beschow <shentey@gmail.com> wrote: > > This is a preparation for the next patch. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > include/hw/resettable.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/hw/resettable.h b/include/hw/resettable.h > index fd862f1e9f..0f25beaf21 100644 > --- a/include/hw/resettable.h > +++ b/include/hw/resettable.h > @@ -40,6 +40,7 @@ typedef enum ResetType { > RESET_TYPE_WAKEUP, > RESET_TYPE_S390_CPU_INITIAL, > RESET_TYPE_S390_CPU_NORMAL, > + RESET_TYPE_SOFT, > } ResetType; We have in general been avoiding defining a "soft" reset because it's not clear what the meaning of it should be or how it applies across devices. If we want to define a new ResetType then we need to start with the documentation which says clearly what the semantics of it should be and when it will be triggered. You might prefer to avoid entangling that with this lan9118 refactoring. thanks -- PMM
diff --git a/include/hw/resettable.h b/include/hw/resettable.h index fd862f1e9f..0f25beaf21 100644 --- a/include/hw/resettable.h +++ b/include/hw/resettable.h @@ -40,6 +40,7 @@ typedef enum ResetType { RESET_TYPE_WAKEUP, RESET_TYPE_S390_CPU_INITIAL, RESET_TYPE_S390_CPU_NORMAL, + RESET_TYPE_SOFT, } ResetType; /*
This is a preparation for the next patch. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- include/hw/resettable.h | 1 + 1 file changed, 1 insertion(+)