[2/8] gdbstub: Try unlinking the unix socket before binding

Commit Message

Ilya Leoshkevich Oct. 24, 2024, 7:59 p.m. UTC

In case an emulated process execve()s another emulated process, bind()
will fail, because the socket already exists. So try deleting it.

Note that it is not possible to handle this in do_execv(): deleting
gdbserver_user_state.socket_path before safe_execve() is not correct,
because the latter may fail, and afterwards we may lose control.

Signed-off-by: Ilya Leoshkevich <[e-mail]>
---
 gdbstub/user.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/gdbstub/user.c b/gdbstub/user.c
index cdf5affae15..26b25b1b7e9 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -337,6 +337,7 @@  static int gdbserver_open_socket(const char *path)
 
     sockaddr.sun_family = AF_UNIX;
     pstrcpy(sockaddr.sun_path, sizeof(sockaddr.sun_path) - 1, path);
+    unlink(sockaddr.sun_path);
     ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
     if (ret < 0) {
         perror("bind socket");