[PULL,2/3] vfio/igd: fix calculation of graphics stolen memory

Commit Message

Cédric Le Goater Nov. 18, 2024, 8:37 a.m. UTC

From: Corvin Köhne <[e-mail]>

When copying the calculation of the stolen memory size for Intels integrated
graphics device of gen 9 and later from the Linux kernel [1], we missed
subtracting 0xf0 from the graphics mode select value for values above 0xf0.
This leads to QEMU reporting a very large size of the graphics stolen memory
area. That's just a waste of memory. Additionally the guest firmware might be
unable to allocate such a large buffer.

[1] https://github.com/torvalds/linux/blob/7c626ce4bae1ac14f60076d00eafe71af30450ba/arch/x86/kernel/early-quirks.c#L455-L460

Signed-off-by: Corvin Köhne <[e-mail]>
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
Fixes: 871922416683 ("vfio/igd: correctly calculate stolen memory size for gen 9 and later")
Reviewed-by: Alex Williamson <[e-mail]>
[ clg: Changed commit subject ]
Signed-off-by: Cédric Le Goater <[e-mail]>
---
 hw/vfio/igd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index c5282827ec9112be3c53fbef953abed0bac64298..4047f4f0717f82f48f8e255873f9895a157e210a 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -501,7 +501,7 @@  static int igd_get_stolen_mb(int gen, uint32_t gmch)
         if (gms < 0xf0)
             return gms * 32;
         else
-            return gms * 4 + 4;
+            return (gms - 0xf0) * 4 + 4;
     }
 }