[RFC,v1,20/43] helper-to-tcg: Introduce pseudo instructions

Message ID	20241121014947.18666-21-anjo@rev.ng (mailing list archive)
State	New
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com, richard.henderson@linaro.org, philmd@linaro.org, alex.bennee@linaro.org Subject: [RFC PATCH v1 20/43] helper-to-tcg: Introduce pseudo instructions Date: Thu, 21 Nov 2024 02:49:24 +0100 Message-ID: <20241121014947.18666-21-anjo@rev.ng> In-Reply-To: <20241121014947.18666-1-anjo@rev.ng> References: <20241121014947.18666-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=94.130.142.21; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Reply-to: Anton Johansson <anjo@rev.ng> From: Anton Johansson via <qemu-devel@nongnu.org> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	Introduce helper-to-tcg \| expand [RFC,v1,00/43] Introduce helper-to-tcg [RFC,v1,01/43] Add option to enable/disable helper-to-tcg [RFC,v1,02/43] accel/tcg: Add bitreverse and funnel-shift runtime helper functions [RFC,v1,03/43] accel/tcg: Add gvec size changing operations [RFC,v1,04/43] tcg: Add gvec functions for creating consant vectors [RFC,v1,05/43] tcg: Add helper function dispatcher and hook tcg_gen_callN [RFC,v1,06/43] tcg: Introduce tcg-global-mappings [RFC,v1,07/43] tcg: Increase maximum TB size and maximum temporaries [RFC,v1,08/43] include/helper-to-tcg: Introduce annotate.h [RFC,v1,09/43] helper-to-tcg: Introduce get-llvm-ir.py [RFC,v1,10/43] helper-to-tcg: Add meson.build [RFC,v1,11/43] helper-to-tcg: Introduce llvm-compat [RFC,v1,12/43] helper-to-tcg: Introduce custom LLVM pipeline [RFC,v1,13/43] helper-to-tcg: Introduce Error.h [RFC,v1,14/43] helper-to-tcg: Introduce PrepareForOptPass [RFC,v1,15/43] helper-to-tcg: PrepareForOptPass, map annotations [RFC,v1,16/43] helper-to-tcg: PrepareForOptPass, Cull unused functions [RFC,v1,17/43] helper-to-tcg: PrepareForOptPass, undef llvm.returnaddress [RFC,v1,18/43] helper-to-tcg: PrepareForOptPass, Remove noinline attribute [RFC,v1,19/43] helper-to-tcg: Pipeline, run optimization pass [RFC,v1,20/43] helper-to-tcg: Introduce pseudo instructions [RFC,v1,21/43] helper-to-tcg: Introduce PrepareForTcgPass [RFC,v1,22/43] helper-to-tcg: PrepareForTcgPass, remove functions w. cycles [RFC,v1,23/43] helper-to-tcg: PrepareForTcgPass, demote phi nodes [RFC,v1,24/43] helper-to-tcg: PrepareForTcgPass, map TCG globals [RFC,v1,25/43] helper-to-tcg: PrepareForTcgPass, transform GEPs [RFC,v1,26/43] helper-to-tcg: PrepareForTcgPass, canonicalize IR [RFC,v1,27/43] helper-to-tcg: PrepareForTcgPass, identity map trivial expressions [RFC,v1,28/43] helper-to-tcg: Introduce TcgType.h [RFC,v1,29/43] helper-to-tcg: Introduce TCG register allocation [RFC,v1,30/43] helper-to-tcg: TcgGenPass, introduce TcgEmit.[cpp\|h] [RFC,v1,31/43] helper-to-tcg: Introduce TcgGenPass [RFC,v1,32/43] helper-to-tcg: Add README [RFC,v1,33/43] helper-to-tcg: Add end-to-end tests [RFC,v1,34/43] target/hexagon: Add get_tb_mmu_index() [RFC,v1,35/43] target/hexagon: Use argparse in all python scripts [RFC,v1,36/43] target/hexagon: Add temporary vector storage [RFC,v1,37/43] target/hexagon: Make HVX vector args. restrict * [RFC,v1,38/43] target/hexagon: Use cpu_mapping to map env -> TCG [RFC,v1,39/43] target/hexagon: Keep gen_slotval/check_noshuf for helper-to-tcg [RFC,v1,40/43] target/hexagon: Emit annotations for helpers [RFC,v1,41/43] target/hexagon: Manually call generated HVX instructions [RFC,v1,42/43] target/hexagon: Only translate w. idef-parser if helper-to-tcg failed [RFC,v1,43/43] target/hexagon: Use helper-to-tcg

diff --git a/subprojects/helper-to-tcg/meson.build b/subprojects/helper-to-tcg/meson.build index fd3fd6f0ae..6aba71d5ca 100644 --- a/subprojects/helper-to-tcg/meson.build +++ b/subprojects/helper-to-tcg/meson.build @@ -45,6 +45,7 @@ sources = [ 'passes/llvm-compat.cpp', 'pipeline/Pipeline.cpp', 'passes/PrepareForOptPass/PrepareForOptPass.cpp', + 'passes/PseudoInst.cpp', ] clang = bindir / 'clang' diff --git a/subprojects/helper-to-tcg/passes/PseudoInst.cpp b/subprojects/helper-to-tcg/passes/PseudoInst.cpp new file mode 100644 index 0000000000..d7efa11499 --- /dev/null +++ b/subprojects/helper-to-tcg/passes/PseudoInst.cpp @@ -0,0 +1,142 @@ +// +// Copyright(c) 2024 rev.ng Labs Srl. All Rights Reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, see <http://www.gnu.org/licenses/>. +// + +#include "PseudoInst.h" +#include "llvm-compat.h" + +#include <llvm/ADT/DenseMap.h> +#include <llvm/ADT/Twine.h> +#include <llvm/IR/Function.h> +#include <llvm/IR/Instructions.h> +#include <llvm/Support/Casting.h> + +using namespace llvm; + +#define PSEUDO_INST_DEF(name, ret, args) #name +static const char *PseudoInstName[] = { +#include "PseudoInst.inc" +}; +#undef PSEUDO_INST_DEF + +#define PSEUDO_INST_ARGVEC(...) \ + (sizeof((PseudoInstArg[]){__VA_ARGS__}) / sizeof(PseudoInstArg)) + +#define PSEUDO_INST_DEF(name, ret, args) args +static uint8_t PseudoInstArgCount[] = { +#include "PseudoInst.inc" +}; +#undef PSEUDO_INST_DEF + +// In order to map from a Function * to a PseudoInst, we keep a map +// of all Functions created, this simplifies mapping of callee's to +// a PseudoInst that can be switched over. +static DenseMap<Function *, PseudoInst> MapFuncToInst; + +// Converts llvm `Type`s to a string representation +// that can be embedded in function names for basic overloading. +// +// Ex. +// +// *i32 -> "pi32" +// [8 x i8] -> "a8xi8" +// <128 x i8> -> "v128xi8" +// +// LLVM has an implementation of a similar function used by intrinsics, +// called getMangledTypeStr, but it's not exposed. +inline std::string getMangledTypeStr(Type *Ty) +{ + std::string TypeStr = ""; + llvm::raw_string_ostream TypeStream(TypeStr); + switch (Ty->getTypeID()) { + case Type::ArrayTyID: { + auto *ArrayTy = cast<ArrayType>(Ty); + std::string ElementStr = getMangledTypeStr(ArrayTy->getElementType()); + TypeStream << "a" << ArrayTy->getNumElements() << "x" << ElementStr; + } break; +#if LLVM_VERSION_MAJOR >= 11 + case Type::FixedVectorTyID: { +#else + case Type::VectorTyID: { +#endif + auto *VecTy = cast<VectorType>(Ty); + uint32_t ElementCount = compat::getVectorElementCount(VecTy); + std::string ElementStr = getMangledTypeStr(VecTy->getElementType()); + TypeStream << "v" << ElementCount << "x" << ElementStr; + } break; + case Type::StructTyID: { + auto *StructTy = cast<StructType>(Ty); + TypeStream << StructTy->getName(); + } break; + case Type::IntegerTyID: { + auto *IntTy = cast<IntegerType>(Ty); + TypeStream << "i" << IntTy->getBitWidth(); + } break; + case Type::PointerTyID: { + auto *PtrTy = cast<PointerType>(Ty); + std::string ElementStr = + getMangledTypeStr(PtrTy->getPointerElementType()); + TypeStream << "p" << ElementStr; + } break; + default: + abort(); + } + + return TypeStream.str(); +} + +const char *pseudoInstName(PseudoInst Inst) { return PseudoInstName[Inst]; } + +uint8_t pseudoInstArgCount(PseudoInst Inst) { return PseudoInstArgCount[Inst]; } + +llvm::FunctionCallee pseudoInstFunction(llvm::Module &M, PseudoInst Inst, + llvm::Type *RetType, + llvm::ArrayRef<llvm::Type *> ArgTypes) +{ + auto *FT = llvm::FunctionType::get(RetType, ArgTypes, false); + + std::string FnName{PseudoInstName[Inst]}; + if (!RetType->isVoidTy()) { + FnName += "."; + FnName += getMangledTypeStr(RetType); + } + for (llvm::Type *Ty : ArgTypes) { + if (Ty->isLabelTy()) { + continue; + } + FnName += "."; + FnName += getMangledTypeStr(Ty); + } + + llvm::FunctionCallee Fn = M.getOrInsertFunction(FnName, FT); + auto *F = cast<Function>(Fn.getCallee()); + MapFuncToInst.insert({F, Inst}); + + return Fn; +} + +// Takes value as convenience +PseudoInst getPseudoInstFromCall(const CallInst *Call) +{ + Function *F = Call->getCalledFunction(); + + auto It = MapFuncToInst.find(F); + if (It == MapFuncToInst.end()) { + return InvalidPseudoInst; + } + + return It->second; +} diff --git a/subprojects/helper-to-tcg/passes/PseudoInst.h b/subprojects/helper-to-tcg/passes/PseudoInst.h new file mode 100644 index 0000000000..6bf841d85c --- /dev/null +++ b/subprojects/helper-to-tcg/passes/PseudoInst.h @@ -0,0 +1,63 @@ +// +// Copyright(c) 2024 rev.ng Labs Srl. All Rights Reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, see <http://www.gnu.org/licenses/>. +// + +#pragma once + +#include <stdint.h> + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/Optional.h" +#include "llvm/IR/Module.h" +#include "llvm/IR/Value.h" + +// Pseudo instructions refers to extra LLVM instructions implemented as +// calls to undefined functions. They are useful for amending LLVM IR to +// simplify mapping to TCG in the backend, e.g. +// +// %2 = call i32 @IdentityMap.i32.i16(i16 %1) +// +// is a pseudo opcode used to communicate that %1 and %2 should be mapped +// to the same value in TCG. + +enum PseudoInstArg { + ArgInt, + ArgVec, + ArgPtr, + ArgLabel, + ArgVoid, +}; + +#define PSEUDO_INST_DEF(name, ret, args) name +enum PseudoInst : uint8_t { +#include "PseudoInst.inc" +}; +#undef PSEUDO_INST_DEF + +// Retrieve string representation and argument counts for a given +// pseudo instruction. +const char *pseudoInstName(PseudoInst Inst); +uint8_t pseudoInstArgCount(PseudoInst Inst); + +// Maps PseudoInst + return/argument types to a FunctionCallee that can be +// called. +llvm::FunctionCallee pseudoInstFunction(llvm::Module &M, PseudoInst Inst, + llvm::Type *RetType, + llvm::ArrayRef<llvm::Type *> ArgTypes); + +// Reverse mapping of above, takes a call instruction and attempts to map the +// callee to a PseudoInst. +PseudoInst getPseudoInstFromCall(const llvm::CallInst *Call); diff --git a/subprojects/helper-to-tcg/passes/PseudoInst.inc b/subprojects/helper-to-tcg/passes/PseudoInst.inc new file mode 100644 index 0000000000..9856afbe74 --- /dev/null +++ b/subprojects/helper-to-tcg/passes/PseudoInst.inc @@ -0,0 +1,76 @@ +PSEUDO_INST_DEF(InvalidPseudoInst, ArgVoid, PSEUDO_INST_ARGVEC(ArgVoid)), +// Identity mapping +PSEUDO_INST_DEF(IdentityMap, ArgInt, PSEUDO_INST_ARGVEC(ArgInt)), +// Pointer arithmetic +PSEUDO_INST_DEF(PtrAdd, ArgPtr, PSEUDO_INST_ARGVEC(ArgPtr, ArgInt)), +// Global accesses +PSEUDO_INST_DEF(AccessGlobalArray, ArgInt, PSEUDO_INST_ARGVEC(ArgInt)), +PSEUDO_INST_DEF(AccessGlobalValue, ArgInt, PSEUDO_INST_ARGVEC(ArgInt)), +// Conditional branch +PSEUDO_INST_DEF(Brcond, ArgVoid, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt, ArgLabel, ArgLabel)), +// Conditional move +PSEUDO_INST_DEF(Movcond, ArgInt, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt, ArgInt, ArgInt)), +// Vector creation ops +PSEUDO_INST_DEF(VecSplat, ArgVec, PSEUDO_INST_ARGVEC(ArgInt)), +// Vector unary ops +PSEUDO_INST_DEF(VecNot, ArgVec, PSEUDO_INST_ARGVEC(ArgVec)), +// Vector scalar binary ops +PSEUDO_INST_DEF(VecAddScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecSubScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecMulScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecXorScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecOrScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecAndScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecShlScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecLShrScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecAShrScalar, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgInt)), +// Vector unary ops that stores to pointer +PSEUDO_INST_DEF(VecNotStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +// Vector binary ops that stores to pointer +PSEUDO_INST_DEF(VecAddStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecSubStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecMulStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecXorStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecOrStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecAndStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecShlStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecLShrStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecAShrStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecAddScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecSubScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecMulScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecXorScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecOrScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecAndScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecShlScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecLShrScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +PSEUDO_INST_DEF(VecAShrScalarStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgInt)), +// Host memory operations +// vaddr, value sign size endian +PSEUDO_INST_DEF(GuestLoad, ArgInt, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt, ArgInt)), +PSEUDO_INST_DEF(GuestStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt, ArgInt)), +// ... +PSEUDO_INST_DEF(VecTruncStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecZExtStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecSExtStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecSignedSatAddStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecSignedSatSubStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecSelectStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecFunnelShrStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecAbsStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecSignedMaxStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecUnsignedMaxStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecSignedMinStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecUnsignedMinStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecCtlzStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecCttzStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecCtpopStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec)), +PSEUDO_INST_DEF(VecWideCondBitsel, ArgVec, PSEUDO_INST_ARGVEC(ArgVec, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecWideCondBitselStore, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgVec, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecCompare, ArgVec, PSEUDO_INST_ARGVEC(ArgInt, ArgVec, ArgVec)), +PSEUDO_INST_DEF(VecSelect, ArgVec, PSEUDO_INST_ARGVEC(ArgInt, ArgVec, ArgVec)), + +PSEUDO_INST_DEF(SignExtract, ArgInt, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt)), +PSEUDO_INST_DEF(Extract, ArgInt, PSEUDO_INST_ARGVEC(ArgInt, ArgInt, ArgInt)), + +PSEUDO_INST_DEF(Exception, ArgVoid, PSEUDO_INST_ARGVEC(ArgPtr, ArgInt)),

[RFC,v1,20/43] helper-to-tcg: Introduce pseudo instructions

Commit Message

Patch