diff mbox series

[2/2] hw/timer/hpet: Drop the unused macro

Message ID 20241126163046.3344931-3-zhao1.liu@intel.com (mailing list archive)
State New
Headers show
Series hw/timer/hpet: miscellaneous cleanup | expand

Commit Message

Zhao Liu Nov. 26, 2024, 4:30 p.m. UTC
HPET_TN_CFG_BITS_READONLY_OR_RESERVED is not used in any place since
HPET_TN_CFG_WRITE_MASK has been already used to check and fix the
writable bits in hpet_ram_write().

Drop this unused macro.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 include/hw/timer/hpet.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Philippe Mathieu-Daudé Nov. 26, 2024, 5:21 p.m. UTC | #1
On 26/11/24 17:30, Zhao Liu wrote:
> HPET_TN_CFG_BITS_READONLY_OR_RESERVED is not used in any place since
> HPET_TN_CFG_WRITE_MASK has been already used to check and fix the
> writable bits in hpet_ram_write().
> 
> Drop this unused macro.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   include/hw/timer/hpet.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
> index d17a8d43199e..71e8c62453d1 100644
> --- a/include/hw/timer/hpet.h
> +++ b/include/hw/timer/hpet.h
> @@ -58,7 +58,6 @@
>   #define HPET_TN_CFG_WRITE_MASK  0x7f4e
>   #define HPET_TN_INT_ROUTE_SHIFT      9
>   #define HPET_TN_INT_ROUTE_CAP_SHIFT 32
> -#define HPET_TN_CFG_BITS_READONLY_OR_RESERVED 0xffff80b1U

Never used AFAICT.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
index d17a8d43199e..71e8c62453d1 100644
--- a/include/hw/timer/hpet.h
+++ b/include/hw/timer/hpet.h
@@ -58,7 +58,6 @@ 
 #define HPET_TN_CFG_WRITE_MASK  0x7f4e
 #define HPET_TN_INT_ROUTE_SHIFT      9
 #define HPET_TN_INT_ROUTE_CAP_SHIFT 32
-#define HPET_TN_CFG_BITS_READONLY_OR_RESERVED 0xffff80b1U
 
 struct hpet_fw_entry
 {