[v2,for-10.0,48/54] target/s390x: Set default NaN pattern explicitly

Commit Message

Peter Maydell Dec. 2, 2024, 1:13 p.m. UTC

Set the default NaN pattern explicitly for s390x.

Signed-off-by: Peter Maydell <[e-mail]>
---
 target/s390x/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Henderson Dec. 2, 2024, 5:35 p.m. UTC | #1

On 12/2/24 07:13, Peter Maydell wrote:
> Set the default NaN pattern explicitly for s390x.
> 
> Signed-off-by: Peter Maydell <[e-mail]>
> ---
>   target/s390x/cpu.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
> index e74055bad79..adb27504ad5 100644
> --- a/target/s390x/cpu.c
> +++ b/target/s390x/cpu.c
> @@ -209,6 +209,8 @@ static void s390_cpu_reset_hold(Object *obj, ResetType type)
>           set_float_3nan_prop_rule(float_3nan_prop_s_abc, &env->fpu_status);
>           set_float_infzeronan_rule(float_infzeronan_dnan_always,
>                                     &env->fpu_status);
> +        /* Default NaN value: sign bit clear, frac msb set */
> +        set_float_default_nan_pattern(0b01000000, &env->fpu_status);
>          /* fall through */
>       case RESET_TYPE_S390_CPU_NORMAL:
>           env->psw.mask &= ~PSW_MASK_RI;

Reviewed-by: Richard Henderson <[e-mail]>

r~

Patch

diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index e74055bad79..adb27504ad5 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -209,6 +209,8 @@  static void s390_cpu_reset_hold(Object *obj, ResetType type)
         set_float_3nan_prop_rule(float_3nan_prop_s_abc, &env->fpu_status);
         set_float_infzeronan_rule(float_infzeronan_dnan_always,
                                   &env->fpu_status);
+        /* Default NaN value: sign bit clear, frac msb set */
+        set_float_default_nan_pattern(0b01000000, &env->fpu_status);
        /* fall through */
     case RESET_TYPE_S390_CPU_NORMAL:
         env->psw.mask &= ~PSW_MASK_RI;