[v2,for-10.0,50/54] target/xtensa: Set default NaN pattern explicitly

Commit Message

Peter Maydell Dec. 2, 2024, 1:13 p.m. UTC

Set the default NaN pattern explicitly for xtensa.

Signed-off-by: Peter Maydell <[e-mail]>
---
 target/xtensa/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Henderson Dec. 2, 2024, 5:37 p.m. UTC | #1

On 12/2/24 07:13, Peter Maydell wrote:
> Set the default NaN pattern explicitly for xtensa.
> 
> Signed-off-by: Peter Maydell <[e-mail]>
> ---
>   target/xtensa/cpu.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
> index 3163b758235..0d4d79b58b4 100644
> --- a/target/xtensa/cpu.c
> +++ b/target/xtensa/cpu.c
> @@ -136,6 +136,8 @@ static void xtensa_cpu_reset_hold(Object *obj, ResetType type)
>       /* For inf * 0 + NaN, return the input NaN */
>       set_float_infzeronan_rule(float_infzeronan_dnan_never, &env->fp_status);
>       set_no_signaling_nans(!dfpu, &env->fp_status);
> +    /* Default NaN value: sign bit clear, set frac msb */
> +    set_float_default_nan_pattern(0b01000000, &env->fp_status);
>       xtensa_use_first_nan(env, !dfpu);
>   }
>   

Reviewed-by: Richard Henderson <[e-mail]>

r~

Patch

diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
index 3163b758235..0d4d79b58b4 100644
--- a/target/xtensa/cpu.c
+++ b/target/xtensa/cpu.c
@@ -136,6 +136,8 @@  static void xtensa_cpu_reset_hold(Object *obj, ResetType type)
     /* For inf * 0 + NaN, return the input NaN */
     set_float_infzeronan_rule(float_infzeronan_dnan_never, &env->fp_status);
     set_no_signaling_nans(!dfpu, &env->fp_status);
+    /* Default NaN value: sign bit clear, set frac msb */
+    set_float_default_nan_pattern(0b01000000, &env->fp_status);
     xtensa_use_first_nan(env, !dfpu);
 }