| Message ID | 20241210152401.1823648-15-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tcg: Remove in-flight mask data from OptContext | expand |
On 12/10/24 07:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tcg/optimize.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index e6dc9f2e28..5f3a824a07 100644 > --- a/tcg/optimize.c > +++ b/tcg/optimize.c > @@ -1701,15 +1701,17 @@ static bool fold_dup2(OptContext *ctx, TCGOp *op) > > static bool fold_eqv(OptContext *ctx, TCGOp *op) > { > + uint64_t s_mask; > + > if (fold_const2_commutative(ctx, op) || > fold_xi_to_x(ctx, op, -1) || > fold_xi_to_not(ctx, op, 0)) { > return true; > } > > - ctx->s_mask = arg_info(op->args[1])->s_mask > - & arg_info(op->args[2])->s_mask; > - return false; > + s_mask = arg_info(op->args[1])->s_mask > + & arg_info(op->args[2])->s_mask; > + return fold_masks_zs(ctx, op, -1, s_mask); > } Should we introduce a fold_masks_s function to replace this call? > > static bool fold_extract(OptContext *ctx, TCGOp *op) Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/tcg/optimize.c b/tcg/optimize.c index e6dc9f2e28..5f3a824a07 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1701,15 +1701,17 @@ static bool fold_dup2(OptContext *ctx, TCGOp *op) static bool fold_eqv(OptContext *ctx, TCGOp *op) { + uint64_t s_mask; + if (fold_const2_commutative(ctx, op) || fold_xi_to_x(ctx, op, -1) || fold_xi_to_not(ctx, op, 0)) { return true; } - ctx->s_mask = arg_info(op->args[1])->s_mask - & arg_info(op->args[2])->s_mask; - return false; + s_mask = arg_info(op->args[1])->s_mask + & arg_info(op->args[2])->s_mask; + return fold_masks_zs(ctx, op, -1, s_mask); } static bool fold_extract(OptContext *ctx, TCGOp *op)
Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tcg/optimize.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)