| Message ID | 20241210152401.1823648-45-richard.henderson@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | tcg: Remove in-flight mask data from OptContext | expand |
On 12/10/24 07:23, Richard Henderson wrote: > All mask setting is now done with parameters via fold_masks_*. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > tcg/optimize.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index 94e942e1cf..eb6e93809e 100644 > --- a/tcg/optimize.c > +++ b/tcg/optimize.c > @@ -64,9 +64,6 @@ typedef struct OptContext { > QSIMPLEQ_HEAD(, MemCopyInfo) mem_free; > > /* In flight values from optimization. */ > - uint64_t a_mask; /* mask bit is 0 iff value identical to first input */ > - uint64_t z_mask; /* mask bit is 0 iff value bit is 0 */ > - uint64_t s_mask; /* mask of clrsb(value) bits */ > TCGType type; > } OptContext; > > @@ -987,14 +984,6 @@ static bool finish_folding(OptContext *ctx, TCGOp *op) > for (i = 0; i < nb_oargs; i++) { > TCGTemp *ts = arg_temp(op->args[i]); > reset_ts(ctx, ts); > - /* > - * Save the corresponding known-zero/sign bits mask for the > - * first output argument (only one supported so far). > - */ > - if (i == 0) { > - ts_info(ts)->z_mask = ctx->z_mask; > - ts_info(ts)->s_mask = ctx->s_mask; > - } > } > return true; > } > @@ -2867,11 +2856,6 @@ void tcg_optimize(TCGContext *s) > ctx.type = TCG_TYPE_I32; > } > > - /* Assume all bits affected, no bits known zero, no sign reps. */ > - ctx.a_mask = -1; > - ctx.z_mask = -1; > - ctx.s_mask = 0; > - > /* > * Process each opcode. > * Sorted alphabetically by opcode as much as possible. Great! Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/tcg/optimize.c b/tcg/optimize.c index 94e942e1cf..eb6e93809e 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -64,9 +64,6 @@ typedef struct OptContext { QSIMPLEQ_HEAD(, MemCopyInfo) mem_free; /* In flight values from optimization. */ - uint64_t a_mask; /* mask bit is 0 iff value identical to first input */ - uint64_t z_mask; /* mask bit is 0 iff value bit is 0 */ - uint64_t s_mask; /* mask of clrsb(value) bits */ TCGType type; } OptContext; @@ -987,14 +984,6 @@ static bool finish_folding(OptContext *ctx, TCGOp *op) for (i = 0; i < nb_oargs; i++) { TCGTemp *ts = arg_temp(op->args[i]); reset_ts(ctx, ts); - /* - * Save the corresponding known-zero/sign bits mask for the - * first output argument (only one supported so far). - */ - if (i == 0) { - ts_info(ts)->z_mask = ctx->z_mask; - ts_info(ts)->s_mask = ctx->s_mask; - } } return true; } @@ -2867,11 +2856,6 @@ void tcg_optimize(TCGContext *s) ctx.type = TCG_TYPE_I32; } - /* Assume all bits affected, no bits known zero, no sign reps. */ - ctx.a_mask = -1; - ctx.z_mask = -1; - ctx.s_mask = 0; - /* * Process each opcode. * Sorted alphabetically by opcode as much as possible.
All mask setting is now done with parameters via fold_masks_*. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- tcg/optimize.c | 16 ---------------- 1 file changed, 16 deletions(-)