diff mbox series

[67/71] hw/watchdog: Constify all Property

Message ID 20241213193004.2515684-5-richard.henderson@linaro.org (mailing list archive)
State New
Headers show
Series whole-tree: Constify Property structures | expand

Commit Message

Richard Henderson Dec. 13, 2024, 7:30 p.m. UTC
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 hw/watchdog/sbsa_gwdt.c  | 2 +-
 hw/watchdog/wdt_aspeed.c | 2 +-
 hw/watchdog/wdt_imx2.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Cédric Le Goater Dec. 14, 2024, 10:15 a.m. UTC | #1
On 12/13/24 20:30, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


For the aspeed part,

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.
> ---
>   hw/watchdog/sbsa_gwdt.c  | 2 +-
>   hw/watchdog/wdt_aspeed.c | 2 +-
>   hw/watchdog/wdt_imx2.c   | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c
> index 80f9b36e79..2e25d4b4e9 100644
> --- a/hw/watchdog/sbsa_gwdt.c
> +++ b/hw/watchdog/sbsa_gwdt.c
> @@ -262,7 +262,7 @@ static void wdt_sbsa_gwdt_realize(DeviceState *dev, Error **errp)
>                   dev);
>   }
>   
> -static Property wdt_sbsa_gwdt_props[] = {
> +static const Property wdt_sbsa_gwdt_props[] = {
>       /*
>        * Timer frequency in Hz. This must match the frequency used by
>        * the CPU's generic timer. Default 62.5Hz matches QEMU's legacy
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 39c3f362a8..c95877e5c7 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -288,7 +288,7 @@ static void aspeed_wdt_realize(DeviceState *dev, Error **errp)
>       sysbus_init_mmio(sbd, &s->iomem);
>   }
>   
> -static Property aspeed_wdt_properties[] = {
> +static const Property aspeed_wdt_properties[] = {
>       DEFINE_PROP_LINK("scu", AspeedWDTState, scu, TYPE_ASPEED_SCU,
>                        AspeedSCUState *),
>       DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
> index 8162d58afa..61fbd91ee4 100644
> --- a/hw/watchdog/wdt_imx2.c
> +++ b/hw/watchdog/wdt_imx2.c
> @@ -281,7 +281,7 @@ static void imx2_wdt_realize(DeviceState *dev, Error **errp)
>       }
>   }
>   
> -static Property imx2_wdt_properties[] = {
> +static const Property imx2_wdt_properties[] = {
>       DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
>                        false),
>       DEFINE_PROP_END_OF_LIST()
Leif Lindholm Dec. 16, 2024, 1:17 p.m. UTC | #2
On Fri, 13 Dec 2024 at 19:30, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

For sbsa:
Reviewed-by: Leif Lindholm <leif.lindholm@oss.qualcomm.com>

/
    Leif

> ---
>  hw/watchdog/sbsa_gwdt.c  | 2 +-
>  hw/watchdog/wdt_aspeed.c | 2 +-
>  hw/watchdog/wdt_imx2.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c
> index 80f9b36e79..2e25d4b4e9 100644
> --- a/hw/watchdog/sbsa_gwdt.c
> +++ b/hw/watchdog/sbsa_gwdt.c
> @@ -262,7 +262,7 @@ static void wdt_sbsa_gwdt_realize(DeviceState *dev, Error **errp)
>                  dev);
>  }
>
> -static Property wdt_sbsa_gwdt_props[] = {
> +static const Property wdt_sbsa_gwdt_props[] = {
>      /*
>       * Timer frequency in Hz. This must match the frequency used by
>       * the CPU's generic timer. Default 62.5Hz matches QEMU's legacy
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 39c3f362a8..c95877e5c7 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -288,7 +288,7 @@ static void aspeed_wdt_realize(DeviceState *dev, Error **errp)
>      sysbus_init_mmio(sbd, &s->iomem);
>  }
>
> -static Property aspeed_wdt_properties[] = {
> +static const Property aspeed_wdt_properties[] = {
>      DEFINE_PROP_LINK("scu", AspeedWDTState, scu, TYPE_ASPEED_SCU,
>                       AspeedSCUState *),
>      DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
> index 8162d58afa..61fbd91ee4 100644
> --- a/hw/watchdog/wdt_imx2.c
> +++ b/hw/watchdog/wdt_imx2.c
> @@ -281,7 +281,7 @@ static void imx2_wdt_realize(DeviceState *dev, Error **errp)
>      }
>  }
>
> -static Property imx2_wdt_properties[] = {
> +static const Property imx2_wdt_properties[] = {
>      DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
>                       false),
>      DEFINE_PROP_END_OF_LIST()
> --
> 2.43.0
>
diff mbox series

Patch

diff --git a/hw/watchdog/sbsa_gwdt.c b/hw/watchdog/sbsa_gwdt.c
index 80f9b36e79..2e25d4b4e9 100644
--- a/hw/watchdog/sbsa_gwdt.c
+++ b/hw/watchdog/sbsa_gwdt.c
@@ -262,7 +262,7 @@  static void wdt_sbsa_gwdt_realize(DeviceState *dev, Error **errp)
                 dev);
 }
 
-static Property wdt_sbsa_gwdt_props[] = {
+static const Property wdt_sbsa_gwdt_props[] = {
     /*
      * Timer frequency in Hz. This must match the frequency used by
      * the CPU's generic timer. Default 62.5Hz matches QEMU's legacy
diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
index 39c3f362a8..c95877e5c7 100644
--- a/hw/watchdog/wdt_aspeed.c
+++ b/hw/watchdog/wdt_aspeed.c
@@ -288,7 +288,7 @@  static void aspeed_wdt_realize(DeviceState *dev, Error **errp)
     sysbus_init_mmio(sbd, &s->iomem);
 }
 
-static Property aspeed_wdt_properties[] = {
+static const Property aspeed_wdt_properties[] = {
     DEFINE_PROP_LINK("scu", AspeedWDTState, scu, TYPE_ASPEED_SCU,
                      AspeedSCUState *),
     DEFINE_PROP_END_OF_LIST(),
diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
index 8162d58afa..61fbd91ee4 100644
--- a/hw/watchdog/wdt_imx2.c
+++ b/hw/watchdog/wdt_imx2.c
@@ -281,7 +281,7 @@  static void imx2_wdt_realize(DeviceState *dev, Error **errp)
     }
 }
 
-static Property imx2_wdt_properties[] = {
+static const Property imx2_wdt_properties[] = {
     DEFINE_PROP_BOOL("pretimeout-support", IMX2WdtState, pretimeout_support,
                      false),
     DEFINE_PROP_END_OF_LIST()