| Message ID | 20250124124713.64F8C4E6031@zero.eik.bme.hu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] hw/usb/hcd-ehci: Fix debug printf format string | expand |
On 24/1/25 13:47, BALATON Zoltan wrote: > The variable is uint64_t so needs %PRIu64 instead of %d. > > Fixes: 3ae7eb88c47 ("ehci: fix overflow in frame timer code") > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > --- > v3: Fixed commit message to match what the patch actually does > > hw/usb/hcd-ehci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> and queued, thanks!
On 24/1/25 13:47, BALATON Zoltan wrote: > The variable is uint64_t so needs %PRIu64 instead of %d. > > Fixes: 3ae7eb88c47 ("ehci: fix overflow in frame timer code") > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > --- > v3: Fixed commit message to match what the patch actually does > > hw/usb/hcd-ehci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch queued, thanks.
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 6c4c14c895..b090f25365 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2287,7 +2287,8 @@ static void ehci_work_bh(void *opaque) ehci_update_frindex(ehci, skipped_uframes); ehci->last_run_ns += UFRAME_TIMER_NS * skipped_uframes; uframes -= skipped_uframes; - DPRINTF("WARNING - EHCI skipped %d uframes\n", skipped_uframes); + DPRINTF("WARNING - EHCI skipped %"PRIu64" uframes\n", + skipped_uframes); } for (i = 0; i < uframes; i++) {
The variable is uint64_t so needs %PRIu64 instead of %d. Fixes: 3ae7eb88c47 ("ehci: fix overflow in frame timer code") Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> --- v3: Fixed commit message to match what the patch actually does hw/usb/hcd-ehci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)