From patchwork Fri Feb 21 08:07:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13984970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2D8CC021AA for ; Fri, 21 Feb 2025 08:10:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tlO4f-0004cG-3s; Fri, 21 Feb 2025 03:07:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlO4c-0004ay-Mm for qemu-devel@nongnu.org; Fri, 21 Feb 2025 03:07:50 -0500 Received: from smarthost1.eviden.com ([80.78.11.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tlO4a-0005ko-WD for qemu-devel@nongnu.org; Fri, 21 Feb 2025 03:07:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1740125269; x=1771661269; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BrG4y3xDgUJOKdvWUgQWbXUTo2tp+lMrO+qSWDscVRo=; b=memZNBwiLKK7AIDte16vo6MnkMVD2fvJ59yC40tzTME8AyHE4OSMNaxW z323FlrF5GQWozkfBidkk40EmxTrwKyk6BgJ2FI/gi9OheRlivPHlRrCo U3zaohaF+qJ7U1uQA+np39q8ewwcAg2BuBnQwWKa+gXd2SYlJlqsjtgkb NXMbAnLST51t0kmruSPWlqkHbYp6fv4P65vl3pNau3Z9t64TG0sX9nXFL EKeFp9uKflcMpDa5sQgxm6WzbYMiqXMpDc/x5ds87VypsfiJAuR7sGuDD vadlDoPup0nb+P+Kk6fk6/BzLlj2pUKqnPvrrWcCdTikRTyitPzIaDOet Q==; X-CSE-ConnectionGUID: vaOXLAvTTTW8m0n1+0fJaQ== X-CSE-MsgGUID: scMsAkXxSeGc6IWWpKbbmA== X-IronPort-AV: E=Sophos;i="6.13,304,1732575600"; d="scan'208";a="31394146" X-MGA-submission: MDEN2jHDneYqbeae3jxb5kBe0ShaTiDAxS9dzSmXOlxZ0ANpeD+t1B2pKEWIEU1dBG8cviNmR1hvfPdapr4G3iA5HQLN9vwPu75DqjV85/sStT4XHhvOIUR3WzbE5n5ca7sAXq5mO6WyYiBM3WahutAHrYSSvEfzRF9Qx3biLqoYRQ== Received: from mail-vi1eur05lp2170.outbound.protection.outlook.com (HELO EUR05-VI1-obe.outbound.protection.outlook.com) ([104.47.17.170]) by smarthost1.eviden.com with ESMTP/TLS/TLS_AES_256_GCM_SHA384; 21 Feb 2025 09:07:47 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dkMpXL4FvlRUSUYkxW+SQp4OFHLFkWJfWpSUjl5zWfs8V6MTT9M8KXijM3yWR5wo6+SW2/SeeWHY0GiMbi6COr98Ncnv9ocD9QzpWEgqEQRrKtNPnsQvZXx0/GI2w89r1TogkUJ8PFj0fEyLfPm5zjSTPVP6AkN1izUCuJ9Ue/coT0OV1sDR0G72fmN1acKIDltXOX5TXc5PxDUGHYU85vEAZ5Qvn6QtGe2lp9pqqiUDhugmtlUSderapGml5GugJ0/DKfhuQLxlcnAZ/1u2oXxIdg17dHD6oFuR9TfexGKCE9WucQGUQKkdTuFXhxRBY5AaYzSJmlR1PiHvCY/39g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srhIn/WpdlVpAE2cNticNNYMCyk2sH0vssLZt9U3Azs=; b=wTKdASl9wIhFYquY/mAMUaet6Tvv0dp2iQAE7obkelAGAQkqfOf6cE9qKjvi3gcTmK7CH0i8srmPoYSjrCVpfvk2AM2UPpxDSu0IkCiuc+dkEcUWCbrUhtaRzIzSPM3TzNEznkZzdYUVgHObhV/aNnuwUVi/MLrtJWKh6bpk3cm9/352yP/ibR5UV8hOYP/6+xfi1Brf6LO3n0q04ITNGZ+CvA6wGYaF7A158vBf4n8TSDJD5602jDLL0kf55gC6nfIbm2E4oQKm+mGW7x2n6RRTBeuktTOXLecX4hI4YrVHepEWcRBjE7SHQrVjT+SKjv7fWQAxaAgpo9XACRghGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Eviden.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srhIn/WpdlVpAE2cNticNNYMCyk2sH0vssLZt9U3Azs=; b=KQWg7AkaIuFYoGkER52wxSK3hP2Z/CAELR9XkWyi9KQdjQv1fC+6SEZJlfR9bWfhFeCwFwX2I0pBlsrzaCm+ZbYQ5ysitePejOEZd1LVlDjHDVny0yd39XI7/ZHZyM2+0OLHrjsZJ8qkhgIbFwC6gOZrvlSeBAvFeM9L6COD/zIBMlwbkADiFwEKgd/zOW3dxkfWExGhwujkkroMBptUn/zlHxEBBxXePwnPrQGkmjNbESTb0BTJls7sOSIJzPm6bu/a+e+kkxDCBKd0b9R5rn4dmnxu46cxce/swmzKFqNQeIxSiwQT4bkCLAjFuGMcPSPFznpPxLgial6ZTrjkwQ== Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by DB8PR07MB6459.eurprd07.prod.outlook.com (2603:10a6:10:142::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb 2025 08:07:43 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%7]) with mapi id 15.20.8445.017; Fri, 21 Feb 2025 08:07:42 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , "mst@redhat.com" , "tjeznach@rivosinc.com" , "minwoo.im@samsung.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH v3 17/19] intel_iommu: Set address mask when a translation fails and adjust W permission Thread-Topic: [PATCH v3 17/19] intel_iommu: Set address mask when a translation fails and adjust W permission Thread-Index: AQHbhDeu169TFxh780WaPeBcIqbPLw== Date: Fri, 21 Feb 2025 08:07:42 +0000 Message-ID: <20250221080331.186285-18-clement.mathieu--drif@eviden.com> References: <20250221080331.186285-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20250221080331.186285-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|DB8PR07MB6459:EE_ x-ms-office365-filtering-correlation-id: 72974e0f-bdbc-43a0-4122-08dd524ed158 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|7416014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?0YQ3OBIJ3r/cc6Kg7+0rIsBOJ4?= =?iso-8859-1?q?loLNlxIS0MC9owrneG6CLNyUR4oBcOQEdLhPdWY00ZeFtvUazcWQeeBEQgy2?= =?iso-8859-1?q?PSm05KrOwdKskBX57KHHAFq8N8eYE0LXI83bYZcyWnasrMMrgIPab3uhTkMr?= =?iso-8859-1?q?qCuRvDDodKW4WrgeUZY2bOFghA7uOhDl1FQRqHKSe4bQCIk6VQanVNoxk8vq?= =?iso-8859-1?q?MHEul/gjD+SBiXNCaKRkJtGXNcVJSmk1BORR5hP/IE2/nLgd+/9Ll3CUDR7q?= =?iso-8859-1?q?NlrtXlGfB2aUpnpgMKC1HhC6J2i29JfCxxgfzCLZFOFQB9yz3XfLlOl4P+Na?= =?iso-8859-1?q?MygEafuCFDBX2lE0oWL4S+AvPrDNPGKOt1eDS7PkjA2LIqaPmYmUO8byMjys?= =?iso-8859-1?q?CfPJPtOz/4AMiCb3Y7oZuCRXOwKqS2JbZYjv8P/d1Qt4/72gXPnlHnDMrycm?= =?iso-8859-1?q?WI/1a/mhYwylRmdoItgE4jKqDrR9ePWJTCa81gyDbk7hn2FiK6IN+QdS09e8?= =?iso-8859-1?q?twX3MJfrHLclnNkMoGApbWzXhzJMTTIRm1bqec1mhuoCOCkQDAlS+FeSDec5?= =?iso-8859-1?q?zABJwa0oo/yUT04Vn2yyWWaVM8Coawz5ZsjWXVQ9X0mpg/rFMXYZwgSHIuVI?= =?iso-8859-1?q?O7gJgiHtT1o1KfJybMgxQPyv38z4KTvjHoWMHjD29mv06tudijuNSYA4Jobr?= =?iso-8859-1?q?EPgxrWhrWGCWqh29hcgSkrTLAP5ufczdQrZBrh67YJrG/31FTjybihhwt6i4?= =?iso-8859-1?q?Y1HeDWXtlZCIN8FOorTqLeApNaC9ZRUeVJkySofD1YfwcpJk0oiyp22ucf9R?= =?iso-8859-1?q?UPEwDD9xjQvds+JD965aSu4kwknrN4Bz/BnRzEnT06c5wA5q8JBR4sVoT6Pg?= =?iso-8859-1?q?nD+/EAOHNAwIFk5uRyhJSf0GyX+z+RKhymoNsYrQJU3N5TOUHIg+kMmciEfl?= =?iso-8859-1?q?/M0ysHwQL5xoIm/Psj4dgIhVqfnl5gSQ9CTWOA/HYtdtka9NHeSM2fhWQRUV?= =?iso-8859-1?q?4MedrQ/R4JUNgpx6C+smL5k4ne2Yj5il3/oiRCjK/rt95xpFDgBGOzxRWTfm?= =?iso-8859-1?q?g0/n8USfxbqVUwwiUBcwaIFzmQrhbkMqGsIMLScGHn8Q7WgCygrCCAfQDW9l?= =?iso-8859-1?q?tZBoVPDtvcFSml/m2TaSZEjuQg3WtN0i7oDgFMtHDAKmYEdeqz004VjxfMym?= =?iso-8859-1?q?dMEsDgahD0ceis3omsTcZ8xXkVKbAXqNVXhvjQftgB4D4hEjbXWwEMCbT+Ov?= =?iso-8859-1?q?5v/huJHo9qB5jcEKwhXWmXOzujKLQxufQiShPQnZ5rXnG0nlhDbF/eOGLXJ0?= =?iso-8859-1?q?6nklNeFR7lwNNFSpudaImWuCThJQuXAMrIo2kxkfkPZxsYNHUcBO3/2J/tip?= =?iso-8859-1?q?GS6XCYvhn0PhBLXa9jHuBX0oKPL2ykjlmEKtmQD6kHq9Oe6t1/YpcaWCDlE9?= =?iso-8859-1?q?kf6KdJnxWkaVE9JSHe8eYuFLiILZF69M44jRQkDxYeuQrppoLDgkuT67Pbpd?= =?iso-8859-1?q?OuAIoh?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7416014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?mGn8lmtpcXtNlrt556d1Kx4?= =?iso-8859-1?q?cNjmIBtEC09gDnEqOJ+7t5d6ULfq8bCbtb+0GjrxIrjHY6EXs8Ie59hJBuoW?= =?iso-8859-1?q?atK5NuzjkMKxa+ryRDmDKlBVoraSV9G+Y7zwtVp3nO2Awp3hB2Y+J1bkU53s?= =?iso-8859-1?q?iaio0KEmm/aH7ZjvnZgJVNZCPik7pacqTkFXsZpN1Xz1E7xsP1gYv/DrwIqC?= =?iso-8859-1?q?9mAh75d26Mm/r3HFJ4D21JUmuyf/M7aEl+HfDp/FE2e0d5mtzlxlXzOmb5On?= =?iso-8859-1?q?Q5TFrxSNuzLh0hYyGON+o29xqhL8aR7c4umzeSAqqlr2Mj6/S5f0RWkmNjpQ?= =?iso-8859-1?q?rkdPNwxb+X7R5C0kuw+paiKO9Ruvj+RVqJqKkOJFv3DPbRI9cXmXisI/xP6P?= =?iso-8859-1?q?XMETwaq9A2I2P9ZzmoHAbscYKeCGQS/FaO3ATWDyRuhO/pB5Fqdh0aocbC8F?= =?iso-8859-1?q?FxqWsv8aGgqgMGU8uXjEB60QF0Ue4LV8N6cnn4FtuWPhoAeif37k2Juyl0En?= =?iso-8859-1?q?5mJM2ZLlGISG/fhd0GP0GELlQ4C+YEOwa6D4DMvUVKlmBV0o4TcYHPMKeNGU?= =?iso-8859-1?q?qYwNImMQTvh9HYxa85tWEop44rQ5U8oNLsxmuqIzesHOqAQrudbtYfmljqIH?= =?iso-8859-1?q?SwaiNrCNKNYisyNIfmF53RuBAMUhUJdg0SZmd+vaf2jUB3rUniruxMDnA3Yu?= =?iso-8859-1?q?fxaaGLFzp7DnMNt8MjuVqWWLujwZygbKk6alJHwFK0MzmHf1UBkedv2p5lo8?= =?iso-8859-1?q?D41DylaGcL4duwZ1ak2foposjOl1EkQ3GFQcjRPsd/YSHraLqqFTrG5QKJew?= =?iso-8859-1?q?25ua4Rq/Wp9c2HZM0NTgU6GY5tNdFwjejn+Rd+1/K/5d9Awnek3gZOrgOTk6?= =?iso-8859-1?q?ZHx2Y+Z6o9XBL1rpO+tNOrM5vjhKtC43EOvOHvxP4bATnHipJaLxWmeA0S/F?= =?iso-8859-1?q?JDSp/9CT3OeKNoiwMhtdC8UKL2dFt+TZFiRbqfcR1hoH0hEyT2lSmfkz1ZV6?= =?iso-8859-1?q?1U3abX+lJAeQ3ZylwnqBZkmJB0p5CgbGrGmF+e89t+pVU8v8m+QQfzRjHAJi?= =?iso-8859-1?q?e6Nwo5lJVMaRq1HPDX6vHihrQV7H9b68xD13Wsv/IbLOuvfSIZeauz6MWe4s?= =?iso-8859-1?q?zE8C8eIZepqZVnMkZtVBneG30VVgi4qCsKw418MkXekqg4SQA3lpDXc6arIp?= =?iso-8859-1?q?OSUH8k6uRPaxSoFc2+6P5x6ZjM53/6mVtonU0HKSlatYt7AP6NqC/gtMcElF?= =?iso-8859-1?q?AnYJl0wmfNY0S8rjKprVvfvF3XwN4GlfO5bcd2ZUj6ESUmlZ8LSwm6DHu2Ec?= =?iso-8859-1?q?rIiGjEoUVR2bCZJAzanb6aQDmGxdNY4f3GqYLRCUQVlFuNrgv9DB3LopflEm?= =?iso-8859-1?q?E4zK09YYxc+wI+OLgCFTPKV+k4o8zCgflYExT5khwEDRVIuRldYo0YkewrBy?= =?iso-8859-1?q?wpmGtjBducgqw9GgUUWn/IE/UlrAi+BTT9dNl3L3G20hDktZqT66PI70T/tm?= =?iso-8859-1?q?MV+/q1o/iK2fDYVzJ58BYi1cA1QqLaTOGtLvObPCDi70fhWagoz17tRgSeXQ?= =?iso-8859-1?q?MXRsdRBmjlXWLtgVpwYZDlufj5dvwJON9e/iw7CcbWVW9wFm481YNdZz+W5s?= =?iso-8859-1?q?1S4hQwfnfbzYXnoKXfuz4tDK2iSGb/+74u6hspgZ85H7YbiYVp+cmXkBHJ9k?= =?iso-8859-1?q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72974e0f-bdbc-43a0-4122-08dd524ed158 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2025 08:07:42.9583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dQYzHTkyuE2PiobLm35HuW08jGXa6ON2W9h0a4N2VVzMKqgCVbxnGTWQn94ZLdpBdiWZkTmmUm4fS8uoJPwW7O2p9Z4DTFx7CQRyF7Cs3hhMFzIeOpJBlgbY0QPPdnhb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR07MB6459 Received-SPF: pass client-ip=80.78.11.82; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost1.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Clement Mathieu--Drif Implements the behavior defined in section 10.2.3.5 of PCIe spec rev 5. This is needed by devices that support ATS. Signed-off-by: Clement Mathieu--Drif --- hw/i386/intel_iommu.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index d3772d8902..b9b5d492f5 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2100,7 +2100,8 @@ static bool vtd_do_iommu_translate(VTDAddressSpace *vtd_as, PCIBus *bus, uint8_t bus_num = pci_bus_num(bus); VTDContextCacheEntry *cc_entry; uint64_t pte, page_mask; - uint32_t level, pasid = vtd_as->pasid; + uint32_t level = UINT32_MAX; + uint32_t pasid = vtd_as->pasid; uint16_t source_id = PCI_BUILD_BDF(bus_num, devfn); int ret_fr; bool is_fpd_set = false; @@ -2259,14 +2260,19 @@ out: entry->iova = addr & page_mask; entry->translated_addr = vtd_get_pte_addr(pte, s->aw_bits) & page_mask; entry->addr_mask = ~page_mask; - entry->perm = access_flags; + entry->perm = (is_write ? access_flags : (access_flags & (~IOMMU_WO))); return true; error: vtd_iommu_unlock(s); entry->iova = 0; entry->translated_addr = 0; - entry->addr_mask = 0; + /* + * Set the mask for ATS (the range must be present even when the + * translation fails : PCIe rev 5 10.2.3.5) + */ + entry->addr_mask = (level != UINT32_MAX) ? + (~vtd_pt_level_page_mask(level)) : (~VTD_PAGE_MASK_4K); entry->perm = IOMMU_NONE; return false; }