| Message ID | 20250226104833.1176253-1-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/functional/test_arm_sx1: Check whether the serial console is working | expand |
On 26/2/25 11:48, Thomas Huth wrote: > The kernel that is used in the sx1 test prints the usual Linux log > onto the serial console, but this test currently ignores it. To > make sure that the serial device is working properly, let's check > for some strings in the output here. > > While we're at it, also add the test to the corresponding section > in the MAINTAINERS file. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Based-on: <20250221140640.786341-1-peter.maydell@linaro.org> > > MAINTAINERS | 1 + > tests/functional/test_arm_sx1.py | 7 ++++--- > 2 files changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Wed, 26 Feb 2025 at 10:48, Thomas Huth <thuth@redhat.com> wrote: > > The kernel that is used in the sx1 test prints the usual Linux log > onto the serial console, but this test currently ignores it. To > make sure that the serial device is working properly, let's check > for some strings in the output here. > > While we're at it, also add the test to the corresponding section > in the MAINTAINERS file. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Based-on: <20250221140640.786341-1-peter.maydell@linaro.org> Applied to target-arm.next, thanks. (If you'd rather take this via your own test tree let me know and I'll drop it on my end.) -- PMM
On 2/26/25 11:48, Thomas Huth wrote: > The kernel that is used in the sx1 test prints the usual Linux log > onto the serial console, but this test currently ignores it. To > make sure that the serial device is working properly, let's check > for some strings in the output here. > > While we're at it, also add the test to the corresponding section > in the MAINTAINERS file. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Tested-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > Based-on: <20250221140640.786341-1-peter.maydell@linaro.org> > > MAINTAINERS | 1 + > tests/functional/test_arm_sx1.py | 7 ++++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 05ec99adfd0..098daea6f24 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2000,6 +2000,7 @@ S: Maintained > F: hw/*/omap* > F: include/hw/arm/omap.h > F: docs/system/arm/sx1.rst > +F: tests/functional/test_arm_sx1.py > > IPack > M: Alberto Garcia <berto@igalia.com> > diff --git a/tests/functional/test_arm_sx1.py b/tests/functional/test_arm_sx1.py > index 4dd1e1859fa..25800b388c9 100755 > --- a/tests/functional/test_arm_sx1.py > +++ b/tests/functional/test_arm_sx1.py > @@ -43,7 +43,8 @@ def test_arm_sx1_initrd(self): > self.vm.add_args('-append', f'kunit.enable=0 rdinit=/sbin/init {self.CONSOLE_ARGS}') > self.vm.add_args('-no-reboot') > self.launch_kernel(zimage_path, > - initrd=initrd_path) > + initrd=initrd_path, > + wait_for='Boot successful') > self.vm.wait(timeout=120) > > def test_arm_sx1_sd(self): > @@ -54,7 +55,7 @@ def test_arm_sx1_sd(self): > self.vm.add_args('-no-reboot') > self.vm.add_args('-snapshot') > self.vm.add_args('-drive', f'format=raw,if=sd,file={sd_fs_path}') > - self.launch_kernel(zimage_path) > + self.launch_kernel(zimage_path, wait_for='Boot successful') > self.vm.wait(timeout=120) > > def test_arm_sx1_flash(self): > @@ -65,7 +66,7 @@ def test_arm_sx1_flash(self): > self.vm.add_args('-no-reboot') > self.vm.add_args('-snapshot') > self.vm.add_args('-drive', f'format=raw,if=pflash,file={flash_path}') > - self.launch_kernel(zimage_path) > + self.launch_kernel(zimage_path, wait_for='Boot successful') > self.vm.wait(timeout=120) > > if __name__ == '__main__':
diff --git a/MAINTAINERS b/MAINTAINERS index 05ec99adfd0..098daea6f24 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2000,6 +2000,7 @@ S: Maintained F: hw/*/omap* F: include/hw/arm/omap.h F: docs/system/arm/sx1.rst +F: tests/functional/test_arm_sx1.py IPack M: Alberto Garcia <berto@igalia.com> diff --git a/tests/functional/test_arm_sx1.py b/tests/functional/test_arm_sx1.py index 4dd1e1859fa..25800b388c9 100755 --- a/tests/functional/test_arm_sx1.py +++ b/tests/functional/test_arm_sx1.py @@ -43,7 +43,8 @@ def test_arm_sx1_initrd(self): self.vm.add_args('-append', f'kunit.enable=0 rdinit=/sbin/init {self.CONSOLE_ARGS}') self.vm.add_args('-no-reboot') self.launch_kernel(zimage_path, - initrd=initrd_path) + initrd=initrd_path, + wait_for='Boot successful') self.vm.wait(timeout=120) def test_arm_sx1_sd(self): @@ -54,7 +55,7 @@ def test_arm_sx1_sd(self): self.vm.add_args('-no-reboot') self.vm.add_args('-snapshot') self.vm.add_args('-drive', f'format=raw,if=sd,file={sd_fs_path}') - self.launch_kernel(zimage_path) + self.launch_kernel(zimage_path, wait_for='Boot successful') self.vm.wait(timeout=120) def test_arm_sx1_flash(self): @@ -65,7 +66,7 @@ def test_arm_sx1_flash(self): self.vm.add_args('-no-reboot') self.vm.add_args('-snapshot') self.vm.add_args('-drive', f'format=raw,if=pflash,file={flash_path}') - self.launch_kernel(zimage_path) + self.launch_kernel(zimage_path, wait_for='Boot successful') self.vm.wait(timeout=120) if __name__ == '__main__':
The kernel that is used in the sx1 test prints the usual Linux log onto the serial console, but this test currently ignores it. To make sure that the serial device is working properly, let's check for some strings in the output here. While we're at it, also add the test to the corresponding section in the MAINTAINERS file. Signed-off-by: Thomas Huth <thuth@redhat.com> --- Based-on: <20250221140640.786341-1-peter.maydell@linaro.org> MAINTAINERS | 1 + tests/functional/test_arm_sx1.py | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-)