diff mbox series

[v2,6/7] tests/functional: drop unused 'get_tag' method

Message ID 20250228102738.3064045-7-berrange@redhat.com (mailing list archive)
State New, archived
Headers show
Series tests/functional: a few misc cleanups and fixes | expand

Commit Message

Daniel P. Berrangé Feb. 28, 2025, 10:27 a.m. UTC
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/functional/qemu_test/tuxruntest.py | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Thomas Huth March 5, 2025, 9:04 a.m. UTC | #1
On 28/02/2025 11.27, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/functional/qemu_test/tuxruntest.py | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/tests/functional/qemu_test/tuxruntest.py b/tests/functional/qemu_test/tuxruntest.py
> index 41a4945a14..ad74156f9c 100644
> --- a/tests/functional/qemu_test/tuxruntest.py
> +++ b/tests/functional/qemu_test/tuxruntest.py
> @@ -24,17 +24,6 @@ class TuxRunBaselineTest(QemuSystemTest):
>       # Tests are ~10-40s, allow for --debug/--enable-gcov overhead
>       timeout = 100
>   
> -    def get_tag(self, tagname, default=None):
> -        """
> -        Get the metadata tag or return the default.
> -        """
> -        utag = self._get_unique_tag_val(tagname)
> -        print(f"{tagname}/{default} -> {utag}")
> -        if utag:
> -            return utag
> -
> -        return default

A remainder from the avocado days... can be removed now, indeed.

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/functional/qemu_test/tuxruntest.py b/tests/functional/qemu_test/tuxruntest.py
index 41a4945a14..ad74156f9c 100644
--- a/tests/functional/qemu_test/tuxruntest.py
+++ b/tests/functional/qemu_test/tuxruntest.py
@@ -24,17 +24,6 @@  class TuxRunBaselineTest(QemuSystemTest):
     # Tests are ~10-40s, allow for --debug/--enable-gcov overhead
     timeout = 100
 
-    def get_tag(self, tagname, default=None):
-        """
-        Get the metadata tag or return the default.
-        """
-        utag = self._get_unique_tag_val(tagname)
-        print(f"{tagname}/{default} -> {utag}")
-        if utag:
-            return utag
-
-        return default
-
     def setUp(self):
         super().setUp()