Message ID | 20250317142819.900029-9-peter.maydell@linaro.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | target/arm: Remove TYPE_AARCH64_CPU class | expand |
On 17/3/25 15:28, Peter Maydell wrote: > We want to merge TYPE_AARCH64_CPU with TYPE_ARM_CPU, so enforcing in > kvm_arch_init_vcpu() that the CPU class is a subclass of > TYPE_AARCH64_CPU will no longer be possible. > > It's safe to just remove this test, because any purely-AArch32 CPU > will fail the "kvm_target isn't set" check, because we no longer > support the old AArch32-host KVM setup and so CPUs like the Cortex-A7 > no longer set cpu->kvm_target. Only the 'host', 'max', and the > odd special cases 'cortex-a53' and 'cortex-a57' set kvm_target. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/arm/kvm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/target/arm/kvm.c b/target/arm/kvm.c index da30bdbb234..7418eb57537 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1882,8 +1882,7 @@ int kvm_arch_init_vcpu(CPUState *cs) CPUARMState *env = &cpu->env; uint64_t psciver; - if (cpu->kvm_target == QEMU_KVM_ARM_TARGET_NONE || - !object_dynamic_cast(OBJECT(cpu), TYPE_AARCH64_CPU)) { + if (cpu->kvm_target == QEMU_KVM_ARM_TARGET_NONE) { error_report("KVM is not supported for this guest CPU type"); return -EINVAL; }
We want to merge TYPE_AARCH64_CPU with TYPE_ARM_CPU, so enforcing in kvm_arch_init_vcpu() that the CPU class is a subclass of TYPE_AARCH64_CPU will no longer be possible. It's safe to just remove this test, because any purely-AArch32 CPU will fail the "kvm_target isn't set" check, because we no longer support the old AArch32-host KVM setup and so CPUs like the Cortex-A7 no longer set cpu->kvm_target. Only the 'host', 'max', and the odd special cases 'cortex-a53' and 'cortex-a57' set kvm_target. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/kvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)