diff mbox series

docs/system: Use the meson binary from the pyvenv

Message ID 20250318055415.16501-1-thuth@redhat.com (mailing list archive)
State New
Headers show
Series docs/system: Use the meson binary from the pyvenv | expand

Commit Message

Thomas Huth March 18, 2025, 5:54 a.m. UTC
From: Thomas Huth <thuth@redhat.com>

To avoid problems with the meson installation from the host
system, we should always use the meson from our venv instead.
Thus use this in the documentation, too.

While we're at it, also mention that it has to be run from
the build folder (in the igb.rst file; the other two files
were already fine).

Suggested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/system/arm/bananapi_m2u.rst | 2 +-
 docs/system/arm/orangepi.rst     | 2 +-
 docs/system/devices/igb.rst      | 5 +++--
 3 files changed, 5 insertions(+), 4 deletions(-)

Comments

Akihiko Odaki March 18, 2025, 7:36 a.m. UTC | #1
On 2025/03/18 14:54, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> To avoid problems with the meson installation from the host
> system, we should always use the meson from our venv instead.
> Thus use this in the documentation, too.
> 
> While we're at it, also mention that it has to be run from
> the build folder (in the igb.rst file; the other two files
> were already fine).
> 
> Suggested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Niek Linnenbank March 18, 2025, 10:37 p.m. UTC | #2
Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>

On Tue, Mar 18, 2025 at 6:54 AM Thomas Huth <thuth@redhat.com> wrote:

> From: Thomas Huth <thuth@redhat.com>
>
> To avoid problems with the meson installation from the host
> system, we should always use the meson from our venv instead.
> Thus use this in the documentation, too.
>
> While we're at it, also mention that it has to be run from
> the build folder (in the igb.rst file; the other two files
> were already fine).
>
> Suggested-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/system/arm/bananapi_m2u.rst | 2 +-
>  docs/system/arm/orangepi.rst     | 2 +-
>  docs/system/devices/igb.rst      | 5 +++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/docs/system/arm/bananapi_m2u.rst
> b/docs/system/arm/bananapi_m2u.rst
> index d30db8d04c3..6efa222c16f 100644
> --- a/docs/system/arm/bananapi_m2u.rst
> +++ b/docs/system/arm/bananapi_m2u.rst
> @@ -136,4 +136,4 @@ provide the following command:
>
>    $ cd qemu-build-dir
>    $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 \
> -    meson test --suite thorough func-arm-arm_bpim2u
> +    pyvenv/bin/meson test --suite thorough func-arm-arm_bpim2u
> diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
> index 8b9448ca7b0..716062fca9c 100644
> --- a/docs/system/arm/orangepi.rst
> +++ b/docs/system/arm/orangepi.rst
> @@ -262,4 +262,4 @@ provide the following command from the build directory:
>  .. code-block:: bash
>
>    $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 \
> -    meson test --suite thorough func-arm-arm_orangepi
> +    pyvenv/bin/meson test --suite thorough func-arm-arm_orangepi
> diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst
> index 9145af5c757..71f31cb1160 100644
> --- a/docs/system/devices/igb.rst
> +++ b/docs/system/devices/igb.rst
> @@ -57,11 +57,12 @@ directory:
>    meson test qtest-x86_64/qos-test
>
>  ethtool can test register accesses, interrupts, etc. It is automated as an
> -functional test and can be ran with the following command:
> +functional test and can be run from the build directory with the following
> +command:
>
>  .. code:: shell
>
> -  meson test --suite thorough func-x86_64-netdev_ethtool
> +  pyvenv/bin/meson test --suite thorough func-x86_64-netdev_ethtool
>
>  References
>  ==========
> --
> 2.48.1
>
>
diff mbox series

Patch

diff --git a/docs/system/arm/bananapi_m2u.rst b/docs/system/arm/bananapi_m2u.rst
index d30db8d04c3..6efa222c16f 100644
--- a/docs/system/arm/bananapi_m2u.rst
+++ b/docs/system/arm/bananapi_m2u.rst
@@ -136,4 +136,4 @@  provide the following command:
 
   $ cd qemu-build-dir
   $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 \
-    meson test --suite thorough func-arm-arm_bpim2u
+    pyvenv/bin/meson test --suite thorough func-arm-arm_bpim2u
diff --git a/docs/system/arm/orangepi.rst b/docs/system/arm/orangepi.rst
index 8b9448ca7b0..716062fca9c 100644
--- a/docs/system/arm/orangepi.rst
+++ b/docs/system/arm/orangepi.rst
@@ -262,4 +262,4 @@  provide the following command from the build directory:
 .. code-block:: bash
 
   $ QEMU_TEST_ALLOW_LARGE_STORAGE=1 \
-    meson test --suite thorough func-arm-arm_orangepi
+    pyvenv/bin/meson test --suite thorough func-arm-arm_orangepi
diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst
index 9145af5c757..71f31cb1160 100644
--- a/docs/system/devices/igb.rst
+++ b/docs/system/devices/igb.rst
@@ -57,11 +57,12 @@  directory:
   meson test qtest-x86_64/qos-test
 
 ethtool can test register accesses, interrupts, etc. It is automated as an
-functional test and can be ran with the following command:
+functional test and can be run from the build directory with the following
+command:
 
 .. code:: shell
 
-  meson test --suite thorough func-x86_64-netdev_ethtool
+  pyvenv/bin/meson test --suite thorough func-x86_64-netdev_ethtool
 
 References
 ==========