migration: Fix latent bug in migrate_params_test_apply()

Commit Message

Markus Armbruster April 7, 2025, 7:28 a.m. UTC

migrate_params_test_apply() neglects to apply tls_authz.  Currently
harmless, because migrate_params_check() doesn't care.  Fix it anyway.

Signed-off-by: Markus Armbruster <[e-mail]>
---
 migration/options.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Fabiano Rosas April 7, 2025, 12:08 p.m. UTC | #1

Markus Armbruster <[e-mail]> writes:

> migrate_params_test_apply() neglects to apply tls_authz.  Currently
> harmless, because migrate_params_check() doesn't care.  Fix it anyway.
>
> Signed-off-by: Markus Armbruster <[e-mail]>
> ---
>  migration/options.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index b0ac2ea408..cb8eec218f 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
>          dest->tls_hostname = params->tls_hostname->u.s;
>      }
>  
> +    if (params->tls_authz) {
> +        assert(params->tls_authz->type == QTYPE_QSTRING);
> +        dest->tls_authz = params->tls_authz->u.s;
> +    }
> +
>      if (params->has_max_bandwidth) {
>          dest->max_bandwidth = params->max_bandwidth;
>      }

Reviewed-by: Fabiano Rosas <[e-mail]>

Patch

diff --git a/migration/options.c b/migration/options.c
index b0ac2ea408..cb8eec218f 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1193,6 +1193,11 @@  static void migrate_params_test_apply(MigrateSetParameters *params,
         dest->tls_hostname = params->tls_hostname->u.s;
     }
 
+    if (params->tls_authz) {
+        assert(params->tls_authz->type == QTYPE_QSTRING);
+        dest->tls_authz = params->tls_authz->u.s;
+    }
+
     if (params->has_max_bandwidth) {
         dest->max_bandwidth = params->max_bandwidth;
     }