On 4/15/25 12:24, Richard Henderson wrote: > Use this in gen_addc and gen_rsubc, both of which need > add with carry-in and carry-out. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/microblaze/translate.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c > index b54e5ac4b2..31afd3ab5d 100644 > --- a/target/microblaze/translate.c > +++ b/target/microblaze/translate.c > @@ -310,11 +310,7 @@ static void gen_add(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) > /* Input and output carry. */ > static void gen_addc(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) > { > - TCGv_i32 zero = tcg_constant_i32(0); > - TCGv_i32 tmp = tcg_temp_new_i32(); > - > - tcg_gen_add2_i32(tmp, cpu_msr_c, ina, zero, cpu_msr_c, zero); > - tcg_gen_add2_i32(out, cpu_msr_c, tmp, cpu_msr_c, inb, zero); > + tcg_gen_addcio_i32(out, cpu_msr_c, ina, inb, cpu_msr_c); > } > > /* Input carry, but no output carry. */ > @@ -543,12 +539,10 @@ static void gen_rsub(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) > /* Input and output carry. */ > static void gen_rsubc(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) > { > - TCGv_i32 zero = tcg_constant_i32(0); > TCGv_i32 tmp = tcg_temp_new_i32(); > > tcg_gen_not_i32(tmp, ina); > - tcg_gen_add2_i32(tmp, cpu_msr_c, tmp, zero, cpu_msr_c, zero); > - tcg_gen_add2_i32(out, cpu_msr_c, tmp, cpu_msr_c, inb, zero); > + tcg_gen_addcio_i32(out, cpu_msr_c, tmp, inb, cpu_msr_c); > } > > /* No input or output carry. */ Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index b54e5ac4b2..31afd3ab5d 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -310,11 +310,7 @@ static void gen_add(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) /* Input and output carry. */ static void gen_addc(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) { - TCGv_i32 zero = tcg_constant_i32(0); - TCGv_i32 tmp = tcg_temp_new_i32(); - - tcg_gen_add2_i32(tmp, cpu_msr_c, ina, zero, cpu_msr_c, zero); - tcg_gen_add2_i32(out, cpu_msr_c, tmp, cpu_msr_c, inb, zero); + tcg_gen_addcio_i32(out, cpu_msr_c, ina, inb, cpu_msr_c); } /* Input carry, but no output carry. */ @@ -543,12 +539,10 @@ static void gen_rsub(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) /* Input and output carry. */ static void gen_rsubc(TCGv_i32 out, TCGv_i32 ina, TCGv_i32 inb) { - TCGv_i32 zero = tcg_constant_i32(0); TCGv_i32 tmp = tcg_temp_new_i32(); tcg_gen_not_i32(tmp, ina); - tcg_gen_add2_i32(tmp, cpu_msr_c, tmp, zero, cpu_msr_c, zero); - tcg_gen_add2_i32(out, cpu_msr_c, tmp, cpu_msr_c, inb, zero); + tcg_gen_addcio_i32(out, cpu_msr_c, tmp, inb, cpu_msr_c); } /* No input or output carry. */
Use this in gen_addc and gen_rsubc, both of which need add with carry-in and carry-out. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/microblaze/translate.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)