From patchwork Fri Mar 9 16:12:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 10271097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 19A5F605CE for ; Fri, 9 Mar 2018 16:14:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1013029EB0 for ; Fri, 9 Mar 2018 16:14:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0EABF29EF8; Fri, 9 Mar 2018 16:14:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, NORMAL_HTTP_TO_IP, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3798329F21 for ; Fri, 9 Mar 2018 16:13:00 +0000 (UTC) Received: from localhost ([::1]:46215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKdf-0005Ay-BL for patchwork-qemu-devel@patchwork.kernel.org; Fri, 09 Mar 2018 11:12:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKd5-0004qB-Sz for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:12:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euKd1-0002yb-EG for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:12:23 -0500 Received: from smtp.citrix.com ([66.165.176.89]:57590) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1euKd1-0002yE-5S for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:12:19 -0500 X-IronPort-AV: E=Sophos;i="5.47,446,1515456000"; d="scan'208";a="467278949" From: Ian Jackson MIME-Version: 1.0 Message-ID: <23202.45661.318179.372531@mariner.uk.xensource.com> Date: Fri, 9 Mar 2018 16:12:13 +0000 To: Anthony PERARD In-Reply-To: <20180309154431.GJ1921@perard.uk.xensource.com> References: <1520535787-6223-1-git-send-email-ian.jackson@eu.citrix.com> <1520535787-6223-11-git-send-email-ian.jackson@eu.citrix.com> <20180309154431.GJ1921@perard.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Subject: Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Ross Lagerwall , Stefano Stabellini , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"): > This patch seems to remove the last users of > xen_xc_domain_add_to_physmap(). Can it be remove from xen_common.h? > > With that: > Acked-by: Anthony PERARD Have added a separate patch for that. From 15dedc627cad96301e4015f1f777fcab3906aba7 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Fri, 27 Oct 2017 11:23:10 +0100 Subject: [PATCH 5/5] scripts/get_maintainer.pl: Print proper error message for missing $file If you pass scripts/get_maintainer.pl the name of a FIFO or other exciting object (/dev/stdin, for example), it would falsely print "file not found". Instead: stat the object rather than using -f so that we do not mind if the object is not a file; and print the errno value in the error message. Signed-off-by: Ian Jackson CC: Thomas Huth CC: Paolo Bonzini CC: Stefano Stabellini CC: Anthony PERARD --- v6: New patch in this version of the series --- scripts/get_maintainer.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 07369aa..43fb5f5 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -381,8 +381,8 @@ foreach my $file (@ARGV) { ##if $file is a directory and it lacks a trailing slash, add one if ((-d $file)) { $file =~ s@([^/])$@$1/@; - } elsif (!(-f $file)) { - die "$P: file '${file}' not found\n"; + } elsif (!(stat $file)) { + die "$P: file '${file}' not found: $!\n"; } } if ($from_filename) {