From patchwork Fri Mar 9 16:13:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 10271101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C9AE4603B5 for ; Fri, 9 Mar 2018 16:14:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE5A129A88 for ; Fri, 9 Mar 2018 16:14:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B12AB29AAA; Fri, 9 Mar 2018 16:14:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 746E329A88 for ; Fri, 9 Mar 2018 16:14:55 +0000 (UTC) Received: from localhost ([::1]:46224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKfV-0006M1-Tt for patchwork-qemu-devel@patchwork.kernel.org; Fri, 09 Mar 2018 11:14:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKeH-0005ZJ-LK for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:13:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euKeE-0003aP-QB for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:13:37 -0500 Received: from smtp.citrix.com ([66.165.176.89]:30309) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1euKeE-0003Zt-Eu for qemu-devel@nongnu.org; Fri, 09 Mar 2018 11:13:34 -0500 X-IronPort-AV: E=Sophos;i="5.47,446,1515456000"; d="scan'208";a="467279232" From: Ian Jackson MIME-Version: 1.0 Message-ID: <23202.45739.128643.206532@mariner.uk.xensource.com> Date: Fri, 9 Mar 2018 16:13:31 +0000 To: Anthony PERARD , , Ross Lagerwall , Juergen Gross , Stefano Stabellini , In-Reply-To: <23202.45661.318179.372531@mariner.uk.xensource.com> References: <1520535787-6223-1-git-send-email-ian.jackson@eu.citrix.com> <1520535787-6223-11-git-send-email-ian.jackson@eu.citrix.com> <20180309154431.GJ1921@perard.uk.xensource.com> <23202.45661.318179.372531@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.4.1 (i586-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Subject: Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Ian Jackson writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"): > Anthony PERARD writes ("Re: [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory"): > > This patch seems to remove the last users of > > xen_xc_domain_add_to_physmap(). Can it be remove from xen_common.h? > > > > With that: > > Acked-by: Anthony PERARD > > Have added a separate patch for that. Wrong patch. Gah! From 8794b90b82612665d1e3f9f96ab73579a271c3be Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Fri, 9 Mar 2018 16:08:55 +0000 Subject: [PATCH 3/5] xen: Remove now-obsolete xen_xc_domain_add_to_physmap The last user was just removed; remove this function, accordingly. Signed-off-by: Ian Jackson --- include/hw/xen/xen_common.h | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 2eed6fc..5f1402b 100644 --- a/include/hw/xen/xen_common.h +++ b/include/hw/xen/xen_common.h @@ -645,28 +645,6 @@ static inline int xen_set_ioreq_server_state(domid_t dom, #endif -#if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40600 -static inline int xen_xc_domain_add_to_physmap(xc_interface *xch, uint32_t domid, - unsigned int space, - unsigned long idx, - xen_pfn_t gpfn) -{ - return xc_domain_add_to_physmap(xch, domid, space, idx, gpfn); -} -#else -static inline int xen_xc_domain_add_to_physmap(xc_interface *xch, uint32_t domid, - unsigned int space, - unsigned long idx, - xen_pfn_t gpfn) -{ - /* In Xen 4.6 rc is -1 and errno contains the error value. */ - int rc = xc_domain_add_to_physmap(xch, domid, space, idx, gpfn); - if (rc == -1) - return errno; - return rc; -} -#endif - #ifdef CONFIG_XEN_PV_DOMAIN_BUILD #if CONFIG_XEN_CTRL_INTERFACE_VERSION < 40700 static inline int xen_domain_create(xc_interface *xc, uint32_t ssidref,