From patchwork Sun Apr 1 21:17:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 10319329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 327CF60375 for ; Sun, 1 Apr 2018 21:19:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11CE3286E4 for ; Sun, 1 Apr 2018 21:19:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4FB928BBF; Sun, 1 Apr 2018 21:19:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2978D286E4 for ; Sun, 1 Apr 2018 21:19:14 +0000 (UTC) Received: from localhost ([::1]:35984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2kNd-0002GQ-Ua for patchwork-qemu-devel@patchwork.kernel.org; Sun, 01 Apr 2018 17:19:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2kMS-0001OE-9G for qemu-devel@nongnu.org; Sun, 01 Apr 2018 17:18:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2kMP-00061Y-Rq for qemu-devel@nongnu.org; Sun, 01 Apr 2018 17:18:00 -0400 Received: from mout.web.de ([212.227.15.14]:42831) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2kMP-00060y-GW for qemu-devel@nongnu.org; Sun, 01 Apr 2018 17:17:57 -0400 Received: from [192.168.2.11] ([92.76.39.170]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LaZQd-1eg5Km3dXj-00mJXP; Sun, 01 Apr 2018 23:17:56 +0200 To: Dmitry Fleytman , qemu-devel From: Jan Kiszka Openpgp: preference=signencrypt Message-ID: <267f42a5-b7ce-379e-ffd1-f2611393d2ff@web.de> Date: Sun, 1 Apr 2018 23:17:55 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K0:gNHsAde5N+6/mKYD2aFjZQ5ZVdEIDuKiMNkhug1B76jdNJu1Aqy qOzkiL2WcuGGgVV9Rt4CNoqMjG/gssUW2qIXQJQKV12zRsGvJI9iUWmco8jR+6ij2Yb/KtZ XhIKG8NdIA5MKSfmvN8MhSB21908QJ8pWMRZTMtsEUbwt/wy/HpSQtTWCTYOKjY13atrmI9 tzGDs/bqT43bq7Ok3FoLQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:kkI9lwP8sEg=:MD6XOvI7ve+OOsee9d0pqN DExuT4/lT3GmtGkgMuIomQdCEliBvVp4ihzkO42nIiw1v6qSPWcOa0TfGqZ2CDTq4cqqJQCCP lp5eNJfpEU6jN/r7eTBT8rdecVp4vqch13Tk9j+dM9+6Yod8Zohlx2fCNuyALO+nPKJjcKbvx DiiTvpkD9LAbnYGaPYkTgmLa8IWfFhQ/7O+Sv6hSR0Gv3B0P3BE06D6h03JXbFC+9mnu8sGMG 6eyZ795Hw9gZLq8PikGnRelUIH3jSAgLwctB99P2gGRQMhVJjTM3TVnLYDOt+Z/nPCmqdzMoM s1vBh2qqd/aFwuYVpqxdH8pJb4qJTNizY0DmLjpbHruDh8bzpwKE+podA2y30tIVMyFmKYQrb CLDq4gC2yYsD0KYFszqF/j766CEbVnzAdw2nrdig06wrcMM03TeIbyLaqylv5xcRgqAklm7AE TPSzyk97rxjVcXHyucs6Ey5drLd705EeYHjN55ojS8DEpFdWTDEvvzmFsqGGRXsCy+T/CwdpB net6EYByPQHExWrc/WJPhitodqzUFE08Abxeh7hzN24ehnuwBSf0Vjycx+4XtYmZSx0awBlEb Dc7ZXmLp6Vp/MZbAmvXquzs6pQ83R7DfbZqPSJn2xdiUnihKl75CFoy0M0ak6qF9ykBS/4Fc3 o2LAZeinD7XX73o2miAW/G8p4vFoKv5/7H/ENaddWUCZujFeKMrzoBmtZV2Ezx2r3uZtBPgLj vB+pHsCm30ljx83CckpyrIojdtShlTSpy/dy5pWvt3ZcC1pDfVy+BeQt3Jyx4yLAezlnCeYt0 iAO7xxrY4EDGMPLJOkv/aMFfA3KAqIkfG070OZjte1AHKY2jgM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.14 Subject: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Jan Kiszka The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") and was worked around by 745d0bd3af99 ("e1000e: Remove Other from EIAC"). Signed-off-by: Jan Kiszka --- This resolves the issue I reported on February 18 ("e1000e: MSI-X problem with recent Linux drivers"). hw/net/e1000e_core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index ecf9b15555..d38f025c0f 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2022,10 +2022,6 @@ e1000e_msix_notify_one(E1000ECore *core, uint32_t cause, uint32_t int_cfg) effective_eiac = core->mac[EIAC] & cause; - if (effective_eiac == E1000_ICR_OTHER) { - effective_eiac |= E1000_ICR_OTHER_CAUSES; - } - core->mac[ICR] &= ~effective_eiac; if (!(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) {