From patchwork Thu Nov 17 16:00:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirti Wankhede X-Patchwork-Id: 9434561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4974A6047D for ; Thu, 17 Nov 2016 16:21:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33136295E4 for ; Thu, 17 Nov 2016 16:21:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27D482961B; Thu, 17 Nov 2016 16:21:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9E440295E4 for ; Thu, 17 Nov 2016 16:21:08 +0000 (UTC) Received: from localhost ([::1]:60038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7PQx-0006Mh-Sm for patchwork-qemu-devel@patchwork.kernel.org; Thu, 17 Nov 2016 11:21:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7P7I-00079P-4p for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:00:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7P7D-00078E-4A for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:00:48 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:9900) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7P7C-00077r-JL for qemu-devel@nongnu.org; Thu, 17 Nov 2016 11:00:43 -0500 Received: from hqnvupgp07.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com id ; Thu, 17 Nov 2016 08:00:40 -0800 Received: from HQMAIL101.nvidia.com ([172.20.13.39]) by hqnvupgp07.nvidia.com (PGP Universal service); Wed, 16 Nov 2016 19:59:35 -0800 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 16 Nov 2016 19:59:35 -0800 Received: from BGMAIL102.nvidia.com (10.25.59.11) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 17 Nov 2016 16:00:39 +0000 Received: from [10.24.70.155] (10.24.70.155) by bgmail102.nvidia.com (10.25.59.11) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 17 Nov 2016 16:00:33 +0000 To: Alex Williamson , Jike Song References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com> <1479329194-10247-13-git-send-email-kwankhede@nvidia.com> <582DA41A.7010204@intel.com> <20161117082737.7f6ff329@t450s.home> X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <27bfa26c-4d57-7f64-a489-f3d341d00fea@nvidia.com> Date: Thu, 17 Nov 2016 21:30:26 +0530 MIME-Version: 1.0 In-Reply-To: <20161117082737.7f6ff329@t450s.home> X-Originating-IP: [10.24.70.155] X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com (10.25.59.11) X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 X-Received-From: 216.228.121.65 Subject: Re: [Qemu-devel] [PATCH v14 12/22] vfio: Add notifier callback to parent's ops structure of mdev X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kevin.tian@intel.com, cjia@nvidia.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, kraxel@redhat.com, pbonzini@redhat.com, bjsdjshi@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 11/17/2016 8:57 PM, Alex Williamson wrote: > On Thu, 17 Nov 2016 20:35:38 +0800 > Jike Song wrote: > >> On 11/17/2016 04:46 AM, Kirti Wankhede wrote: >>> Add a notifier calback to parent's ops structure of mdev device so that per >>> device notifer for vfio module is registered through vfio_mdev module. >>> >>> Signed-off-by: Kirti Wankhede >>> Signed-off-by: Neo Jia >>> Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 >>> --- >>> drivers/vfio/mdev/vfio_mdev.c | 34 +++++++++++++++++++++++++++++++++- >>> include/linux/mdev.h | 9 +++++++++ >>> 2 files changed, 42 insertions(+), 1 deletion(-) >>> >> >> Hi Alex, Kirti, >> >> Since everyone agreed we should let the vendor driver call vfio_register_notifier >> directly, can you drop this patch from merging? So that I don't need to send a >> reverse patch. > > This seems like a reasonable request to me, this patch drops cleanly > from the series. Any objection Kirti? It seems like it removes a > little bit of pre-release churn from the API. Thanks, > This is independent patch, I don't have any concern to drop this patch. Small nit: Since Documentation patch is later in series, its mentioned in the doc. One line need to be removed from vfio-mediated-device.txt. Kirti --- a/Documentation/vfio-mediated-device.txt +++ b/Documentation/vfio-mediated-device.txt @@ -150,7 +150,6 @@ The callbacks in the parent_ops structure are as follows: * read : read emulation callback * write: write emulation callback * mmap: mmap emulation callback -* notifier: notifier callback Thanks,