[RFC,v2,64/78] hw/mips: add fallthrough pseudo-keyword

Commit Message

Manos Pitsidianakis Oct. 13, 2023, 7:57 a.m. UTC

In preparation of raising -Wimplicit-fallthrough to 5, replace all
fall-through comments with the fallthrough attribute pseudo-keyword.

Signed-off-by: Emmanouil Pitsidianakis <[e-mail]>
---
 hw/mips/boston.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Patch

diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 4e11ff6cd6..4ca53b790a 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -164,27 +164,27 @@  static void boston_lcd_event(void *opaque, QEMUChrEvent event)
 static uint64_t boston_lcd_read(void *opaque, hwaddr addr,
                                 unsigned size)
 {
     BostonState *s = opaque;
     uint64_t val = 0;
 
     switch (size) {
     case 8:
         val |= (uint64_t)s->lcd_content[(addr + 7) & 0x7] << 56;
         val |= (uint64_t)s->lcd_content[(addr + 6) & 0x7] << 48;
         val |= (uint64_t)s->lcd_content[(addr + 5) & 0x7] << 40;
         val |= (uint64_t)s->lcd_content[(addr + 4) & 0x7] << 32;
-        /* fall through */
+        fallthrough;
     case 4:
         val |= (uint64_t)s->lcd_content[(addr + 3) & 0x7] << 24;
         val |= (uint64_t)s->lcd_content[(addr + 2) & 0x7] << 16;
-        /* fall through */
+        fallthrough;
     case 2:
         val |= (uint64_t)s->lcd_content[(addr + 1) & 0x7] << 8;
-        /* fall through */
+        fallthrough;
     case 1:
         val |= (uint64_t)s->lcd_content[(addr + 0) & 0x7];
         break;
     }
 
     return val;
 }
@@ -192,27 +192,27 @@  static uint64_t boston_lcd_read(void *opaque, hwaddr addr,
 static void boston_lcd_write(void *opaque, hwaddr addr,
                              uint64_t val, unsigned size)
 {
     BostonState *s = opaque;
 
     switch (size) {
     case 8:
         s->lcd_content[(addr + 7) & 0x7] = val >> 56;
         s->lcd_content[(addr + 6) & 0x7] = val >> 48;
         s->lcd_content[(addr + 5) & 0x7] = val >> 40;
         s->lcd_content[(addr + 4) & 0x7] = val >> 32;
-        /* fall through */
+        fallthrough;
     case 4:
         s->lcd_content[(addr + 3) & 0x7] = val >> 24;
         s->lcd_content[(addr + 2) & 0x7] = val >> 16;
-        /* fall through */
+        fallthrough;
     case 2:
         s->lcd_content[(addr + 1) & 0x7] = val >> 8;
-        /* fall through */
+        fallthrough;
     case 1:
         s->lcd_content[(addr + 0) & 0x7] = val;
         break;
     }
 
     qemu_chr_fe_printf(&s->lcd_display,
                        "\r%-8.8s", s->lcd_content);
 }