From patchwork Mon Feb 8 09:08:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8247071 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E1DE99F6DA for ; Mon, 8 Feb 2016 09:08:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3D9EF201D3 for ; Mon, 8 Feb 2016 09:08:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92EB2201C0 for ; Mon, 8 Feb 2016 09:08:34 +0000 (UTC) Received: from localhost ([::1]:42672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSho9-0002CD-V6 for patchwork-qemu-devel@patchwork.kernel.org; Mon, 08 Feb 2016 04:08:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSho3-0002Bs-UT for qemu-devel@nongnu.org; Mon, 08 Feb 2016 04:08:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aShny-0003VF-Ui for qemu-devel@nongnu.org; Mon, 08 Feb 2016 04:08:27 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:33782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aShny-0003VB-Ms for qemu-devel@nongnu.org; Mon, 08 Feb 2016 04:08:22 -0500 Received: by mail-wm0-x232.google.com with SMTP id g62so123391477wme.0 for ; Mon, 08 Feb 2016 01:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=vE/xLLON+VY7zuJhWRc0a9YmH1llX12DbaQgAUJRLPo=; b=JvEju7rjTGlg1upoxIc4NvPZQkJjWVKHlErbuFC2FLh9nIW7xEREFZVmHsjtLkVXXb J3wfRDjDLurErfpJGuGvaV90uuf0dto0cgpVZ/cFjOxszla5+SN4Rw+9+VhOd68FPdyn mkjkH2MaWa4xmYv+XGLOc+EAglsnplOYSKoQAxXrKZBzEC6tzbyXm3ZCrQTWe1oFkTd0 4QyoTw/Typ9JfHO1ftG9Nf/UFK7N7o6yawlU0A0NnaJ1GXPwQhhmtAId/uYZFYCwm+bl 4icPT0ZF0YMcmKKZmnz6G1kckWwRKlgOeds5JOKQGqk2EeH/Xx0uzsF0BFt4RLJFWuGi HVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=vE/xLLON+VY7zuJhWRc0a9YmH1llX12DbaQgAUJRLPo=; b=hhEtqnoLAX4ZiAjE7jObNjNk9WIH8gWte/aeQH3J2xtsRim20pWD42UAg8dNxVYrft RIyRw2yFz3FeOVfb4TMb188sewNsx3ePw79MlGlG70EHppGQXbOuOhiVnFZ+g0OZZzRP SB2Xxk7kwjUfJTVXHo/EiTRe/Xg+XDuzUKpaqprcEg73ufmnAuVUIc+WwIk1Nt2hkox0 7lUGOrBsputgLLTG0FLrUu1kvdMDULgdrqq2JTixItZ66PlC7TT5Yo9GGNAgRfYKiNDR mDtGPLfRDEs0cyzADkFUgrFwtyQTMwxp/ANLI7o9fIxB0ht3R6wiCUEZUi+3C+SF98BO G6lQ== X-Gm-Message-State: AG10YOSeZVJ+tql64u0VtptpXhNdj4Y+S4pWMWmhnPN3ncOGsZoDDH4T0sycQl1aRIXHwA== X-Received: by 10.28.132.212 with SMTP id g203mr6246168wmd.30.1454922501848; Mon, 08 Feb 2016 01:08:21 -0800 (PST) Received: from [192.168.10.165] (94-39-141-130.adsl-ull.clienti.tiscali.it. [94.39.141.130]) by smtp.googlemail.com with ESMTPSA id 73sm11648382wmm.7.2016.02.08.01.08.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Feb 2016 01:08:21 -0800 (PST) To: Mark Cave-Ayland , Peter Maydell References: <56AE260C.9020508@ilande.co.uk> <56AE2E1B.6030106@ilande.co.uk> From: Paolo Bonzini Message-ID: <56B85AFC.3070604@redhat.com> Date: Mon, 8 Feb 2016 10:08:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56AE2E1B.6030106@ilande.co.uk> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::232 Cc: qemu-devel Subject: Re: [Qemu-devel] Strange monitor/stdout issue on qemu-system-sparc/qemu-system-ppc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 31/01/2016 16:54, Mark Cave-Ayland wrote: > Aha! A quick test here shows that the patch fixes the serial port > appearing on stdout and entering the monitor, but I still see the > multiple echo problem in the GTK GUI. And this should be it; if this fixes all your problems I will submit it for inclusion. Thanks, Paolo ----------------- 8< --------------- From: Paolo Bonzini Subject: [PATCH] gtk: fix uninitialized temporary VirtualConsole Only the echo field is used in the temporary VirtualConsole, so the damage was limited. But still, if echo was incorrectly set to true, the result would be some puzzling output in VTE monitor and serial consoles. Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd Signed-off-by: Paolo Bonzini diff --git a/ui/gtk.c b/ui/gtk.c index c8dbd5c..e106493 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1612,7 +1612,7 @@ static CharDriverState *gd_vc_handler(ChardevVC *vc, Error **errp) chr->chr_set_echo = gd_vc_chr_set_echo; /* Temporary, until gd_vc_vte_init runs. */ - chr->opaque = g_new(VirtualConsole, 1); + chr->opaque = g_new0(VirtualConsole, 1); /* defer OPENED events until our vc is fully initialized */ chr->explicit_be_open = true;