From patchwork Mon Feb 8 19:56:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8254401 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1AD9E9F3CD for ; Mon, 8 Feb 2016 19:56:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D9CC3203B7 for ; Mon, 8 Feb 2016 19:56:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D27A203AD for ; Mon, 8 Feb 2016 19:56:20 +0000 (UTC) Received: from localhost ([::1]:48287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSrv1-0000Qq-JK for patchwork-qemu-devel@patchwork.kernel.org; Mon, 08 Feb 2016 14:56:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSrut-0000P8-I7 for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSrup-0003HA-Ch for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:11 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSruo-0003H3-Vl for qemu-devel@nongnu.org; Mon, 08 Feb 2016 14:56:07 -0500 Received: by mail-wm0-x22d.google.com with SMTP id g62so131886831wme.0 for ; Mon, 08 Feb 2016 11:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=HoxG4EfVWdR/XP0qTm9bM9/HUtMWg+4k2gHk65Wxp3A=; b=aIKI1T3xfprU954pcrK8DiQOtvMcKKAAdO8NjHcotdoU+pFcQYjsAOASNSBL8aFIwM UGZVTJSHE9c3ZBilzLSaagUBUVFh12iP72pXOANN+6eVGiKaPxV6OTFY8fNGOhKQJfqZ I2fCGZnl262CT74N5GxZ9rWSxupWusb26z5xoIVgENYZvx454CbHP8/2BeF0FVQbL83D tDpYZ42feP/CbvXGuIv+eXOl1lRDbBzkPDaRYgiY0GGutIEy4/E1L3F9htzKW2hzEOFY WhcnuHXshmPW/rUSarJeye2XBVTTcnfhq1jSkrVM3RsGZgAqOsmMW2HVCd4oTa8gpfPU 2jOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=HoxG4EfVWdR/XP0qTm9bM9/HUtMWg+4k2gHk65Wxp3A=; b=ZSze4pFkbkEtD818YYBTytyLAeoQnaGhZhTCNYynYLmBIlHdt8IHYikBjKk07ZWAYX fJANn7mKPMczH2pZss3PRYtjGp8uiqk6EjGakyx5ewr1BkdV+fmC3tCMD8STUBtvRJFw Y4QX3CvqiEPCv9f7YoXiURrvWEeX7lSFNQBHstQ56Yi+3ak9aJ/YhsWoinW0HwqCXzsn aIvTtDiocTZ8qjSDF2no5bIDwji0lbWvDhvKY3cF7j9ve0vzyK0vpD+nuYh1xRUC/way kaixHJuPXLPCntuOTLLnyNIgcl9cJcq1C0PB3/W+5hg9cYjzXVjrjA98vcWXjqt6Td3K qCFg== X-Gm-Message-State: AG10YORNL61euSMigoLGa28+Qd4LJqNxteR0X4OBkEkO+cKJxke1jPeF4TFKzVVCyUlQtw== X-Received: by 10.28.186.10 with SMTP id k10mr506840wmf.99.1454961366187; Mon, 08 Feb 2016 11:56:06 -0800 (PST) Received: from [192.168.10.150] (94-39-141-130.adsl-ull.clienti.tiscali.it. [94.39.141.130]) by smtp.googlemail.com with ESMTPSA id t205sm14117881wmt.23.2016.02.08.11.56.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Feb 2016 11:56:04 -0800 (PST) To: Peter Maydell , Stephen Warren References: <1454865729-5791-1-git-send-email-swarren@wwwdotorg.org> <87h9hj7etf.fsf@blackfin.pond.sub.org> <56B8E3F5.3020108@redhat.com> <56B8E6A8.8080506@wwwdotorg.org> From: Paolo Bonzini Message-ID: <56B8F2D2.707@redhat.com> Date: Mon, 8 Feb 2016 20:56:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22d Cc: John Snow , Markus Armbruster , QEMU Developers Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/02/2016 20:15, Peter Maydell wrote: > That difference from the kernel script's behaviour is deliberate, because > the attempt to list recent contributors tends to list a whole lot of > irrelevant people. So if there's a documented maintainer we prefer to > just list them, and not all the random other people looking at the git > logs drags up. Commit c6561586f0f8586 is where we changed the behaviour > of get_maintainer.pl and the commit message has some rationale. It should be enough not to check @list_to in the line that commit c6561586f0f8586 adds: I think this makes sense. Paolo diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 7dacf32..f2ee9d8 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -636,7 +636,7 @@ sub get_maintainers { if ($email) { if (! $interactive) { - $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame; + $email_git_fallback = 0 if @email_to > 0 || $email_git || $email_git_blame; if ($email_git_fallback) { print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n"; print STDERR "get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.\n";