From patchwork Tue Mar 29 13:50:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 8687341 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B4B8AC0553 for ; Tue, 29 Mar 2016 13:50:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D0E120154 for ; Tue, 29 Mar 2016 13:50:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CBFB2014A for ; Tue, 29 Mar 2016 13:50:28 +0000 (UTC) Received: from localhost ([::1]:47087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku2N-0005rV-ME for patchwork-qemu-devel@patchwork.kernel.org; Tue, 29 Mar 2016 09:50:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku27-0005iw-L2 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aku22-0005J7-18 for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aku21-0005Iq-RZ for qemu-devel@nongnu.org; Tue, 29 Mar 2016 09:50:05 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 6D1D685A02; Tue, 29 Mar 2016 13:50:05 +0000 (UTC) Received: from [10.36.112.63] (ovpn-112-63.ams2.redhat.com [10.36.112.63]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2TDo0G8032255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 Mar 2016 09:50:02 -0400 To: Cornelia Huck , tu bo References: <1458836125-73613-1-git-send-email-cornelia.huck@de.ibm.com> <56F8AB31.1090107@linux.vnet.ibm.com> <56F973E7.5070704@redhat.com> <56FA476D.1030107@linux.vnet.ibm.com> <20160329134546.7226abac.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: <56FA8808.8050101@redhat.com> Date: Tue, 29 Mar 2016 15:50:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160329134546.7226abac.cornelia.huck@de.ibm.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: borntraeger@de.ibm.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: refactor host notifiers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 29/03/2016 13:45, Cornelia Huck wrote: > > > Hi Tu Bo, > > > > > > please always include the assertion patch at > > > https://lists.gnu.org/archive/html/qemu-block/2016-03/msg00546.html in > > > your tests. Can you include the backtrace from all threads with that patch? > > > > > thanks for your reminder about the assertion patch. Here is the > > backtrace with qemu master + assertion patch + "[PATCH 0/6] virtio: > > refactor host notifiers", > > FWIW, I've been running this in a reboot loop for the last 2 1/2 hours. > Could you perhaps share your command line? From code inspection, the following is also necessary or at least a good idea: diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 6fb29e3..7fa8477 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -258,7 +258,7 @@ void virtio_blk_data_plane_stop(VirtIOBlockDataPlane *s) aio_context_acquire(s->ctx); /* Stop notifications for new requests from guest */ - virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, false, false); + virtio_queue_aio_set_host_notifier_handler(s->vq, s->ctx, true, false); /* Drain and switch bs back to the QEMU main loop */ blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context());