From patchwork Sun Jun 19 00:11:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy Pearson X-Patchwork-Id: 9185907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C27056075E for ; Sun, 19 Jun 2016 00:11:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B450E21C9A for ; Sun, 19 Jun 2016 00:11:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A93C627AC2; Sun, 19 Jun 2016 00:11:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4125A21C9A for ; Sun, 19 Jun 2016 00:11:52 +0000 (UTC) Received: from localhost ([::1]:36864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEQL9-0005Jm-Bq for patchwork-qemu-devel@patchwork.kernel.org; Sat, 18 Jun 2016 20:11:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEQKa-0005J8-4j for qemu-devel@nongnu.org; Sat, 18 Jun 2016 20:11:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEQKW-0003l0-N4 for qemu-devel@nongnu.org; Sat, 18 Jun 2016 20:11:15 -0400 Received: from pearsoncomputing.net ([192.119.205.242]:56915 helo=mail.pearsoncomputing.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEQKW-0003kv-Eq for qemu-devel@nongnu.org; Sat, 18 Jun 2016 20:11:12 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.pearsoncomputing.net (Postfix) with ESMTP id 3CAFE640DFB for ; Sat, 18 Jun 2016 19:11:12 -0500 (CDT) Received: from mail.pearsoncomputing.net ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3L2SKyf2PN1w for ; Sat, 18 Jun 2016 19:11:11 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.pearsoncomputing.net (Postfix) with ESMTP id A4AC5640E6F for ; Sat, 18 Jun 2016 19:11:11 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.pearsoncomputing.net A4AC5640E6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1466295071; bh=8zrSvldrdeTxxXcBLFxCVxkSgRTgL4pJX5WI81a+zj8=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type: Content-Transfer-Encoding; b=tj+ziJTLEDeC5Scx3CdRP9qaucGkrp37aw+MLFv91VPqJOGdGU/prqzhiihmcKe4P sf6UtCvpV9OLC2omb7/1Bx+91g01WX2qnTdoleeSXqD9kw2B2zqxKeiaV4UOXBi29i Z+8yGxsVWRTdIoNf85Jnk1qU6C9W4FkOrRQxRUOo= X-Virus-Scanned: amavisd-new at pearsoncomputing.net Received: from mail.pearsoncomputing.net ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KqrH58xbeWEY for ; Sat, 18 Jun 2016 19:11:11 -0500 (CDT) Received: from [192.168.3.54] (apollo.starlink.edu [192.168.3.54]) by mail.pearsoncomputing.net (Postfix) with ESMTP id 77BE1640DFB for ; Sat, 18 Jun 2016 19:11:11 -0500 (CDT) Message-ID: <5765E31F.2060806@raptorengineeringinc.com> Date: Sat, 18 Jun 2016 19:11:11 -0500 From: Timothy Pearson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100922 Thunderbird/3.1.4 MIME-Version: 1.0 To: qemu-devel@nongnu.org X-Enigmail-Version: 1.1.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.119.205.242 Subject: [Qemu-devel] [PATCH 2/7] QEMU does not currently support host pages that are larger than guest pages, likely due to glibc using fixed mmap requests. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Attempting to use host pages larger than the guest leads to alignment errors during ELF load in the best case, and an initialization failure inside NPTL in the worst case, causing all fork() requests inside the guest to fail. Warn when thread space cannot be set up, and suggest reducing host page size if applicable. Signed-off-by: Timothy Pearson --- linux-user/syscall.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) } else { ret = -1; } @@ -5514,10 +5519,20 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp, (not implemented) or having *_tidptr to point at a shared memory mapping. We can't repeat the spinlock hack used above because the child process gets its own copy of the lock. */ - if (flags & CLONE_CHILD_SETTID) - put_user_u32(gettid(), child_tidptr); - if (flags & CLONE_PARENT_SETTID) - put_user_u32(gettid(), parent_tidptr); + if (flags & CLONE_CHILD_SETTID) { + if (put_user_u32(gettid(), child_tidptr)) { + fprintf(stderr, "do_fork: put_user_u32() failed, child process state invalid\n"); + if (qemu_real_host_page_size > TARGET_PAGE_SIZE) + fprintf(stderr, "do_fork: host page size > target page size; reduce host page size and try again\n"); + } + } + if (flags & CLONE_PARENT_SETTID) { + if (put_user_u32(gettid(), parent_tidptr)) { + fprintf(stderr, "do_fork: put_user_u32() failed, child process state invalid\n"); + if (qemu_real_host_page_size > TARGET_PAGE_SIZE) + fprintf(stderr, "do_fork: host page size > target page size; reduce host page size and try again\n"); + } + } ts = (TaskState *)cpu->opaque; if (flags & CLONE_SETTLS) cpu_set_tls (env, newtls); diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1c17b74..2968b57 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5482,8 +5482,13 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp, /* Wait for the child to initialize. */ pthread_cond_wait(&info.cond, &info.mutex); ret = info.tid; - if (flags & CLONE_PARENT_SETTID) - put_user_u32(ret, parent_tidptr); + if (flags & CLONE_PARENT_SETTID) { + if (put_user_u32(ret, parent_tidptr)) { + fprintf(stderr, "do_fork: put_user_u32() failed, child process state invalid\n"); + if (qemu_real_host_page_size > TARGET_PAGE_SIZE) + fprintf(stderr, "do_fork: host page size > target page size; reduce host page size and try again\n"); + } + }