From patchwork Wed Jun 22 13:17:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Denis V. Lunev" X-Patchwork-Id: 9192901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B0C72601C0 for ; Wed, 22 Jun 2016 13:28:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A04C7283E9 for ; Wed, 22 Jun 2016 13:28:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 94E6928400; Wed, 22 Jun 2016 13:28:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C8DE5283E9 for ; Wed, 22 Jun 2016 13:28:36 +0000 (UTC) Received: from localhost ([::1]:58335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiCp-0006kz-I0 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jun 2016 09:28:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFi2m-00033H-R9 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFi2k-0005Xf-JS for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:18:11 -0400 Received: from mail-am1on0142.outbound.protection.outlook.com ([157.56.112.142]:42219 helo=emea01-am1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFi2e-0005WA-IY; Wed, 22 Jun 2016 09:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1Blaekrl8T8kjgDJyqdHYkfcicu90afoE7EnxapQxiw=; b=BHfVMrVHgxRvJ0LxGSWPDx6Tt0Q0m31k0hNb6CMT/jd7u1L/o8NPLmC521kCnZC7e6meslxhddOxBadvPnquW2FQGPQeAPIqXWwR+QDvNvDgIoVLYeDH5dI0hMKzeJ0j4YjFHRuIy2DByDYjDvgD2gv97YgMlwUPb24R9DIpVu0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=den@virtuozzo.com; Received: from [10.24.38.119] (195.214.232.10) by AM4PR08MB0803.eurprd08.prod.outlook.com (10.164.82.157) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 22 Jun 2016 13:17:59 +0000 To: , , References: <1466174654-30130-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <576A9003.4060902@openvz.org> Date: Wed, 22 Jun 2016 16:17:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1466174654-30130-1-git-send-email-den@openvz.org> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM5PR0501CA0006.eurprd05.prod.outlook.com (10.164.187.16) To AM4PR08MB0803.eurprd08.prod.outlook.com (10.164.82.157) X-MS-Office365-Filtering-Correlation-Id: 83e3fd96-a828-406e-adab-08d39a9fa292 X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB0803; 2:e9vWa5RFKSFAQ1Hn3J7ECkVC60rK9aXpgh0NExoX+TvKLn5GVPkg0HCpO7BZcYD3ZELTvVtF+b+NdjFj/iFbzWVcrUDCxCsJ0SZruNDxMV+KEAsbYBtp+ZSqmokVtSOjpzgYpg016HOIgKOxF5W5I/aLPYkjMdZBPZbtdleC6UDtQkhAhD8qjq/0B368usHZ; 3:2KrTEoPRytjShaYSX7d6W7jIyDkfIUESzQUvxhl0Zh+LoLopVsD9HDyk9kkEOUN3BpFTrvvAhFf3FORm52YG+LbtGuVPYblupXjzVnOnRPr/oMHKa86yiD01gL+18MHK; 25:itV2OLuaG+cCsUi3e9bEuMlN0c839YBshm83qnFUUTepEoqxbWTAZ1Q7+n83JjAlMsN2pkYOfZs8gEwOoJKHeaU+Nf1841WUWwGo1lbE7elTOOq5PZf7kmDM+PaG7Z372QpOE4B20sjd9abC4dQckgMrJ5UBpMGnEr5gBFImQ5LqU5OugTh9ifro876tj7x/gkOeXK3TqyskSnM9PjNsMy3EeaCOSjixBBIJIZGZbr7rROT0otdNPwdjPi/bEmZAunbhTHyWHv0dGBOPYE3agGFEcETUspwqNlaWSDBM0e1Im+uA1bPCyquAMGva//yD9u3kHeZX0gLj9hS9qsNcEBYxSfnJpgpqIcda38Voe/Ck8mMR9b781ilQ+QsXD3538aeW26He2hNuaKDFcLo8B7/GCxc3SwYS/Cnio/4NigQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR08MB0803; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046); SRVR:AM4PR08MB0803; BCL:0; PCL:0; RULEID:; SRVR:AM4PR08MB0803; X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB0803; 4:sDf5JE7/XV4FpcczvTSAqDbe6nsmvT5VoFCrQunWSR86qr2FIIsA/PcEsknIjcTeDMViqtFnIiQUYnyEmKvEZQ6nhBGJtrurEUyEOosDXHeB8/5mZhcRlWgbzZ7P3yFgSb2b51AwhJ/FjbmhXtX/t8UNlFVLbTvr3Qh1AO20q2BjvLsXt376G4UJDSd2nvOFNPzACXWdt+lMVRfavTrneODg1uf1bUBulc0kiPOaOanYkr9vGJ3oWqKjk6AZkoVYU6/O3myntUDcNAmAF7MfAV796nYTQBO1+YmtSZAEYww+IgKaDTvnVxcR8lOD5RkAuWUGoxkYH3YaOFiswCoGE0E+ASce+FGA4L9C9t+D04GC+YNaUzK2NfzMEr/Q5wS8W2TikcFVsUAVHJHp+rNkIpkqjKnv91DioR5h3b9jWMI= X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(377454003)(42186005)(230700001)(7846002)(65816999)(65806001)(65956001)(66066001)(36756003)(54356999)(23746002)(101416001)(87266999)(2201001)(80316001)(92566002)(19580405001)(19580395003)(47776003)(64126003)(50466002)(59896002)(81156014)(83506001)(81166006)(8676002)(4326007)(2906002)(6116002)(189998001)(3846002)(586003)(68736007)(50986999)(97736004)(77096005)(2950100001)(105586002)(7736002)(33656002)(106356001)(76176999)(4001350100001)(5001770100001)(42882005)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM4PR08MB0803; H:[10.24.38.119]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; AM4PR08MB0803; 23:ocC0xC+zikJlS5PBDqAqpovnQo+i/yBIQpIfo?= =?Windows-1252?Q?aquRr/eMLIw0xSClB+hZxwC6/pXdqesvLIRjwOglnui4c0StVwM4vpQN?= =?Windows-1252?Q?2CLrkGHbhHGl5+4XfzWHfWOzpkShHjQ0CidBdywP7BzfXXzEtTPnOLea?= =?Windows-1252?Q?vDYBnKK1Zi4hF5xuAVw4DnLIuQYAVFCSZzIFQ00ajEuTpDDSxN9tlp/N?= =?Windows-1252?Q?JSTQq+Cm8WsvDml9nizo0jSstedrtNXeSXueQVv5E0YYZsbwnuHQHno3?= =?Windows-1252?Q?sAG4EV0j6X9NdbBQtk+uGJzgYTCqs8iCMdU23X7t636cF2vTXsIWphbM?= =?Windows-1252?Q?DuL2LExXD0GXLKZ/pdW440vkNREs6y1wL8Ih3JoLh1KN9L6XSzEtE2D9?= =?Windows-1252?Q?lkeQIUGbaevy3VOmAyis4tAgo3R7h0QBPQtidWnqECXu66cOzy2VVeJY?= =?Windows-1252?Q?KCXBNY3ZyWTJ7USnmpg7r88OVNzEyCntVKrNU3KPN20tWqSFcnxyUPwm?= =?Windows-1252?Q?NJl2kDAMJNVtbfazWWhFC0YFSAYiZmodD8FUrixtLeZ8RGakqv52R6Ei?= =?Windows-1252?Q?9dtSJf9GTOHGvzbrYUx5+AS/o0inIThWrjjXdlpv519YPqEWR6YHrKO3?= =?Windows-1252?Q?CPmcW9nWQEm0PIUqdbjZeHgytCNg3uklugxP3M8RwKyuflyRXVFTOluU?= =?Windows-1252?Q?6vTnN3R8UlwWRG5X4BcJAduQ43xWIrRYiwK2sv5yOHQWxx/iy0DzbLi5?= =?Windows-1252?Q?YW07JBP3f0pUvj70Q8oC6SdjkBHl94Ro7GRwmlxtGkPIMj+/EhMC1m+P?= =?Windows-1252?Q?t+Ojn2djRvCNGMc/yso0iPHEXNYX2G7GeXN2Nzj5RfLA+HShxiTOzC9V?= =?Windows-1252?Q?fzFrRSHrrmdoDjyeImrFuVh8BNnBS2hQUk9Gbva1o7TmjFD4Ywhx3bmv?= =?Windows-1252?Q?qs0cgGenoaIgxT9LLm9i17LjlsQ5xuVnJkGBJimStZXDRN1oomcMYmNc?= =?Windows-1252?Q?ERsWllcp9mlnQasAA4HFRPhcYjm440bpKILCHCEkJiaq557GvhEG5RyQ?= =?Windows-1252?Q?kAEeAR1RLrFnLa2xEz3+jiUv8B60msTXnyWjge43LgcvbG5ZJTSR/HGQ?= =?Windows-1252?Q?XLFX4Kx8o7f5ldj1Yre5EkmZO8nN2kC6HALZXU4mZbONR56GcWvUhQvT?= =?Windows-1252?Q?g0ZP0dgGgWA1k5tt41ie7wjBD2XZtWYRAiiQ0owoEm0imSyex9GDh3O2?= =?Windows-1252?Q?mXbNWV5gOAk8r/bGmxuQ37x8NQS03EJfTtyRSNOEKSJXhuZBo6dxNN0W?= =?Windows-1252?Q?w9nzp3eufLgnYGexSu5fvR3jPEGQtvERrE8lYb+iyEoZi8I9EPYHBmy4?= =?Windows-1252?Q?oaEHVvw1t5Wj7DA2cLdAogTLPSnnQZQ+ThVgmthJWVHpRb95gSixzM?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB0803; 6:YbSTXzwhTIXTjsINmIfvD+phCDW344j+ZqktMpxTkcLVRaJwMVnAZJAneRoJ4O1XUuaJXfyLlFjZyzDjTmPAc8kOAnhmGRC7e7T8sJfd51p44L93K4dl4PpFUM58kSElHY7OzQ3STPekXTGMhAw8OkCrlYKWcDWCGsW/mnnNhG4fl0gzLaCTBefcCKPhiE/g6Q7uv0rN/oE1+IH45QQ4+7syE3dlPfGWoI1ifyuM0HwSKhBXaV/JQUdw9jpUJMddqA3Svo6nN78Sh+sTQzmJmRPdMA2LmwbHgEGnKrSV3DvcLiaCDOISZLiKka9CZgPTGpLsJEHdY3ZgV7uTyP3VDg==; 5:QuIuVbjnmAIIhOXj6dxlZBhS/JriT/d/ZtJPSaorMjXKnEm5XQISJ/QM+sJhnfKjbdxoHINvqRLX/F5h+iFK/9EAizuLnHxZ/fDESkF9/sFcQx+rKbL0k6U0AQVC5QhywCamvHYk5N5kjUH3LkEoFA==; 24:UAZlYfYWZf5RMUnSJj4NDHwHhQGT5Cfswzrri53erMS9H33CD8uEFJX0Wf3+vWTvnOQDUasCaSRKmcL/0+u66cOCKuTZGdj3hQdExSTwujA=; 7:RXI3unGUQH+q7S5YnfGI8jhR23R+P0zwSyQ3Q3Mb7t3QvUXuJozHxILozU9BEP01exID48hswplc8RHMf4qWyN/e6kiuFRFmqeZMIyZNyo5MDwnbBaHwlmy0OQN9+c5+LxIZ0zzjOgIx2it0u2wtJ56Sti3U6vC4NKalZJhK4G7f5Tg+iqXULzCF0sLEuQ+rtWZAOnOBRvfpDxIt8n8kV8DjfuswvH+aokcojnVB/rGiRkSHA5ZPt8yJIlAa8Ikhinvyy6BI1834B4Hy2X6FmQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM4PR08MB0803; 20:yw/7kHCN5YxSD3q4sBwaPwqZxlmk2N1cLHaX93eEM2WjeGUg2Z5S+rEUCCJQu8+J8NEchhR2R+ACqFHP2c4kGDXqDKBnkaRfAwpUowV3vDF99uzyj/iefs1t6lVm91ANHAscUnSXO0k0NhMP3XJJRREsirV0e0ew+Nrcsnitc/4= X-OriginatorOrg: openvz.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 13:17:59.4761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB0803 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 X-Received-From: 157.56.112.142 Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 06/17/2016 05:44 PM, Denis V. Lunev wrote: > Changes from v8: > - fixed comment in patch 3 > - changed stub for trace_opt_parse() > > Changes from v7: > - added missed qemu-option-trace.texi > > Changes from v6: > - changed order of patches 1 & 2 > > Changes from v5: > - added missed hunk into patch #7 > > Changes from v4: > - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 > - moved @findex from qemu-option-trace.texi > > Changes from v3: > - fixed difference in help/man for qemu-img/qemu-nbd > - created separate .texi to contain trace description, proper dependency is > added to makefile > - added --version/--help description to qemu-img > - fixed crash induced by new option processing scheme in qemu-img which > has happened when invoked as './qemu-img -K' > > Changes from v2: > - tweaked man-pages of qemu-nbd/qemu-img > - added support for qemu-img (patches 4-5 as suggested) > > Changes from v1: > - fixed nits found by Eric > > Signed-off-by: Denis V. Lunev > Reviewed-by: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > > Denis V. Lunev (7): > doc: sync help descriprion for --trace with man for qemu.1 > doc: move text describing --trace to specific .texi file > trace: move qemu_trace_opts to trace/control.c > trace: enable tracing in qemu-io > trace: enable tracing in qemu-nbd > qemu-img: move common options parsing before commands processing > trace: enable tracing in qemu-img > > Makefile | 7 ++++--- > qemu-img.c | 56 ++++++++++++++++++++++++++++++++++++++------------ > qemu-img.texi | 13 +++++++++++- > qemu-io.c | 18 ++++++++++++---- > qemu-nbd.c | 19 ++++++++++++++++- > qemu-nbd.texi | 3 +++ > qemu-option-trace.texi | 25 ++++++++++++++++++++++ > qemu-options.hx | 29 ++------------------------ > trace/control.c | 42 ++++++++++++++++++++++++++++++++++++- > trace/control.h | 25 ++++++++++++---------- > vl.c | 38 ++-------------------------------- > 11 files changed, 178 insertions(+), 97 deletions(-) > create mode 100644 qemu-option-trace.texi > Stefan, there is a problem in this patchset. It breaks block unit tests in a very interesting place. You should apply the following simple change on top or fix patch 6. Can you pls apply it or I can resend the series. irbis ~/src/qemu $ git diff irbis ~/src/qemu $ getopt_long() behaves very interesting.... Den diff --git a/qemu-img.c b/qemu-img.c index 3322a1e..2351686 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3866,7 +3866,7 @@ int main(int argc, char **argv) return 0; } argv += optind; - optind = 1; + optind = 0; if (!trace_init_backends()) { exit(1);